public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel-01 <edk2-devel@lists.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
	Ryan Harkin <ryan.harkin@linaro.org>,
	 Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 0/9] EmbeddedPkg: eliminate calls to deprecated functions
Date: Fri, 28 Oct 2016 16:16:24 +0100	[thread overview]
Message-ID: <CAKv+Gu9UBhOzfxjujaND=YL+hhY9FdO=FkLwpDo1=wxFpND7sQ@mail.gmail.com> (raw)
In-Reply-To: <1477651478-16830-1-git-send-email-ard.biesheuvel@linaro.org>

On 28 October 2016 at 11:44, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> This series prepares EmbeddedPkg for building with the preprocess symbol
> DISABLE_NEW_DEPRECATED_INTERFACES defined, by adding missing components
> to EmbeddedPkg (#3), fixing broken code or code that relies on deprecated
> functionality (#1 - #2, #4 - #8), and finally adds
> -DDISABLE_NEW_DEPRECATED_INTERFACES to the CC flags for all build types,
> toolchains and architectures.
>
> v2:
> - incorporated Laszlo's feedback
> - add some R-b's
>
> Again, a *big* thank you to Laszlo for taking the time to review these
> patches. I do apologize for not being as thorough as I could have been,
> resulting in issues in the code that Laszlo spotted in his review.
>
> Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=164
>
> Ard Biesheuvel (9):
>   EmbeddedPkg/AndroidFastbootTransportTcpDxe: remove broken hostname
>     handling
>   EmbeddedPkg: remove unused PrePiHobListPointerLib
>   EmbeddedPkg: add missing modules
>   EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size
>   EmbeddedPkg/AndroidFastboot: eliminate deprecated string function
>     calls
>   EmbeddedPkg/Ebl: eliminate deprecated string function calls
>   EmbeddedPkg/EfiFileLib: eliminate deprecated string function calls
>   EmbeddedPkg/MmcDxe: eliminate deprecated string function calls
>   EmbeddedPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES
>

Pushed, with Leif's last comments regarding ARRAY_SIZE () addressed as well.

Many thanks for the time and effort spent in reviewing this!

-- 
Ard.


      parent reply	other threads:[~2016-10-28 15:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 10:44 [PATCH v2 0/9] EmbeddedPkg: eliminate calls to deprecated functions Ard Biesheuvel
2016-10-28 10:44 ` [PATCH v2 1/9] EmbeddedPkg/AndroidFastbootTransportTcpDxe: remove broken hostname handling Ard Biesheuvel
2016-10-28 12:40   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 2/9] EmbeddedPkg: remove unused PrePiHobListPointerLib Ard Biesheuvel
2016-10-28 12:40   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 3/9] EmbeddedPkg: add missing modules Ard Biesheuvel
2016-10-28 12:41   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 4/9] EmbeddedPkg/GdbDebugAgent: fix VOID* cast of incorrect size Ard Biesheuvel
2016-10-28 12:47   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 5/9] EmbeddedPkg/AndroidFastboot: eliminate deprecated string function calls Ard Biesheuvel
2016-10-28 13:18   ` Laszlo Ersek
2016-10-28 13:36   ` Leif Lindholm
2016-10-28 13:40     ` Ard Biesheuvel
2016-10-28 13:52       ` Leif Lindholm
2016-10-28 14:04         ` Ard Biesheuvel
2016-10-28 14:05         ` Laszlo Ersek
2016-10-28 13:41     ` Laszlo Ersek
2016-10-28 10:44 ` [PATCH v2 6/9] EmbeddedPkg/Ebl: " Ard Biesheuvel
2016-10-28 13:31   ` Laszlo Ersek
2016-10-28 14:31   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 7/9] EmbeddedPkg/EfiFileLib: " Ard Biesheuvel
2016-10-28 14:37   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 8/9] EmbeddedPkg/MmcDxe: " Ard Biesheuvel
2016-10-28 13:40   ` Laszlo Ersek
2016-10-28 14:39   ` Leif Lindholm
2016-10-28 10:44 ` [PATCH v2 9/9] EmbeddedPkg: enable -DDISABLE_NEW_DEPRECATED_INTERFACES Ard Biesheuvel
2016-10-28 14:40   ` Leif Lindholm
2016-10-28 15:16 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9UBhOzfxjujaND=YL+hhY9FdO=FkLwpDo1=wxFpND7sQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox