From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0AB3E21194D3F for ; Wed, 5 Dec 2018 00:12:43 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id z7so19942278iti.0 for ; Wed, 05 Dec 2018 00:12:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hfM3/m/zKI/BSNP9U7MKMsxfHo5O+DAk/WYTj6z0tgw=; b=hQdp4PgaatsI7dEsMXBQXcF0wuT4mzdKtCV6d6/REPh49qewtYlmkPp9qJC1rmJAWX IcFTBIdtCWwhdh69NtUMydHqZ3Up0WhE/DrL6kIKztaVtDZobLxX2Ff7W1aUIODlhYfI uKigxiqPnQIbriWYbXRUUzcPSCa72+TDqvQCA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hfM3/m/zKI/BSNP9U7MKMsxfHo5O+DAk/WYTj6z0tgw=; b=blX2e+QHfB+7KXiaoBk5CwN5/QQxP3/8ZpzIiJuuYMinhZb8rwpLjCGx8HegLl4npN OGgxEeDnIToSd4ir3ZtAiq4Pyb5EXcc1F/z7RIvWgmqTqdGjg83DD1BkCrx6NYP4Jk1U qNqOflzZf8M7l1WJBFLf1RikxERw7wOWoOsHebfO6fSOegttbvjNGZj931P1zk4XXK7o HJ1WS4TTP/i2276K0rCUab7AEAAAPRLdaXFkQS24gDk+9YjjTMi/UZYK930QIBkaB9YC cY+0F8CSm4JMU9vDeMOaXeyHLHHmqoeRT5QSP4ZD7brmpl0Yj96HPY1P/533Q9HfB0Qw GbTA== X-Gm-Message-State: AA+aEWakhEuL/W4Tmw1TgnsstmgdqVSBFNcKYMRaR0EL3PKyHod6D+Tf 9CF8ic7jiSYSynOIWQtVICsVeat7wcO4je0oAf2LZA== X-Google-Smtp-Source: AFSGD/XptaPCaiwcjeowkImtce21khfezF9b5mQZBvqk5wSX3csuAwN3KOhyKPfKCYtFV1zuXBH/qtp2ej9+W58/+58= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr14899464itk.71.1543997562550; Wed, 05 Dec 2018 00:12:42 -0800 (PST) MIME-Version: 1.0 References: <20181130224537.18936-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E383BC6@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E383BC6@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 5 Dec 2018 09:12:31 +0100 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "Carsey, Jaben" , Laszlo Ersek , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v2 0/6] BaseTools: get rid of MAX_UINTN X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 08:12:44 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 5 Dec 2018 at 01:04, Gao, Liming wrote: > > Reviewed-by: Liming Gao for this serials. > Thanks all Series pushed as 64ab2c82e8f6..8efc6d84ca41 (with the requested MAX_UINT16 -> MAX_UINT32 change applied) > On patch 4, I have the same comments to Laszlo. > > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard > >Biesheuvel > >Sent: Saturday, December 01, 2018 6:46 AM > >To: edk2-devel@lists.01.org > >Cc: Gao, Liming ; Carsey, Jaben > >; Laszlo Ersek > >Subject: [edk2] [PATCH v2 0/6] BaseTools: get rid of MAX_UINTN > > > >There should be no reason for the build tools to care about the native > >word size of a particular target, so relying on a definition of MAX_UINTN > >is definitely wrong, and most likely inaccurate on 32-bit build hosts. > > > >So refactor the code in CommonLib and DevicePath so we no longer rely > >on this definition. > > > >Changes since v1: > >- miss type change in #1 causing a build failure on MSVC > >- add acks from Jaben > > > >Cc: Laszlo Ersek > >Cc: Yonghong Zhu > >Cc: Liming Gao > >Cc: Bob Feng > >Cc: Jaben Carsey > > > >Ard Biesheuvel (6): > > BaseTools/CommonLib: avoid using 'native' word size in IP address > > handling > > BaseTools/CommonLib: use explicit 64-bit type in Strtoi() > > BaseTools/DevicePath: use explicit 64-bit number parsing routines > > BaseTools/DevicePath: use MAX_UINT16 as default device path max size > > BaseTools/CommonLib: get rid of 'native' type string parsing routines > > BaseTools/CommonLib: drop definition of MAX_UINTN > > > > BaseTools/Source/C/Common/CommonLib.h | 25 --- > > BaseTools/Source/C/Common/CommonLib.c | 206 ++---------------- > > .../Source/C/DevicePath/DevicePathFromText.c | 4 +- > > .../Source/C/DevicePath/DevicePathUtilities.c | 4 +- > > 4 files changed, 25 insertions(+), 214 deletions(-) > > > >-- > >2.19.1 > > > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel