* [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions
@ 2017-11-30 16:13 Ard Biesheuvel
2017-11-30 16:34 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-30 16:13 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, Ard Biesheuvel
The function ArmPlatformInitializeSystemMemory () has been removed from
ArmPlatformLib, so remove all the [empty] implementations provided by
the various platforms.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 13 -------------
Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c | 13 -------------
Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c | 14 --------------
Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c | 15 ---------------
Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c | 14 --------------
Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 13 -------------
6 files changed, 82 deletions(-)
diff --git a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
index 5ec72ff7ed8b..cbc5ed595571 100644
--- a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
+++ b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
@@ -146,19 +146,6 @@ ArmPlatformInitialize (
return Status;
}
-/**
- Initialize the system (or sometimes called permanent) memory
-
- This memory is generally represented by the DRAM.
-
-**/
-VOID
-ArmPlatformInitializeSystemMemory (
- VOID
- )
-{
-}
-
EFI_STATUS
PrePeiCoreGetMpCoreInfo (
OUT UINTN *CoreCount,
diff --git a/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c b/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c
index f4a47b28493a..6bf0d39bd4e2 100644
--- a/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c
+++ b/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c
@@ -111,19 +111,6 @@ ArmPlatformInitialize (
return RETURN_SUCCESS;
}
-/**
- Initialize the system (or sometimes called permanent) memory
-
- This memory is generally represented by the DRAM.
-
-**/
-VOID
-ArmPlatformInitializeSystemMemory (
- VOID
- )
-{
-}
-
EFI_STATUS
PrePeiCoreGetMpCoreInfo (
OUT UINTN *CoreCount,
diff --git a/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c b/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c
index 968d28f813f6..b2b415571c74 100644
--- a/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c
+++ b/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c
@@ -89,20 +89,6 @@ ArmPlatformInitialize (
return RETURN_SUCCESS;
}
-/**
- Initialize the system (or sometimes called permanent) memory
-
- This memory is generally represented by the DRAM.
-
-**/
-VOID
-ArmPlatformInitializeSystemMemory (
- VOID
- )
-{
- //TODO: Initialize DRAM controller here
-}
-
EFI_STATUS
PrePeiCoreGetMpCoreInfo (
OUT UINTN *CoreCount,
diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c
index facfd61ca230..dc59d4f08f5a 100644
--- a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c
+++ b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c
@@ -84,21 +84,6 @@ ArmPlatformInitialize (
}
-/**
- Initialize the system (or sometimes called permanent) memory
-
- This memory is generally represented by the DRAM.
-
-**/
-VOID
-ArmPlatformInitializeSystemMemory (
- VOID
- )
-{
- // Nothing to do here
-}
-
-
//
// Return list of cores in the system
//
diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c
index b59b9f027573..4962543f5531 100644
--- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c
+++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c
@@ -56,20 +56,6 @@ ArmPlatformInitialize (
return RETURN_SUCCESS;
}
-/**
- Initialize the system (or sometimes called permanent) memory
-
- This memory is generally represented by the DRAM.
-
-**/
-VOID
-ArmPlatformInitializeSystemMemory (
- VOID
- )
-{
- // Nothing to do here
-}
-
EFI_STATUS
PrePeiCoreGetMpCoreInfo (
OUT UINTN *CoreCount,
diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c
index 4da0200279cd..6d4be4badb80 100644
--- a/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c
+++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c
@@ -76,19 +76,6 @@ ArmPlatformInitialize (
return RETURN_SUCCESS;
}
-/**
- Initialize the system (or sometimes called permanent) memory
-
- This memory is generally represented by the DRAM.
-
-**/
-VOID
-ArmPlatformInitializeSystemMemory (
- VOID
- )
-{
-}
-
STATIC
EFI_STATUS
PrePeiCoreGetMpCoreInfo (
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions
2017-11-30 16:13 [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions Ard Biesheuvel
@ 2017-11-30 16:34 ` Leif Lindholm
2017-11-30 16:58 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-11-30 16:34 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Thu, Nov 30, 2017 at 04:13:06PM +0000, Ard Biesheuvel wrote:
> The function ArmPlatformInitializeSystemMemory () has been removed from
> ArmPlatformLib, so remove all the [empty] implementations provided by
> the various platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | 13 -------------
> Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c | 13 -------------
> Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c | 14 --------------
> Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c | 15 ---------------
> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c | 14 --------------
> Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | 13 -------------
> 6 files changed, 82 deletions(-)
>
> diff --git a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
> index 5ec72ff7ed8b..cbc5ed595571 100644
> --- a/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
> +++ b/Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c
> @@ -146,19 +146,6 @@ ArmPlatformInitialize (
> return Status;
> }
>
> -/**
> - Initialize the system (or sometimes called permanent) memory
> -
> - This memory is generally represented by the DRAM.
> -
> -**/
> -VOID
> -ArmPlatformInitializeSystemMemory (
> - VOID
> - )
> -{
> -}
> -
> EFI_STATUS
> PrePeiCoreGetMpCoreInfo (
> OUT UINTN *CoreCount,
> diff --git a/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c b/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c
> index f4a47b28493a..6bf0d39bd4e2 100644
> --- a/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c
> +++ b/Platform/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c
> @@ -111,19 +111,6 @@ ArmPlatformInitialize (
> return RETURN_SUCCESS;
> }
>
> -/**
> - Initialize the system (or sometimes called permanent) memory
> -
> - This memory is generally represented by the DRAM.
> -
> -**/
> -VOID
> -ArmPlatformInitializeSystemMemory (
> - VOID
> - )
> -{
> -}
> -
> EFI_STATUS
> PrePeiCoreGetMpCoreInfo (
> OUT UINTN *CoreCount,
> diff --git a/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c b/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c
> index 968d28f813f6..b2b415571c74 100644
> --- a/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c
> +++ b/Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c
> @@ -89,20 +89,6 @@ ArmPlatformInitialize (
> return RETURN_SUCCESS;
> }
>
> -/**
> - Initialize the system (or sometimes called permanent) memory
> -
> - This memory is generally represented by the DRAM.
> -
> -**/
> -VOID
> -ArmPlatformInitializeSystemMemory (
> - VOID
> - )
> -{
> - //TODO: Initialize DRAM controller here
> -}
> -
> EFI_STATUS
> PrePeiCoreGetMpCoreInfo (
> OUT UINTN *CoreCount,
> diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c
> index facfd61ca230..dc59d4f08f5a 100644
> --- a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c
> +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c
> @@ -84,21 +84,6 @@ ArmPlatformInitialize (
> }
>
>
> -/**
> - Initialize the system (or sometimes called permanent) memory
> -
> - This memory is generally represented by the DRAM.
> -
> -**/
> -VOID
> -ArmPlatformInitializeSystemMemory (
> - VOID
> - )
> -{
> - // Nothing to do here
> -}
> -
> -
> //
> // Return list of cores in the system
> //
> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c
> index b59b9f027573..4962543f5531 100644
> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c
> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c
> @@ -56,20 +56,6 @@ ArmPlatformInitialize (
> return RETURN_SUCCESS;
> }
>
> -/**
> - Initialize the system (or sometimes called permanent) memory
> -
> - This memory is generally represented by the DRAM.
> -
> -**/
> -VOID
> -ArmPlatformInitializeSystemMemory (
> - VOID
> - )
> -{
> - // Nothing to do here
> -}
> -
> EFI_STATUS
> PrePeiCoreGetMpCoreInfo (
> OUT UINTN *CoreCount,
> diff --git a/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c b/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c
> index 4da0200279cd..6d4be4badb80 100644
> --- a/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c
> +++ b/Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c
> @@ -76,19 +76,6 @@ ArmPlatformInitialize (
> return RETURN_SUCCESS;
> }
>
> -/**
> - Initialize the system (or sometimes called permanent) memory
> -
> - This memory is generally represented by the DRAM.
> -
> -**/
> -VOID
> -ArmPlatformInitializeSystemMemory (
> - VOID
> - )
> -{
> -}
> -
> STATIC
> EFI_STATUS
> PrePeiCoreGetMpCoreInfo (
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions
2017-11-30 16:34 ` Leif Lindholm
@ 2017-11-30 16:58 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-30 16:58 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 30 November 2017 at 16:34, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Nov 30, 2017 at 04:13:06PM +0000, Ard Biesheuvel wrote:
>> The function ArmPlatformInitializeSystemMemory () has been removed from
>> ArmPlatformLib, so remove all the [empty] implementations provided by
>> the various platforms.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks. Pushed as a58dcf22b42c
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-30 16:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 16:13 [PATCH edk2-platforms] Platform Silicon: remove ArmPlatformInitializeSystemMemory () functions Ard Biesheuvel
2017-11-30 16:34 ` Leif Lindholm
2017-11-30 16:58 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox