public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements
Date: Thu, 19 Dec 2019 16:55:27 +0000	[thread overview]
Message-ID: <CAKv+Gu9UmZzbyiOqgvt5hBAi1xiztvcC_B1J0awOEd38GsaB7A@mail.gmail.com> (raw)
In-Reply-To: <20191219121434.2856-1-pete@akeo.ie>

On Thu, 19 Dec 2019 at 14:14, Pete Batard <pete@akeo.ie> wrote:
>
> Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348):
> * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use
>   those in the SPCR and DBG2 tables
> * Use default values in FADT wherever possible
> * Drop MCFG table
> * Improve computation of MMIO window in XHCI table
> * Improve/clarify macro definitions in XHCI table
> * Fix a typo in one of the new sections from the Readme
>
> Andrei Warkentin (1):
>   Platform/RPi4: Add XHCI ACPI table
>
> Ard Biesheuvel (1):
>   Platform/RPi4: Add ACPI basic mode build option
>
> Pete Batard (5):
>   Silicon/Bcm283x: Add UART constants for PL011 and miniUART
>   Platform/RPi4: Clean up ACPI definitions
>   Platform/RPi4: Improve FADT ACPI table generation
>   Platform/RPi4: Improve SPCR and DBG2 ACPI table generation
>   Platform/RPi4: Add switch to select between PL011 and miniUART
>

For the series
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 8187c6f35035..e9395c53ba2c

Thanks all


>  Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf    |   3 +
>  Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c   |   8 ++
>  Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h           |  12 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf         |   8 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc              |  42 +++---
>  Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc              | 105 +++++++++++++--
>  Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl               |   1 +
>  Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc              |  99 ++++++++++----
>  Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc              |  30 ++---
>  Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc              |  11 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl                |   4 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.c                  |   6 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Pep.h                  |   8 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl               |  48 -------
>  Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc              |  96 ++++++++++++++
>  Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl               |   6 +-
>  Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl               | 137 ++++++++++++++++++++
>  Platform/RaspberryPi/RPi4/RPi4.dsc                          |  29 +++++
>  Platform/RaspberryPi/RPi4/RPi4.fdf                          |   7 +
>  Platform/RaspberryPi/RPi4/Readme.md                         |  52 ++++++--
>  Platform/RaspberryPi/RaspberryPi.dec                        |   3 +
>  Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h |  17 ++-
>  22 files changed, 570 insertions(+), 162 deletions(-)
>  delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc
>  create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl
>
> --
> 2.21.0.windows.1
>

  parent reply	other threads:[~2019-12-19 16:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 12:14 [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements Pete Batard
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 1/7] Silicon/Bcm283x: Add UART constants for PL011 and miniUART Pete Batard
2019-12-19 13:27   ` Philippe Mathieu-Daudé
2019-12-19 13:32     ` Ard Biesheuvel
2019-12-19 14:11       ` Philippe Mathieu-Daudé
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 2/7] Platform/RPi4: Clean up ACPI definitions Pete Batard
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 3/7] Platform/RPi4: Improve FADT ACPI table generation Pete Batard
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 4/7] Platform/RPi4: Improve SPCR and DBG2 " Pete Batard
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 5/7] Platform/RPi4: Add switch to select between PL011 and miniUART Pete Batard
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 6/7] Platform/RPi4: Add XHCI ACPI table Pete Batard
2019-12-19 13:12   ` Ard Biesheuvel
2019-12-19 13:32     ` Pete Batard
2019-12-19 13:33       ` Ard Biesheuvel
2019-12-19 12:14 ` [edk2-platforms][PATCH v2 7/7] Platform/RPi4: Add ACPI basic mode build option Pete Batard
2019-12-19 16:55 ` Ard Biesheuvel [this message]
2019-12-19 17:20   ` [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements Pete Batard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9UmZzbyiOqgvt5hBAi1xiztvcC_B1J0awOEd38GsaB7A@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox