From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.470.1576774534360270839 for ; Thu, 19 Dec 2019 08:55:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=wNTGHFOT; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f65.google.com with SMTP id w15so6724440wru.4 for ; Thu, 19 Dec 2019 08:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W+GcWzRFYvAC8UdSlvRse7o+IBsc+CIN1cDnZuWtTvk=; b=wNTGHFOTNZte35vHC0pntJZx+9NRDdxPQFCKSr8mjxy2cok3Il+HXdu6O4Rjb3sXc0 eeE5rRO9Em49K6UKog8h6nkKLvOp2HM0amFC6UyIzskc59I5t7E30ETZCHPIm4eYPBot Nmg3V0K7kRlX/q+JOhcELQOR7milB0zc2g7Y2tiGsR3PQdExZlDpDI5SIbox0ULzYtRb si0lC0R/3ME2WEBCcvIESpk8+SQGEnxcM/WR7HG9B0Ux0RATnCmHyAfeZwoT03kwvL9+ sXkO+Btw1V8/X9hFwBOCaie+oo8KTbyis9NO5b7qBv1TbHxwgF+HHCccIXGd0Z9w1gox 5AaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W+GcWzRFYvAC8UdSlvRse7o+IBsc+CIN1cDnZuWtTvk=; b=QPBbDg3+WyYzeMzOajIn8pN/WTLU3OLN/JT3rPrZDktKlk91mUkW/efr6Vz2NiwlTV 1h0GIh9qsak9x2l3f+iJ/gF/3sq9yAuOxSnCijYxQasPU9yM+MuPc7it1fF1+ZURGEM0 e9R33j1TQIC4drKkFLAgKbOfBxnCtpW+tgmM8QO924aABMmmeVnKsN0z4FZlclj6TNn9 yOUABC5NLwhWaUqwnzywGuOigWKFym5FVZJBlGzdJuDnr/veRgh8YuLe+0GyLkF4i6vz FcfaA6RaCTFjSVA2gZzogXrz2Q4kweHqopqXThAxTZjdoXcS5LaLkzBh2iLLcgmCbvzJ 9IgA== X-Gm-Message-State: APjAAAVwBkd/2SXJcg4r/oaT34aP/XKXTAbFX5keEod6bxcSdmMlMcb+ PK9umVcSkBoQ76a/KBnTgK2RHZN4jl4YwCrnYMR4Pg== X-Google-Smtp-Source: APXvYqxyxMxF93LvxIdnOyXWeCKdFP1d7RA2x/gdn+TkVORFDV/79ZX0/u4fHm3DcZw7fQh/uNYlxubPL9/Q/L9Zp4I= X-Received: by 2002:a5d:5345:: with SMTP id t5mr10982183wrv.0.1576774532846; Thu, 19 Dec 2019 08:55:32 -0800 (PST) MIME-Version: 1.0 References: <20191219121434.2856-1-pete@akeo.ie> In-Reply-To: <20191219121434.2856-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Thu, 19 Dec 2019 16:55:27 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v2 0/7] Platform/RPi4: ACPI improvements To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Thu, 19 Dec 2019 at 14:14, Pete Batard wrote: > > Changes from v1 (https://edk2.groups.io/g/devel/message/52342 - 52348): > * Add PL011 and miniUART constants in Silicon/.../Bcm2836.h and use > those in the SPCR and DBG2 tables > * Use default values in FADT wherever possible > * Drop MCFG table > * Improve computation of MMIO window in XHCI table > * Improve/clarify macro definitions in XHCI table > * Fix a typo in one of the new sections from the Readme > > Andrei Warkentin (1): > Platform/RPi4: Add XHCI ACPI table > > Ard Biesheuvel (1): > Platform/RPi4: Add ACPI basic mode build option > > Pete Batard (5): > Silicon/Bcm283x: Add UART constants for PL011 and miniUART > Platform/RPi4: Clean up ACPI definitions > Platform/RPi4: Improve FADT ACPI table generation > Platform/RPi4: Improve SPCR and DBG2 ACPI table generation > Platform/RPi4: Add switch to select between PL011 and miniUART > For the series Reviewed-by: Ard Biesheuvel Pushed as 8187c6f35035..e9395c53ba2c Thanks all > Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf | 3 + > Platform/RaspberryPi/Library/PlatformLib/RaspberryPiMem.c | 8 ++ > Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.h | 12 +- > Platform/RaspberryPi/RPi4/AcpiTables/AcpiTables.inf | 8 +- > Platform/RaspberryPi/RPi4/AcpiTables/Csrt.aslc | 42 +++--- > Platform/RaspberryPi/RPi4/AcpiTables/Dbg2.aslc | 105 +++++++++++++-- > Platform/RaspberryPi/RPi4/AcpiTables/Dsdt.asl | 1 + > Platform/RaspberryPi/RPi4/AcpiTables/Fadt.aslc | 99 ++++++++++---- > Platform/RaspberryPi/RPi4/AcpiTables/Gtdt.aslc | 30 ++--- > Platform/RaspberryPi/RPi4/AcpiTables/Madt.aslc | 11 +- > Platform/RaspberryPi/RPi4/AcpiTables/Pep.asl | 4 +- > Platform/RaspberryPi/RPi4/AcpiTables/Pep.c | 6 +- > Platform/RaspberryPi/RPi4/AcpiTables/Pep.h | 8 +- > Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl | 48 ------- > Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc | 96 ++++++++++++++ > Platform/RaspberryPi/RPi4/AcpiTables/Uart.asl | 6 +- > Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl | 137 ++++++++++++++++++++ > Platform/RaspberryPi/RPi4/RPi4.dsc | 29 +++++ > Platform/RaspberryPi/RPi4/RPi4.fdf | 7 + > Platform/RaspberryPi/RPi4/Readme.md | 52 ++++++-- > Platform/RaspberryPi/RaspberryPi.dec | 3 + > Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 17 ++- > 22 files changed, 570 insertions(+), 162 deletions(-) > delete mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.asl > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Spcr.aslc > create mode 100644 Platform/RaspberryPi/RPi4/AcpiTables/Xhci.asl > > -- > 2.21.0.windows.1 >