From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BB32B20969643 for ; Mon, 21 May 2018 01:55:05 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id e78-v6so13464329iod.0 for ; Mon, 21 May 2018 01:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UsocEBevUlxTmLos9AgA2q3+uhpyB+5yJbVlFnImw/A=; b=SIF63O/7x7Un5wVQOoaKXMmNo4LWS76oPbd/BbjoAerauGwpTyISlkSXZXAGYHTAfL 2A3vizL565phqZ7dgciSTQZgEPeYrbwhM5uSg/3MMcGR1Xvsag7C0Bb2QDh4JPBmxh/5 bZmv+yDr8MjhK7Ju79oid9FK7rEMdEVeLf5YI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UsocEBevUlxTmLos9AgA2q3+uhpyB+5yJbVlFnImw/A=; b=f+I1Eyw91LJXbv9IPdpxDtAQ1cG5bMlJOF5bJ8VfYv75ObOV0/Q3HRoy9urJUWT42n Mwncml8rm+RQzLwskLGWJsNm8gJj1RspFJQ1mgVHBe44xqAWC2g+aVqI0E8dwD6XOGZM 5obHCNFvIci4FJEBBJj3Sz1XPypWgopn2KEIEe0TYm9NRxeahw2tvkKZ9MNq7IctB2qF g4nXI923qFCrzkAE9c7/gP/mv3uJ8Eei7ZCbN/HfSdLxiiqCKTRup3RMNbDEzg5QECcc NhxU95P5y6QNJ/jHYcQK+QfP043txPfaWIfXFu2sXPFKNQ0O8onRJ/xBWYixKRq2PEwE SIAw== X-Gm-Message-State: ALKqPweIpM+47NPAz6SoQdv99yDaF3uF9e2zizAV28WEWZY7A2trIX7a uI/8kfcDGxQzbHnZszRVoiYztUDWFL2YE3TX/zo9rQ== X-Google-Smtp-Source: AB8JxZqJywaEN9DiO4pJ9p+Oucr+1E/xUFSWSqfpZXOtPiTkPiasF3bNVe4FRb/iArFPo2CokC1P5SkTnaVwOu0Fk5o= X-Received: by 2002:a6b:268b:: with SMTP id m133-v6mr21539746iom.107.1526892904923; Mon, 21 May 2018 01:55:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.134 with HTTP; Mon, 21 May 2018 01:55:04 -0700 (PDT) In-Reply-To: <1526891152-18739-4-git-send-email-thomas.abraham@arm.com> References: <1526891152-18739-1-git-send-email-thomas.abraham@arm.com> <1526891152-18739-4-git-send-email-thomas.abraham@arm.com> From: Ard Biesheuvel Date: Mon, 21 May 2018 10:55:04 +0200 Message-ID: To: Thomas Abraham Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Daniil Egranov Subject: Re: [PATCH edk2-platforms v4 3/9] Platform/ARM/Sgi: add initial platform dxe driver implementation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 08:55:05 -0000 Content-Type: text/plain; charset="UTF-8" On 21 May 2018 at 10:25, Thomas Abraham wrote: > From: Daniil Egranov > > Add a initial platform dxe driver which starts of being almost > an empty implementation. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Daniil Egranov > Signed-off-by: Thomas Abraham > --- > .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 25 ++++++++ > .../ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 73 ++++++++++++++++++++++ > 2 files changed, 98 insertions(+) > create mode 100644 Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > create mode 100644 Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > new file mode 100644 > index 0000000..eb26fde > --- /dev/null > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -0,0 +1,25 @@ > +/** @file > +* > +* Copyright (c) 2018, ARM Limited. All rights reserved. > +* > +* This program and the accompanying materials are licensed and made available > +* under the terms and conditions of the BSD License which accompanies this > +* distribution. The full text of the license may be found at > +* http://opensource.org/licenses/bsd-license.php > +* > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +* > +**/ > + > +#include > + > +EFI_STATUS > +EFIAPI > +ArmSgiPkgEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + return EFI_SUCCESS; > +} > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > new file mode 100644 > index 0000000..dbe04c5 > --- /dev/null > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > @@ -0,0 +1,73 @@ > +# > +# Copyright (c) 2018, ARM Limited. All rights reserved. > +# > +# This program and the accompanying materials are licensed and made available > +# under the terms and conditions of the BSD License which accompanies this > +# distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > + > +[Defines] > + INF_VERSION = 0x0001001A > + BASE_NAME = PlatformDxe > + FILE_GUID = 54cee352-c4cd-4d80-8524-54325c3a528e > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + ENTRY_POINT = ArmSgiPkgEntryPoint > + > +[Sources.common] > + PlatformDxe.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + ArmPlatformPkg/ArmPlatformPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec > + MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > + Platform/ARM/SgiPkg/SgiPlatform.dec > + > +[LibraryClasses] > + AcpiLib > + BaseMemoryLib > + DebugLib > + DxeServicesTableLib > + FdtLib > + HobLib > + IoLib > + PcdLib > + PrintLib > + SerialPortLib > + UefiBootServicesTableLib > + UefiRuntimeServicesTableLib > + UefiLib > + UefiDriverEntryPoint > + VirtioMmioDeviceLib > + > +[Guids] > + gEfiEndOfDxeEventGroupGuid > + gEfiFileInfoGuid > + gEfiHobListGuid > + gFdtTableGuid > + gEfiAcpi10TableGuid > + gEfiAcpiTableGuid > + gSgi575AcpiTablesiFileGuid > + > +[Protocols] > + gEfiBlockIoProtocolGuid > + gEfiDevicePathFromTextProtocolGuid > + gEfiSimpleFileSystemProtocolGuid > + > +[FeaturePcd] > + gArmSgiTokenSpaceGuid.PcdVirtioSupported > + > +[FixedPcd] > + gArmTokenSpaceGuid.PcdSystemMemoryBase > + gArmTokenSpaceGuid.PcdSystemMemorySize > + gArmTokenSpaceGuid.PcdHypFvBaseAddress > + gArmTokenSpaceGuid.PcdHypFvSize > + As I mentioned in my review of v1: I think it is fine to start with an empty stub for a driver, but please don't limit that to the C file. None of these library classes, guids, protocols or PCDs are being used in this patch. References to them should be added along with the code that actually uses those references. > +[Depex] > + TRUE > -- > 2.7.4 >