From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 90E0F21A6F106 for ; Tue, 4 Apr 2017 07:26:29 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id b140so96570870iof.1 for ; Tue, 04 Apr 2017 07:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yRUyWr6ZfQI5tbIdNnGV5/mCLTNTbZwG1IquIGNFr1U=; b=Qc20+/Jev6yTzXv8JO12faq9cuQxog4dxTwxsv5FbBcObZm+9SDVQpIjG/Y0xDE8bE DxvBvrrijvnSmB1izFx7k1YKveliWLOkRgVUymyfG2gnuzjK92y7YQWnSEMSBCXyibWq QqYvDVSmAasbAEOyYYsv4PPh6+JDJdq/PJ3rE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yRUyWr6ZfQI5tbIdNnGV5/mCLTNTbZwG1IquIGNFr1U=; b=UKKPg+rydEBXly/aOxf0T9GSS9boz4XgtVUr25IiOHWX5CetAEqA++yKtVmS5A+IZD +x6YGCs7fEkps0RPUqWE3Pkxy6uaRPvIDiEzEze34EDUkoBw1mKHtCnTQ0CY3WJRdg/8 ELK2Zfx07o8ZIZRgkF1CjdtTUNNlxxLyDHEo6VpyNTl3nlBxPt7xHAnX8fWZMJinn/jJ hKa32eMa9ZQwHNFmSmlb6Kw6EtW6UdFnhh8vqR3M0k6iKJHNOdAIeQUOgwOGwJ13PUh7 rYqHLNtXXoyOJ4j9DOucE+iPNJTtQC0Y+I+kqEfPXaqs3+02gUbh6ncqFQmjl8jeva9r UBVQ== X-Gm-Message-State: AFeK/H2+pa+s3JUDieIJSal7xxRLU24SZLWA+pyPAV0GojQ9rMz61IgVqtYGGrFZR01mKvxOIHRPrrac0E2qlYSW X-Received: by 10.107.132.155 with SMTP id o27mr21459107ioi.138.1491315988542; Tue, 04 Apr 2017 07:26:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Tue, 4 Apr 2017 07:26:28 -0700 (PDT) In-Reply-To: References: <20170404132409.20422-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 4 Apr 2017 15:26:28 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Jens Wiklander Subject: Re: [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay' X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 14:26:29 -0000 Content-Type: text/plain; charset=UTF-8 On 4 April 2017 at 15:16, Laszlo Ersek wrote: > On 04/04/17 15:24, Ard Biesheuvel wrote: >> The DT passed to us by QEMU may contain nodes that are supposed to be >> consumed by the secure world only. In some case, their status may be >> set to 'secure', but 'disabled' occurs as well, if the secure OS has >> actually modified the DT. >> >> Since as a general rule, DT nodes should only be consumed if they lack a >> status or if their status equals 'okay', update our DT node parsing >> routines accordingly. >> >> Ard Biesheuvel (3): >> ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into >> account >> ArmVirtPkg/FdtPL011SerialPortLib: take DT node 'status' property into >> account >> ArmVirtPkg/PlatformPeiLib: take DT node 'status' property into account >> >> ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 8 ++++++++ >> ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c | 6 ++++++ >> ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c | 7 +++++++ >> 3 files changed, 21 insertions(+) >> > > Please re-wrap commit messages #2 and #3 to a width of 74 characters. > > The subject lines are also too long (on patches #1 and #2); please come > up with alternatives that fit into 74 characters. For example, replace > > take DT xxx node 'status' property into account > > with > > honor DT xxx node 'status' property > > With that, series > Reviewed-by: Laszlo Ersek > Thanks Pushed as d014044395b5 ArmVirtPkg/FdtClientDxe: honor memory DT node 'status' property b1f3e48ed8f9 ArmVirtPkg/FdtPL011SerialPortLib: honor DT node 'status' property 83ae7589b08a ArmVirtPkg/PlatformPeiLib: honor DT node 'status' property