From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22c; helo=mail-io0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0DADD2257C2C2 for ; Mon, 5 Mar 2018 06:51:51 -0800 (PST) Received: by mail-io0-x22c.google.com with SMTP id v6so18263138iog.7 for ; Mon, 05 Mar 2018 06:58:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=naL9pCYUdVAGypqDs6LJdmJP+kWkeBwBULDrrn0/tM8=; b=iM+/xAwSKkyhtLpLZYRDcPD59nmfQ4AKgV7/mOHjYEeOHAlzRIB32kfW0C2RkZAZDg tQXJnorE4r4BDACXqvCnsIeDaankqv3npfySsOWtEw522jHhBxFTTlgQRPN1+iPGV1vF cu36PNel4pGxGBkjuZ4LYCagPWOSBijKOE374= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=naL9pCYUdVAGypqDs6LJdmJP+kWkeBwBULDrrn0/tM8=; b=l1BPabeXArvVh1gNH7PCunEEHmfeXOsCXQxC/RUQimoQNe1jYiFmdq/zkCI2GZ3oXf gQ2OjonCAkVgiDB2xg/FAwkNX/V/duTr5nEZ+WpVyamZPKyLd5QFp21U+JqbZ5M/anLk EVOwbWuCWgtKyH4z8C0jcgy8rBTKh6RqaXX6tNtLJozlHxbysvYyjC0LgGn2JWYYyZnH Uk0kSmUSw5zkQ7hH9hQ4YajyxhwEp/xks10VZyG0rCNx22RrEeeCOsl51uxhYvMPfk2o XrcWeEp4BRrqeAlBjDB9INbQXx/G0/us80oJdUMlhdb0ySvMlGwxS9hxA2Q/EPOWQues DDkA== X-Gm-Message-State: APf1xPCz2f22Yi4bRZ7w77MC73gFVU9J8NwFJbHbKjjlgQq7xtOyZ/iv slrsB5+xxq/9GtvptPztPEHHZJyv+5g+uiDtS3nzHA== X-Google-Smtp-Source: AG47ELsA5pfNgJyzla59GXtdus3VWnv+roBeqlf/luqgcerSdhs9SmtBvP7KbH711vdtT1FKegkDPWur9d+kbJ9LPjE= X-Received: by 10.107.5.199 with SMTP id 190mr18353291iof.107.1520261883789; Mon, 05 Mar 2018 06:58:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Mon, 5 Mar 2018 06:58:02 -0800 (PST) In-Reply-To: <20180305145311.83104-1-sami.mujawar@arm.com> References: <20180305145311.83104-1-sami.mujawar@arm.com> From: Ard Biesheuvel Date: Mon, 5 Mar 2018 14:58:02 +0000 Message-ID: To: Sami Mujawar Cc: "edk2-devel@lists.01.org" , "Kinney, Michael D" , "Gao, Liming" , Leif Lindholm , Evan Lloyd , Matteo Carlini , Stephanie.Hughes-Fitt@arm.com, nd Subject: Re: [PATCH v1] MdePkg: SMMUv3 updates for IORT table definitions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 14:51:52 -0000 Content-Type: text/plain; charset="UTF-8" On 5 March 2018 at 14:53, Sami Mujawar wrote: > Updated the IORT SMMUv3 Node structure and flags to match the > IO Remapping Table, Platform Design Document, Revision C dated > 15 MAY 2017. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > > The changes can be seen at https://github.com/samimujawar/edk2/tree/236_ioremapping_header_v1 > > Notes: > v1: > - Updated SMMUv3 node structure and associated flags. [SAMI] > > MdePkg/Include/IndustryStandard/IoRemappingTable.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/IoRemappingTable.h b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > index c113afdd27843111bc7ad6e1de1108260fad2bbc..2e5cb45d7e2ffd4a0559ef706b71874843e3fdbd 100644 > --- a/MdePkg/Include/IndustryStandard/IoRemappingTable.h > +++ b/MdePkg/Include/IndustryStandard/IoRemappingTable.h > @@ -4,6 +4,7 @@ > http://infocenter.arm.com/help/topic/com.arm.doc.den0049c/DEN0049C_IO_Remapping_Table.pdf > > Copyright (c) 2017, Linaro Limited. All rights reserved.
> + Copyright (c) 2018, ARM Limited. All rights reserved.
> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > @@ -53,6 +54,11 @@ > > #define EFI_ACPI_IORT_SMMUv3_FLAG_COHAC_OVERRIDE BIT0 > #define EFI_ACPI_IORT_SMMUv3_FLAG_HTTU_OVERRIDE BIT1 > +#define EFI_ACPI_IORT_SMMUv3_FLAG_PROXIMITY_DOMAIN BIT3 > + > +#define EFI_ACPI_IORT_SMMUv3_MODEL_GENERIC 0x0 > +#define EFI_ACPI_IORT_SMMUv3_MODEL_HISILICON_HI161X 0x1 > +#define EFI_ACPI_IORT_SMMUv3_MODEL_CAVIUM_CN99XX 0x2 > > #define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED 0x0 > #define EFI_ACPI_IORT_ROOT_COMPLEX_ATS_SUPPORTED 0x1 > @@ -165,7 +171,7 @@ typedef struct { > } EFI_ACPI_6_0_IO_REMAPPING_SMMU_NODE; > > /// > -/// Node type 4: SMMUv4 node > +/// Node type 4: SMMUv3 node > /// > typedef struct { > EFI_ACPI_6_0_IO_REMAPPING_NODE Node; > @@ -179,6 +185,9 @@ typedef struct { > UINT32 Pri; > UINT32 Gerr; > UINT32 Sync; > + UINT8 ProximityDomain; > + UINT8 Reserved1[3]; > + UINT32 DeviceIdMappingIndex; > } EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE; > > /// > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >