From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPlatformPkg/PL011SerialPortLib: use untyped PCD for register base
Date: Thu, 20 Dec 2018 18:35:49 +0100 [thread overview]
Message-ID: <CAKv+Gu9WLMQyxmp5-mtYzHYWvD_6MiJEkzidvGJA9xawzTViEA@mail.gmail.com> (raw)
In-Reply-To: <20181220152051.dbqbzi46hpl5ymls@bivouac.eciton.net>
On Thu, 20 Dec 2018 at 16:20, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Mon, Dec 17, 2018 at 07:51:45PM +0100, Ard Biesheuvel wrote:
> > Use an untyped PCD reference for PcdSerialRegisterBase, so that the
> > library gets built without hardcoded values, permitting modules to
> > override the default serial port. This allows SerialDxe to use a
> > different serial port from the one used for DEBUG output (which
> > often gets occluded due to the console driver clearing the screen)
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as 6f42f9a54bf0..5a9b3eb8e5fb
> > ---
> > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c | 14 +++++++-------
> > ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf | 4 +++-
> > 2 files changed, 10 insertions(+), 8 deletions(-)
> >
> > diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> > index 212991d63859..d576f79c3e6e 100644
> > --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> > +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> > @@ -48,7 +48,7 @@ SerialPortInitialize (
> > StopBits = (EFI_STOP_BITS_TYPE) FixedPcdGet8 (PcdUartDefaultStopBits);
> >
> > return PL011UartInitializePort (
> > - (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
> > + (UINTN)PcdGet64 (PcdSerialRegisterBase),
> > PL011UartClockGetFreq(),
> > &BaudRate,
> > &ReceiveFifoDepth,
> > @@ -75,7 +75,7 @@ SerialPortWrite (
> > IN UINTN NumberOfBytes
> > )
> > {
> > - return PL011UartWrite ((UINTN)FixedPcdGet64 (PcdSerialRegisterBase), Buffer, NumberOfBytes);
> > + return PL011UartWrite ((UINTN)PcdGet64 (PcdSerialRegisterBase), Buffer, NumberOfBytes);
> > }
> >
> > /**
> > @@ -95,7 +95,7 @@ SerialPortRead (
> > IN UINTN NumberOfBytes
> > )
> > {
> > - return PL011UartRead ((UINTN)FixedPcdGet64 (PcdSerialRegisterBase), Buffer, NumberOfBytes);
> > + return PL011UartRead ((UINTN)PcdGet64 (PcdSerialRegisterBase), Buffer, NumberOfBytes);
> > }
> >
> > /**
> > @@ -111,7 +111,7 @@ SerialPortPoll (
> > VOID
> > )
> > {
> > - return PL011UartPoll ((UINTN)FixedPcdGet64 (PcdSerialRegisterBase));
> > + return PL011UartPoll ((UINTN)PcdGet64 (PcdSerialRegisterBase));
> > }
> > /**
> > Set new attributes to PL011.
> > @@ -156,7 +156,7 @@ SerialPortSetAttributes (
> > )
> > {
> > return PL011UartInitializePort (
> > - (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
> > + (UINTN)PcdGet64 (PcdSerialRegisterBase),
> > PL011UartClockGetFreq(),
> > BaudRate,
> > ReceiveFifoDepth,
> > @@ -198,7 +198,7 @@ SerialPortSetControl (
> > IN UINT32 Control
> > )
> > {
> > - return PL011UartSetControl ((UINTN)FixedPcdGet64 (PcdSerialRegisterBase), Control);
> > + return PL011UartSetControl ((UINTN)PcdGet64 (PcdSerialRegisterBase), Control);
> > }
> >
> > /**
> > @@ -239,5 +239,5 @@ SerialPortGetControl (
> > OUT UINT32 *Control
> > )
> > {
> > - return PL011UartGetControl ((UINTN)FixedPcdGet64 (PcdSerialRegisterBase), Control);
> > + return PL011UartGetControl ((UINTN)PcdGet64 (PcdSerialRegisterBase), Control);
> > }
> > diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> > index 5ce5b2f5304c..bca7bed875c6 100644
> > --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> > +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> > @@ -36,8 +36,10 @@
> > MdeModulePkg/MdeModulePkg.dec
> > ArmPlatformPkg/ArmPlatformPkg.dec
> >
> > -[FixedPcd]
> > +[Pcd]
> > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> > +
> > +[FixedPcd]
> > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate
> > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits
> > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultParity
> > --
> > 2.17.1
> >
prev parent reply other threads:[~2018-12-20 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 18:51 [PATCH] ArmPlatformPkg/PL011SerialPortLib: use untyped PCD for register base Ard Biesheuvel
2018-12-18 10:01 ` Philippe Mathieu-Daudé
2018-12-20 15:20 ` Leif Lindholm
2018-12-20 17:35 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9WLMQyxmp5-mtYzHYWvD_6MiJEkzidvGJA9xawzTViEA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox