From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1897F2095DCB8 for ; Tue, 29 Aug 2017 09:32:29 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id 81so22721167ioj.5 for ; Tue, 29 Aug 2017 09:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AvpwGZr/CrDwqk4SVsqQxjxcYMAfAAIPOLSpfCqlyIw=; b=RR6G0m4ZeAmSWs9zb3sKNWNK59LhF0f+X+b0CSrJt3H8AhI4z3Sw6wdaTgNtj4QJJ9 8wZIXldU47fofvgE2HYKTUCrSeTVKPBKZHlYHTSCnKSy04i0lpjdtbMKXzJWg7MTjqHy YXYN1jZQVpWTVktlzoL2PZpI5JKyyo05TyBNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AvpwGZr/CrDwqk4SVsqQxjxcYMAfAAIPOLSpfCqlyIw=; b=DRNcSfNOkJjt2oyTTApQdrIc2MoQ9NPT6YIl9QH+J6Tj/T9YvBqRfseCtnqAwFA0eu 54qB97HPS/6SKNWmvH8NU6TwSqnnAx+UKbXrJGsKfqhStl6lItc9kRY5WntL/QY0Jtvi 0F4iV2EcpV17IDZMIyUYv2J4NkIsQYYBCUGowDrfVndJnDnY9df5BUhFCmEzBSCUOLDJ Ywxh+JlDDdd94XZApgYRX66pGloUxxU+FTxjLOa4GX+NmJm4shb8q8usFMl2F+/YTjPm Epm2Z91OKnAa4KT5TkhQdVrQ2QXKpHQYFbG/vVRtgoyF6qphPt8lBOUCl1IAHYYG1ua2 MqWQ== X-Gm-Message-State: AHYfb5gFQj34oEUp9mY730Hk/kOu3GYFh1GPH6VED9lM09cJbUAw6NG/ BqKsJFunFYMiqufUR4Pokd1XLNAJkmE6 X-Received: by 10.36.91.195 with SMTP id g186mr4568121itb.63.1504024509177; Tue, 29 Aug 2017 09:35:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 09:35:08 -0700 (PDT) In-Reply-To: References: <20170824202132.24624-1-ard.biesheuvel@linaro.org> <20170829150014.qic7gcivheyc2myw@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 29 Aug 2017 17:35:08 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Chenhui Sun , Graeme Gregory , Heyi Guo Subject: Re: [PATCH] Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 16:32:29 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 16:02, Ard Biesheuvel wrote: > On 29 August 2017 at 16:00, Leif Lindholm wrote: >> On Thu, Aug 24, 2017 at 09:21:32PM +0100, Ard Biesheuvel wrote: >>> Replace the open coded PCI 'emulation' with a simple call into >>> the NonDiscoverable device registration library, and fix up all >>> platform .DSCs/FDFs accordingly. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ard Biesheuvel >> >> D02 no longer builds after (the fixed version, based on your >> follow-up) is applied: >> >> edk2-platforms/Platform/Hisilicon/D02/Pv660D02.dsc(...): error 4000: >> Instance of library class [UncachedMemoryAllocationLib] is not found in >> [/work/maint/edk2-platforms/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf] >> [AARCH64] >> consumed by module [/work/maint/edk2-platforms/Silicon/Hisilicon/Drivers/SasV1Dxe/SasV1Dxe.inf] >> >> That does appear to be a false dependency though, so if you can fold >> in its deletion: >> Reviewed-by: Leif Lindholm > > Ah yes, I already had a separate patch for that, which is why I didn't notice. > Pushed as 260c957a962e Silicon/Hisilicon/SasV1Dxe: remove bogus UncachedMemoryAllocationLib ref 2f03dc80017c Silicon/Hisilicon: switch to NonDiscoverable driver for EHCI