From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.6420.1574948361345742177 for ; Thu, 28 Nov 2019 05:39:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=UpTJ0/42; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id y11so28033186wrt.6 for ; Thu, 28 Nov 2019 05:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oGStY15Z63NktzVuhu/icGaSD0p9fLdlFxA8SrvBKKI=; b=UpTJ0/42Clu6T7EuSszb1Hu2/9Pe83RUhGmjnMb8lFpeKXF/O7vxXtTNJwfwrIHfM2 PdBnxfBNJd7tsUZsKdvq1yGYMFEp3QRZ9aV5dekwIpMoEhDxlYbPNibEe7tBBOMECSEN uItCwXNF/Nj6J2DjRwPQ2X8pNcDwhZSp5lP7sDOfyogmRPgtC2H9S+dm0zarIQIFC5bK rfTyPLerj2eHQucJ4T6b2j7QHIlUgbER1lIaSm6+YnuLTyglJUE8kLDKT9Hi/gYTVFN/ FtIQbFZwEt/ysFFF/ufPWROri+T6znjuv/mEkiEBzJ8WTmxVRlUWuRUpeyyjFvWAQOnB VfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oGStY15Z63NktzVuhu/icGaSD0p9fLdlFxA8SrvBKKI=; b=drzlnOMZJNKd/zSgEFj9pkvFW+jvMNvraSF2HpBNs5Wy9YSIx39wF7l2FmrpFGuwRd r5Q5c+veq3RuXIvQtCNE03a2iHUonzp0b97HKjh/ahB2YKA00XuCX/TUQZwfUcNkpu5h 6SdabXciP8jBj3vxWtN2BIygRAp7kCaIkDylZ4il8lDXNEn/PhyWOP2HVKW69UZSZWXZ mR8PVZcCj9z0nRBLFi4RAOzAFYoZcAy577RNd1L55qLcks49od+7c3v+UkKlJPvGR/I5 DGH/f8c3e1HQwO93VFo+qT0w/JBsSaS36qo9MsyWholslmltq7m228pQXYR5mPEVfJJr +HPg== X-Gm-Message-State: APjAAAVCuAJRERlTi9JIw0E8c7XNgyr5eETcmBRska8m0AZlXDRVOp3i wQ8rsq8knQ87SO9GVGjbAGovSnp7Mi5gaTlyIb9aqw== X-Google-Smtp-Source: APXvYqx/hgTu76ajltf92dly/RyiHFBZvBxorKpLOeeWV4kk+JQHAlxjOOu/h1w5xCWMZwtGWSYBhRJogTHntwgSBsk= X-Received: by 2002:adf:e6d0:: with SMTP id y16mr24285328wrm.32.1574948359824; Thu, 28 Nov 2019 05:39:19 -0800 (PST) MIME-Version: 1.0 References: <20191127184439.16793-1-ard.biesheuvel@linaro.org> <20191127184439.16793-8-ard.biesheuvel@linaro.org> <20191128133754.GQ7359@bivouac.eciton.net> In-Reply-To: <20191128133754.GQ7359@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Thu, 28 Nov 2019 14:39:23 +0100 Message-ID: Subject: Re: [PATCH edk2-platforms v2 7/8] Silicon/AMD/StyxDtbLoaderLib: use Cortex-A57 IDs instead of generic ARMv8 To: Leif Lindholm Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Thu, 28 Nov 2019 at 14:37, Leif Lindholm wrote: > > On Wed, Nov 27, 2019 at 19:44:38 +0100, Ard Biesheuvel wrote: > > Use the more precise Cortex-A57 based compatible strings to describe > > the CPUs and the PMUs in the device tree. > > > > Signed-off-by: Ard Biesheuvel > > --- > > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > > index e723e77c7965..091d151ac722 100644 > > --- a/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > > +++ b/Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c > > @@ -405,7 +405,7 @@ PrepareFdt ( > > ArmCoreInfoTable[Index].CoreId); > > MpId = cpu_to_fdt64 (MpId); > > fdt_setprop (Fdt, CpuNode, "reg", &MpId, sizeof (MpId)); > > - fdt_setprop_string (Fdt, CpuNode, "compatible", "arm,armv8"); > > + fdt_setprop_string (Fdt, CpuNode, "compatible", "arm,cortex-a57"); > > fdt_setprop_string (Fdt, CpuNode, "device_type", "cpu"); > > > > fdt_setprop_cell (Fdt, CpuNode, "i-cache-size", 3 * SIZE_16KB); > > @@ -474,7 +474,7 @@ PrepareFdt ( > > // Create /pmu node > > PmuNode = fdt_add_subnode(Fdt, 0, "pmu"); > > if (PmuNode >= 0) { > > - fdt_setprop_string (Fdt, PmuNode, "compatible", "arm,armv8-pmuv3"); > > + fdt_setprop_string (Fdt, PmuNode, "compatible", "arm,cortex-a57-pmu"); > > Since we've always only published "arm,armv8-pmuv3" before, is it > worth keeping that around as a secondary compatible string rather > than replacing it outright? > Yeah, good point. I'll change that.