From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v2 09/12] ArmVirtPkg: enable AcpiTableDxe and EFI_ACPI_TABLE_PROTOCOL dynamically
Date: Wed, 22 Mar 2017 14:16:28 +0000 [thread overview]
Message-ID: <CAKv+Gu9Wkt0WMoqdd6G9fvQKD74wGUJ5h5kfKN30Zwq6iaTmjQ@mail.gmail.com> (raw)
In-Reply-To: <20170317204731.31488-10-lersek@redhat.com>
On 17 March 2017 at 20:47, Laszlo Ersek <lersek@redhat.com> wrote:
> In this patch, AcpiTableDxe, and the dependent (platform-matching) ACPI
> table producing DXE drivers are built for 32-bit as well,
Why is this?
> and the ACPI
> protocol / driver chain is enabled dynamically, when appropriate. This is
> being done in one larger patch, because ArmVirt.dsc.inc, where
> AcpiTableDxe is built, is used by all the platform DSCs.
>
> No change in behavior should be observable after this patch on any
> ArmVirtPkg platform.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++++--
> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
> ArmVirtPkg/ArmVirtXen.dsc | 3 +--
> ArmVirtPkg/ArmVirtXen.fdf | 3 ++-
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++-
> 6 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index f61fd0680612..180b72d1478a 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -439,9 +439,16 @@ [Components.common]
> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000
> }
>
> -[Components.AARCH64]
> #
> # ACPI Support
> #
> - MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf {
> + <LibraryClasses>
> + NULL|ArmPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf
> + }
> +
> +[Components.AARCH64]
> + #
> + # EBC support
> + #
> MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index d6b3c0db5530..328c2b79994b 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -379,10 +379,10 @@ [Components.common]
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
> MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
>
> -[Components.AARCH64]
> #
> # ACPI Support
> #
> + ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
> <LibraryClasses>
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 71f16ed192de..bcd2711d4142 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -368,10 +368,10 @@ [Components.common]
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
> MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
>
> -[Components.AARCH64]
> #
> # ACPI Support
> #
> + ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
> <LibraryClasses>
> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
> index 3422d1e5d996..90c5ebc6cb96 100644
> --- a/ArmVirtPkg/ArmVirtXen.dsc
> +++ b/ArmVirtPkg/ArmVirtXen.dsc
> @@ -221,6 +221,5 @@ [Components.common]
> #
> # ACPI support
> #
> -!if $(ARCH) == AARCH64
> + ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf
> ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf
> -!endif
> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
> index c997251b12b8..8e41ba1fb448 100644
> --- a/ArmVirtPkg/ArmVirtXen.fdf
> +++ b/ArmVirtPkg/ArmVirtXen.fdf
> @@ -183,10 +183,11 @@ [FV.FvMain]
> #
> # ACPI support
> #
> -!if $(ARCH) == AARCH64
> + INF ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf
> INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> INF ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf
>
> +!if $(ARCH) == AARCH64
> #
> # EBC support
> #
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index cc5d12aaefea..440ff7e87a52 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -140,14 +140,15 @@ [FV.FvMain]
> INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf
> INF OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
>
> -!if $(ARCH) == AARCH64
> #
> # ACPI Support
> #
> + INF ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf
> INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
> INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf
>
> +!if $(ARCH) == AARCH64
> #
> # EBC support
> #
> --
> 2.9.3
>
>
next prev parent reply other threads:[~2017-03-22 14:16 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 20:47 [PATCH v2 00/12] ArmVirtPkg: don't forward the DT to the OS if QEMU provides ACPI Laszlo Ersek
2017-03-17 20:47 ` [PATCH v2 01/12] Revert "ArmVirtPkg/FdtClientDxe: make DT table installation !ACPI dependent" Laszlo Ersek
2017-03-22 14:12 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 02/12] Revert "ArmVirtPkg/FdtClientDxe: install DT configuration table at ReadyToBoot" Laszlo Ersek
2017-03-22 14:12 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages Laszlo Ersek
2017-03-20 2:16 ` Zeng, Star
2017-03-20 2:26 ` Tian, Feng
2017-03-20 2:34 ` Wu, Hao A
2017-03-20 9:46 ` Laszlo Ersek
2017-03-20 9:57 ` Zeng, Star
2017-03-20 10:10 ` Laszlo Ersek
2017-03-17 20:47 ` [PATCH v2 04/12] ArmVirtPkg/XenAcpiPlatformDxe: don't cast UINT64 to pointer directly Laszlo Ersek
2017-03-22 14:13 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 05/12] ArmPkg: introduce EDKII Platform Has ACPI Protocol, and plug-in library Laszlo Ersek
2017-03-18 15:00 ` Leif Lindholm
2017-03-20 9:01 ` Laszlo Ersek
2017-03-20 11:59 ` Leif Lindholm
2017-03-22 15:01 ` Laszlo Ersek
2017-03-23 1:41 ` Zeng, Star
2017-03-23 9:09 ` Ard Biesheuvel
2017-03-24 3:44 ` Zeng, Star
2017-03-24 7:15 ` Ard Biesheuvel
2017-03-24 17:10 ` Laszlo Ersek
2017-03-24 17:11 ` Ard Biesheuvel
2017-03-24 17:09 ` Laszlo Ersek
2017-03-27 2:42 ` Gao, Liming
2017-03-27 7:00 ` Ard Biesheuvel
2017-03-27 17:31 ` Laszlo Ersek
2017-03-27 17:45 ` Ard Biesheuvel
2017-03-28 5:25 ` Gao, Liming
2017-03-28 7:49 ` Laszlo Ersek
2017-03-29 9:49 ` Gao, Liming
2017-03-29 13:03 ` Laszlo Ersek
2017-03-20 2:23 ` Zeng, Star
2017-03-20 9:17 ` Laszlo Ersek
2017-03-20 9:57 ` Zeng, Star
2017-03-21 2:27 ` Zeng, Star
2017-03-21 7:10 ` Ard Biesheuvel
2017-03-21 8:43 ` Ard Biesheuvel
2017-03-21 9:02 ` Laszlo Ersek
2017-03-21 18:00 ` Laszlo Ersek
2017-03-22 14:12 ` Ard Biesheuvel
2017-03-21 8:37 ` Laszlo Ersek
2017-03-21 8:41 ` Zeng, Star
2017-03-21 9:05 ` Laszlo Ersek
2017-03-22 16:45 ` Laszlo Ersek
2017-03-17 20:47 ` [PATCH v2 06/12] ArmPkg: introduce EDKII Platform Has Device Tree Protocol Laszlo Ersek
2017-03-18 15:06 ` Leif Lindholm
2017-03-20 9:03 ` Laszlo Ersek
2017-03-17 20:47 ` [PATCH v2 07/12] ArmVirtPkg: add PlatformHasAcpiDtDxe Laszlo Ersek
2017-03-22 14:14 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 08/12] ArmVirtPkg: add XenPlatformHasAcpiDtDxe Laszlo Ersek
2017-03-22 14:15 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 09/12] ArmVirtPkg: enable AcpiTableDxe and EFI_ACPI_TABLE_PROTOCOL dynamically Laszlo Ersek
2017-03-22 14:16 ` Ard Biesheuvel [this message]
2017-03-22 14:54 ` Laszlo Ersek
2017-03-22 15:05 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 10/12] ArmVirtPkg/FdtClientDxe: install DT as sysconfig table in protocol notify Laszlo Ersek
2017-03-22 14:18 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 11/12] ArmVirtPkg/PlatformHasAcpiDtDxe: don't expose DT if QEMU provides ACPI Laszlo Ersek
2017-03-17 21:10 ` Ard Biesheuvel
2017-03-17 21:25 ` Laszlo Ersek
2017-03-17 21:27 ` Ard Biesheuvel
2017-03-22 14:18 ` Ard Biesheuvel
2017-03-17 20:47 ` [PATCH v2 12/12] ArmVirtPkg: remove PURE_ACPI_BOOT_ENABLE and PcdPureAcpiBoot Laszlo Ersek
2017-03-22 14:19 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9Wkt0WMoqdd6G9fvQKD74wGUJ5h5kfKN30Zwq6iaTmjQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox