From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 52B2680385 for ; Wed, 22 Mar 2017 07:16:29 -0700 (PDT) Received: by mail-io0-x22f.google.com with SMTP id l7so66015579ioe.3 for ; Wed, 22 Mar 2017 07:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mQyvVZ2nUeTnmVG9EvlwvVnAI456u4sVYF8YTDwISTM=; b=eNhIKGmtLRAzVgoHwR3Q6j9OHWrxsPmZaO5psoCVY9tj5l6h3BHmMm7EREBe4O1/Qq w4E8S/vuQNTFJ0WerGu3qxNT8Uu4doCaAiT2/Wvo0iNHsRinry/7JqE+DBQBGFPyzTEs NFlN0nl7bP0UYvcwRb3dsBr8jLMAgT1sMAk2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mQyvVZ2nUeTnmVG9EvlwvVnAI456u4sVYF8YTDwISTM=; b=qPVq36Pn5FA8wkQxHWU5E7h9eAjwGo7CwrR6hkzuJlatvhOtqU+WTYZmmmhiZs4Bs3 IfV/rPMHPHEk5tR+vVH6ujesWcxgRTZ+LcmppYD26gKjeuwSpPE/pENN7AWhvM6a986R uAGixGcShZVMkRGE9grnWVcbaBCGrTG61AOI5fGusnRn0mUpKQTTmyudNnW85m9/Avjc Rh7K/qW/9oT/aFLIxADbco3lPPtN6gwCXP1a7horI4NuugGiFxM8ekSaI+/uzssVMkzG sP3aVwzScTYe+L4nin9SPDflg+Eo5X3eujrS7OirlbfuDnf/C1mHaT4JD+7pOxu5cVBW 6ziw== X-Gm-Message-State: AFeK/H2w2AdDdRET0gluWhrm3VuLCTudiFvaE7SBG9fRucCaYIYisXd4V7VAEatTiZUdL2XYRv45maSOKfQkTtWl X-Received: by 10.107.132.155 with SMTP id o27mr35620205ioi.138.1490192188655; Wed, 22 Mar 2017 07:16:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 22 Mar 2017 07:16:28 -0700 (PDT) In-Reply-To: <20170317204731.31488-10-lersek@redhat.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-10-lersek@redhat.com> From: Ard Biesheuvel Date: Wed, 22 Mar 2017 14:16:28 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v2 09/12] ArmVirtPkg: enable AcpiTableDxe and EFI_ACPI_TABLE_PROTOCOL dynamically X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 14:16:29 -0000 Content-Type: text/plain; charset=UTF-8 On 17 March 2017 at 20:47, Laszlo Ersek wrote: > In this patch, AcpiTableDxe, and the dependent (platform-matching) ACPI > table producing DXE drivers are built for 32-bit as well, Why is this? > and the ACPI > protocol / driver chain is enabled dynamically, when appropriate. This is > being done in one larger patch, because ArmVirt.dsc.inc, where > AcpiTableDxe is built, is used by all the platform DSCs. > > No change in behavior should be observable after this patch on any > ArmVirtPkg platform. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++++-- > ArmVirtPkg/ArmVirtQemu.dsc | 2 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- > ArmVirtPkg/ArmVirtXen.dsc | 3 +-- > ArmVirtPkg/ArmVirtXen.fdf | 3 ++- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- > 6 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index f61fd0680612..180b72d1478a 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -439,9 +439,16 @@ [Components.common] > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 > } > > -[Components.AARCH64] > # > # ACPI Support > # > - MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > + MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf { > + > + NULL|ArmPkg/Library/PlatformHasAcpiLib/PlatformHasAcpiLib.inf > + } > + > +[Components.AARCH64] > + # > + # EBC support > + # > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index d6b3c0db5530..328c2b79994b 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -379,10 +379,10 @@ [Components.common] > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > -[Components.AARCH64] > # > # ACPI Support > # > + ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index 71f16ed192de..bcd2711d4142 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -368,10 +368,10 @@ [Components.common] > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > > -[Components.AARCH64] > # > # ACPI Support > # > + ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { > > diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc > index 3422d1e5d996..90c5ebc6cb96 100644 > --- a/ArmVirtPkg/ArmVirtXen.dsc > +++ b/ArmVirtPkg/ArmVirtXen.dsc > @@ -221,6 +221,5 @@ [Components.common] > # > # ACPI support > # > -!if $(ARCH) == AARCH64 > + ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf > -!endif > diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > index c997251b12b8..8e41ba1fb448 100644 > --- a/ArmVirtPkg/ArmVirtXen.fdf > +++ b/ArmVirtPkg/ArmVirtXen.fdf > @@ -183,10 +183,11 @@ [FV.FvMain] > # > # ACPI support > # > -!if $(ARCH) == AARCH64 > + INF ArmVirtPkg/XenPlatformHasAcpiDtDxe/XenPlatformHasAcpiDtDxe.inf > INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > INF ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf > > +!if $(ARCH) == AARCH64 > # > # EBC support > # > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index cc5d12aaefea..440ff7e87a52 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -140,14 +140,15 @@ [FV.FvMain] > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > INF OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > > -!if $(ARCH) == AARCH64 > # > # ACPI Support > # > + INF ArmVirtPkg/PlatformHasAcpiDtDxe/PlatformHasAcpiDtDxe.inf > INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf > INF MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf > INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf > > +!if $(ARCH) == AARCH64 > # > # EBC support > # > -- > 2.9.3 > >