Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Fri, 15 Mar 2019 at 13:44, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> On Fri, Mar 15, 2019 at 6:04 PM Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
> >
> > On Fri, 15 Mar 2019 at 13:25, Thomas Abraham <thomas.abraham@arm.com> wrote:
> > >
> > > On Fri, Mar 15, 2019 at 5:27 PM Ard Biesheuvel
> > > <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > >
> > > > > On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > >
> > > > > > > hi Ard,
> > > > > > >
> > > > > > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > > > >
> > > > > > > > > hi Ard/Leif
> > > > > > > > >
> > > > > > > > > Please let me know if you have any comments on this patch set
> > > > > > > > >
> > > > > > > >
> > > > > > > > HI Jagadeesh,
> > > > > > > >
> > > > > > > > What does RdE1Edge or RdN1Edge mean?
> > > > > > >
> > > > > > > RdE1Edge/RdN1Edge are new product name
> > > > > > > Rd stands for reference design.
> > > > > > >
> > > > > > > The Neoverse E1 Edge Reference Design
> > > > > > > The Neoverse N1 Edge Reference Design
> > > > > > >
> > > > > >
> > > > > > So 'reference design' is the name of the platform based on the
> > > > > > Neoverse E1 and N1, respectively?
> > > > >
> > > > > yes ,
> > > > > 'reference design' is a class of platform, in which we have Neoverse
> > > > > E1/N1 cores support. Going forward other cores can come in
> > > > >
> > > >
> > > > Could we drop the 'edge'? It seems redundant.
> > >
> > > Hi Ard,
> > >
> > > 'edge' here would be required because there is also a 'hyperscale'
> > > class of platform based on N1 cores.
> > > (https://www.anandtech.com/show/13959/arm-announces-neoverse-n1-platform/3).
> > >
> > > >
> > > > I'd prefer it if we could stick with
> > > >
> > > > NeoverseE1
> > > > NeoverseN1
> > > >
> > > > or if the reference design part is relevant
> > > >
> > > > NeoverseE1ReferenceDesign
> > > > NeoverseN1ReferenceDesign
> > >
> > > The ReferenceDesign part is relevant and without which the name would
> > > only indicate the CPU name (NeoverseN1). And so is 'edge' because
> > > there is 'hyperscale' variant as of today and there could be other
> > > variants as well.
> > >
> >
> > Hi Thomas,
> >
> > Thanks for the clarification.
> >
> > So could we go with
> >
> > > > NeoverseE1EdgeReferenceDesign
> > > > NeoverseN1EdgeReferenceDesign
> >
> > instead?
>
> The official product names being used for these two platforms are
> 'RD-N1-Edge' and 'RD-E1-Edge'. So to keep to platform name in line
> with the product name and also to keep it short, 'RdN1Edge' and
> 'RdE1Edge' names are being used in this patch series. Are there any
> limitations in using this shorter name for the platforms.
>

No, I just found them a bit cryptic. But if they are an exact match
with the product names, I don't have any objections.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 68cc99303e38..a8f34e065815