From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7FC8221A07A92 for ; Thu, 3 Jan 2019 11:13:43 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id g85so46698933ita.3 for ; Thu, 03 Jan 2019 11:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qecCcbFP9ejcDkb6R/M40boacEqJV/XMD1/5GnD7IZc=; b=DDchxFZJHvP5zuQWhc96TdI2BaYz8Pv/trJHMWMAkhi+oNxWyitEmnnqhrd1Msoy0j rKB/ReUQwsco4ozidmgEsKM5RjHiEq1h4JH8krbaKgcyCvk2nTyTAFOWwvYWjdZeHRYN 0BClAAZjgJUY4LesbxUzOmfQ2V6xCzUKX3MI0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qecCcbFP9ejcDkb6R/M40boacEqJV/XMD1/5GnD7IZc=; b=lS7pATPLR9jq8LSXQgq0qcJbdg0u8rmS4/5mBPUeSnUrsAp2inb8SiSy1EkydEPgC5 hy0fMr1PYZslrN1ssdJFHhUTufdAnA/HzaxNc3pfUKrYGxaOKdaLNGnjx7LVyIU8iQyF E7q6tSDiaO5RXvLYozKhu2wOGms9yPiiEmUm28VkgxZv++YfZ8byRK2Bz9n5Bh8b7hvR xLNe/+uEb78qLF7+mjnir3WRArouYTdvGXMSpPJKjH8RQ7hfIJ2M0TPY02Ru92ikLIxa XwLfjCaSAbI5yaURqd5R05Yy7yB/Tv4/IheEX9z2dMH3L3+Ow2f+gPdlIFa6/B5HhP1M syNw== X-Gm-Message-State: AA+aEWbsMDF4+EB6jfrofnxmfcnxJ7Fg/PYC7H5EG+lAU5PpBpuiwuJv DtoGBkFWJUW6ecT6doceY7sZTG7altiDavGODtvEf0b2De8jDA== X-Google-Smtp-Source: AFSGD/XLO8DlP/izIuGgDmYW9ujunPPrb25Vn5a0KONxNLNLroB0EDNpZJI2/B8bvqzjzr2rdjnkZEl1eMggYrk1Wvc= X-Received: by 2002:a24:edc4:: with SMTP id r187mr34738996ith.158.1546542821814; Thu, 03 Jan 2019 11:13:41 -0800 (PST) MIME-Version: 1.0 References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> In-Reply-To: <20190103182825.32231-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Thu, 3 Jan 2019 20:13:30 +0100 Message-ID: To: "edk2-devel@lists.01.org" Cc: Laszlo Ersek , Leif Lindholm , Michael D Kinney , Liming Gao , Jian J Wang , Hao Wu , Jagadeesh Ujja , Achin Gupta , Thomas Panakamattam Abraham , Sami Mujawar Subject: Re: [PATCH 0/6] implement standalone MM versions of the variable runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jan 2019 19:13:43 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 3 Jan 2019 at 19:28, Ard Biesheuvel wrote: > > This series proposed an alternative approach to the series sent out by > Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the > special PCD, as well as some other if() conditionals. > That would be [0] https://lists.01.org/pipermail/edk2-devel/2019-January/034542.html Also, I seem to have included a BaseTools/ patch in error. Apologies for the sloppiness. > The primary difference is that this series defines and implements > MmServicesTableLib in such a way that the traditional SMM drivers > can use it as well. This is appropriate, considering that the PI > spec has rebranded traditional SMM as one implementation of the generic > MM framework. > > Patch #1 is based on Jagadeesh's patch, and introduces the MmServicesTableLib > library class, but for all SMM flavours, not only for standalone MM. > > Patch #2 implements MmServicesTableLib for traditional SMM implementations. > > Patch #3 refactors FaultTolerantWriteDxe so that the parts of the SMM > driver that invoke boot services are separated from the core SMM pieces. > > Patch #4 implements FaultTolerantWriteSmm for the standalone MM environment. > > Patches #5 and #6 do the same, respectively, for the variable runtime driver. > > This approach minimizes the delta, and thus the maintenance burden, between > the traditional SMM and standalone MM drivers, while not resorting to runtime > checks or other conditionals in the code to implement logic that should be > decided at build time. > > Note that this series only covers part of the work contributed by Jagadeesh. > This series focuses on the MdePkg and MdeModulePkg changes that affect shared > code. > > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao Wu > Cc: Jagadeesh Ujja > Cc: Achin Gupta > Cc: Thomas Panakamattam Abraham > Cc: Sami Mujawar > > Ard Biesheuvel (5): > MdePkg: implement MmServicesTableLib based on traditional SMM > MdeModulePkg/FaultTolerantWriteDxe: factor out boot service accesses > MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version > MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses > MdeModulePkg/VariableRuntimeDxe: implement standalone MM version > > Jagadeesh Ujja (1): > MdePkg/Include: add MmServicesTableLib header file > > MdeModulePkg/MdeModulePkg.dsc | 1 + > .../FaultTolerantWrite.h | 22 ++- > .../FaultTolerantWriteDxe.c | 31 ++++ > .../FaultTolerantWriteSmm.c | 54 +++---- > .../FaultTolerantWriteSmm.inf | 5 +- > .../FaultTolerantWriteSmmCommon.h | 31 ++++ > .../FaultTolerantWriteSmmDxe.c | 1 + > .../FaultTolerantWriteStandaloneMm.c | 70 +++++++++ > .../FaultTolerantWriteStandaloneMm.inf | 90 ++++++++++++ > .../FaultTolerantWriteTraditionalMm.c | 94 ++++++++++++ > .../UpdateWorkingBlock.c | 10 +- > .../Variable/RuntimeDxe/TcgMorLockSmm.c | 18 +-- > .../Universal/Variable/RuntimeDxe/Variable.h | 50 +++++++ > .../Variable/RuntimeDxe/VariableSmm.c | 59 +++----- > .../Variable/RuntimeDxe/VariableSmm.inf | 5 +- > .../RuntimeDxe/VariableStandaloneMm.c | 69 +++++++++ > .../RuntimeDxe/VariableStandaloneMm.inf | 135 ++++++++++++++++++ > .../RuntimeDxe/VariableTraditionalMm.c | 114 +++++++++++++++ > MdePkg/Include/Library/MmServicesTableLib.h | 25 ++++ > .../MmServicesTableLib/MmServicesTableLib.c | 63 ++++++++ > .../MmServicesTableLib/MmServicesTableLib.inf | 45 ++++++ > .../MmServicesTableLib/MmServicesTableLib.uni | 22 +++ > MdePkg/MdePkg.dec | 4 + > MdePkg/MdePkg.dsc | 1 + > 24 files changed, 916 insertions(+), 103 deletions(-) > create mode 100644 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c > create mode 100644 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf > create mode 100644 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c > create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > create mode 100644 MdePkg/Include/Library/MmServicesTableLib.h > create mode 100644 MdePkg/Library/MmServicesTableLib/MmServicesTableLib.c > create mode 100644 MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > create mode 100644 MdePkg/Library/MmServicesTableLib/MmServicesTableLib.uni > > -- > 2.17.1 >