From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d43; helo=mail-io1-xd43.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C34CA21194897 for ; Wed, 5 Dec 2018 23:33:31 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id n9so10861972ioo.2 for ; Wed, 05 Dec 2018 23:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=APNhLRY0Xd1/g7zmby5VxcNQv23gW3KchRISecSMdo4=; b=c13SSXldN22YBY0ZyhqCYB/yrkh6+9JobHPEi7TDOmZH2ti2CbMA9NDYOwCXp8RjbU TMsNCkhtnMb1QqlIXfc0jIzuJ4ZqO/zyr1NVK/biEWHBoX4cDmVj2n5oSvMq/BkcgHDv KdPArelfzB9bDEQ9tGLrGcCS5F4FsH7vBUU/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=APNhLRY0Xd1/g7zmby5VxcNQv23gW3KchRISecSMdo4=; b=efWwJEcypr7Qs7Ujyt50j75N8df77Krmv6/IjsrWTgaIX606MDZITGK3a8YRoF0tdx 5VB9RIRZKbkB1TSLKz2bSRo1MflShvSE4WZ1ozoezswe9dWV/5QchvKkA0cWGT376cO1 rWyrgeCW81R6Fsds/oXBdtjz6kVDXU6wukkPXtWhpvCPSK/ALf+0w1tq3dAhalUpEVdL g3ddeCyjQbGlKw/n0ib/hpAKaVUHIiUT/dYX95Zs3hwBqJwxMvL5L/i9PcaHqGE/QJpu GbiF5xhM/CZQn5baAVD4L0tHMDc5ntYfZPman0CmaULeVeqXY2aqX3NqYxidKxnOIl8O S7ug== X-Gm-Message-State: AA+aEWbVexdtH/tVRPCIQ8jRI6KdLAg9z8NyRlTVT0W2sP44jHQ4zqBl KzgEz08JdSMDEbVvEMb6MUKZW863ewsd7kPQ5nCsxA== X-Google-Smtp-Source: AFSGD/WggMY2ox5gD0AJBAJIMkMDc9DKli3GlRNZIQL41dnZSCvPpnpjTS0Hodjw260axfjVk+TF4uFrWvtvfBgJuWI= X-Received: by 2002:a5d:8415:: with SMTP id i21mr13492987ion.173.1544081609635; Wed, 05 Dec 2018 23:33:29 -0800 (PST) MIME-Version: 1.0 References: <20181205082401.20224-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3845C9@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3845C9@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Thu, 6 Dec 2018 08:33:18 +0100 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH] BaseTools/CommonLib: drop the use of MAX_ADDRESS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2018 07:33:32 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 6 Dec 2018 at 00:56, Gao, Liming wrote: > > Reviewed-by: Liming Gao > Thanks all Pushed as 6e8cad49a09d..67938bcc9d9e > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > > Sent: Wednesday, December 5, 2018 4:24 PM > > To: edk2-devel@lists.01.org > > Cc: lersek@redhat.com; Gao, Liming > > Subject: [edk2] [PATCH] BaseTools/CommonLib: drop the use of MAX_ADDRESS > > > > The macro MAX_ADDRESS represents the largest virtual address that > > is valid for a certain architecture. For the BaseTools, this quantity > > is irrelevant, since the same tools can be used to build for different > > targets. > > > > Since we only refer to it in a single place, which is an ASSERT() that > > doesn't seem particularly useful (it ensures that memcpy() will not > > be called with arguments that will make it read beyond the end of the > > address space and wrap around), let's drop the ASSERT and all references > > to MAX_ADDRESS. > > > > Cc: Bob Feng > > Cc: Liming Gao > > Cc: Yonghong Zhu > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > BaseTools/Source/C/Include/AArch64/ProcessorBind.h | 5 ----- > > BaseTools/Source/C/Include/Arm/ProcessorBind.h | 5 ----- > > BaseTools/Source/C/Include/Common/UefiBaseTypes.h | 1 - > > BaseTools/Source/C/Include/Ia32/ProcessorBind.h | 5 ----- > > BaseTools/Source/C/Include/X64/ProcessorBind.h | 5 ----- > > BaseTools/Source/C/Common/CommonLib.c | 1 - > > 6 files changed, 22 deletions(-) > > > > diff --git a/BaseTools/Source/C/Include/AArch64/ProcessorBind.h b/BaseTools/Source/C/Include/AArch64/ProcessorBind.h > > index e7e9d83198a6..f956cab453f0 100644 > > --- a/BaseTools/Source/C/Include/AArch64/ProcessorBind.h > > +++ b/BaseTools/Source/C/Include/AArch64/ProcessorBind.h > > @@ -90,11 +90,6 @@ typedef INT64 INTN; > > /// > > #define MAX_2_BITS 0xC000000000000000 > > > > -/// > > -/// Maximum legal AARCH64 address > > -/// > > -#define MAX_ADDRESS 0xFFFFFFFFFFFFFFFF > > - > > /// > > /// The stack alignment required for AARCH64 > > /// > > diff --git a/BaseTools/Source/C/Include/Arm/ProcessorBind.h b/BaseTools/Source/C/Include/Arm/ProcessorBind.h > > index be4aac97664d..856d2bd9eff7 100644 > > --- a/BaseTools/Source/C/Include/Arm/ProcessorBind.h > > +++ b/BaseTools/Source/C/Include/Arm/ProcessorBind.h > > @@ -88,11 +88,6 @@ typedef INT32 INTN; > > /// > > #define MAX_2_BITS 0xC0000000 > > > > -/// > > -/// Maximum legal ARM address > > -/// > > -#define MAX_ADDRESS 0xFFFFFFFF > > - > > /// > > /// The stack alignment required for ARM > > /// > > diff --git a/BaseTools/Source/C/Include/Common/UefiBaseTypes.h b/BaseTools/Source/C/Include/Common/UefiBaseTypes.h > > index aa1aef3ce638..696ac15e4cd5 100644 > > --- a/BaseTools/Source/C/Include/Common/UefiBaseTypes.h > > +++ b/BaseTools/Source/C/Include/Common/UefiBaseTypes.h > > @@ -170,6 +170,5 @@ typedef union { > > > > > > #define EFI_MAX_BIT MAX_BIT > > -#define EFI_MAX_ADDRESS MAX_ADDRESS > > > > #endif > > diff --git a/BaseTools/Source/C/Include/Ia32/ProcessorBind.h b/BaseTools/Source/C/Include/Ia32/ProcessorBind.h > > index 4719b53d37fa..96ac691df042 100644 > > --- a/BaseTools/Source/C/Include/Ia32/ProcessorBind.h > > +++ b/BaseTools/Source/C/Include/Ia32/ProcessorBind.h > > @@ -131,11 +131,6 @@ typedef INT32 INTN; > > #define MAX_BIT 0x80000000 > > #define MAX_2_BITS 0xC0000000 > > > > -// > > -// Maximum legal IA-32 address > > -// > > -#define MAX_ADDRESS 0xFFFFFFFF > > - > > // > > // Modifier to ensure that all protocol member functions and EFI intrinsics > > // use the correct C calling convention. All protocol member functions and > > diff --git a/BaseTools/Source/C/Include/X64/ProcessorBind.h b/BaseTools/Source/C/Include/X64/ProcessorBind.h > > index c625f8cef4a1..987738508333 100644 > > --- a/BaseTools/Source/C/Include/X64/ProcessorBind.h > > +++ b/BaseTools/Source/C/Include/X64/ProcessorBind.h > > @@ -150,11 +150,6 @@ typedef INT64 INTN; > > #define MAX_BIT 0x8000000000000000ULL > > #define MAX_2_BITS 0xC000000000000000ULL > > > > -// > > -// Maximum legal Itanium-based address > > -// > > -#define MAX_ADDRESS 0xFFFFFFFFFFFFFFFFULL > > - > > // > > // Modifier to ensure that all protocol member functions and EFI intrinsics > > // use the correct C calling convention. All protocol member functions and > > diff --git a/BaseTools/Source/C/Common/CommonLib.c b/BaseTools/Source/C/Common/CommonLib.c > > index 42dfa821624d..5c40fdb5fd49 100644 > > --- a/BaseTools/Source/C/Common/CommonLib.c > > +++ b/BaseTools/Source/C/Common/CommonLib.c > > @@ -1236,7 +1236,6 @@ InternalAllocateCopyPool ( > > VOID *Memory; > > > > ASSERT (Buffer != NULL); > > - ASSERT (AllocationSize <= (MAX_ADDRESS - (UINTN) Buffer + 1)); > > > > Memory = malloc (AllocationSize); > > if (Memory != NULL) { > > -- > > 2.19.2 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel