From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements
Date: Mon, 2 Dec 2019 16:03:39 +0000 [thread overview]
Message-ID: <CAKv+Gu9ZJiO3_fkrVvSiiSirmpPQL6gCK3Vd5ZPo4R10YzwvAg@mail.gmail.com> (raw)
In-Reply-To: <20191202115506.4068-1-pete@akeo.ie>
On Mon, 2 Dec 2019 at 11:55, Pete Batard <pete@akeo.ie> wrote:
>
> This patch series is targetted at adding support for the Bcm2838
> Random Generator Driver, so that it can be used on the Raspberry
> Pi 4.
>
> Pete Batard (3):
> Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver
> Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header
> Silicon/Broadcom/Bcm283x: Add Bcm2838 RNG driver
>
Thanks for respinning this. For the series,
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
I have pushed all three patches, but going forward, can we keep
patches for new hardware together with patches that add the platform?
There is currently no way to build test the new driver introduced in
#3.
Pushed as 8e75ee0c9653..d6b7f67e62da
> Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +-
> Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +-
> Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c} | 18 +-
> Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} | 6 +-
> Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c | 285 ++++++++++++++++++++
> Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.inf | 46 ++++
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h | 22 ++
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 9 -
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2838Rng.h | 30 +++
> 9 files changed, 397 insertions(+), 23 deletions(-)
> rename Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c} (93%)
> rename Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} (82%)
> create mode 100644 Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c
> create mode 100644 Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.inf
> create mode 100644 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h
> create mode 100644 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2838Rng.h
>
> --
> 2.21.0.windows.1
>
next prev parent reply other threads:[~2019-12-02 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 11:55 [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements Pete Batard
2019-12-02 11:55 ` [edk2-platforms][PATCH 1/3] Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver Pete Batard
2019-12-02 12:16 ` Philippe Mathieu-Daudé
2019-12-02 11:55 ` [edk2-platforms][PATCH 2/3] Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header Pete Batard
2019-12-02 12:17 ` Philippe Mathieu-Daudé
2019-12-02 11:55 ` [edk2-platforms][PATCH 3/3] Silicon/Broadcom/Bcm283x: Add Bcm2838 RNG driver Pete Batard
2019-12-02 16:03 ` Ard Biesheuvel [this message]
2019-12-02 16:53 ` [edk2-devel] [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements Pete Batard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9ZJiO3_fkrVvSiiSirmpPQL6gCK3Vd5ZPo4R10YzwvAg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox