From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web09.3213.1575302626792011519 for ; Mon, 02 Dec 2019 08:03:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=HygJLqIw; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id s14so347253wmh.4 for ; Mon, 02 Dec 2019 08:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xA/2Dbu5mLa8w/yHhrYa0Md0bDsYmM46J2o2KUHwX8Q=; b=HygJLqIw89cbT7Jfqn9JGEycyn271oxVrRcb7dnTF6XwqI3wyJzo9BC6dKSsHtUj3j Obz+7wtjdehQjZSc6Os7hN0OiIOFuhRuSaNAN/9LwS5bvxauY9kApGMgQA7FbkB9JPSp Xl+yHBw2d3lu8mRaZi++USwBqqlRpX5sXKnYF82kuTb0wN6+Dtf7iu2b1NxTdfd6rsSq t0T0eU8gPI58W5+1d4cfTF6BTW17+LXOWFZx27hWsHV87i9GxMgqOuX6CHbeLetWB0UI oS+eXjDtRQWOCsLSYX1E8FVeJ8ZqSnwMmGSFiNfDB7tfFHBA7zf5HFD8ze/uG+2Ibe/Y Mb7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xA/2Dbu5mLa8w/yHhrYa0Md0bDsYmM46J2o2KUHwX8Q=; b=KzfOYB3A2bNtWhptCJ9YeES7QogQkglz9ZV9iVADsSwgE6c5JlnLt4qsoVzaZiWBst 33ClafJOU0/IY7LcsqwVYij/F66Q24xVcVjN1UpVBXZY8vPvUpWCcFsdCrv6A7GOkXsU n2TOHes97MeBHExHH2x7uD3AADY6movRC0SxtM9RI5AauFbbMyIASxVpGWw8hwqmYGac yY/4O2B2FVMQJfjm9DDd5CsDd12tKHSzNBzhxIwLLZcjm1XsGewe/yVO6e12/pwjPHcp f1VlAXaRmccn1KSu5L2QmIRmsiphpwDQ5auVq4jep/aIYO/7lU/g5x79ky2/NNXmAFn7 yuCw== X-Gm-Message-State: APjAAAWR9hzaj548MWFRKjN1+BlefQlLPPd7RlyV8TkrAZcl7GfgndgW AuCX5XYDi1VNSR+mivS8lmkOT/VKLziB/mE/ViYEaQ== X-Google-Smtp-Source: APXvYqzCDACjYyekEFBAN2fYGwydkENv6mDhcrmvPHHtlhDhz1FsXEEtvriPoKsDXmohYENXLopP8R6OQNFAqFC3yzI= X-Received: by 2002:a05:600c:141:: with SMTP id w1mr9882266wmm.61.1575302625254; Mon, 02 Dec 2019 08:03:45 -0800 (PST) MIME-Version: 1.0 References: <20191202115506.4068-1-pete@akeo.ie> In-Reply-To: <20191202115506.4068-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Mon, 2 Dec 2019 16:03:39 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH 0/3] Silicon/Broadcom/Bcm283x: RNG improvements To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Mon, 2 Dec 2019 at 11:55, Pete Batard wrote: > > This patch series is targetted at adding support for the Bcm2838 > Random Generator Driver, so that it can be used on the Raspberry > Pi 4. > > Pete Batard (3): > Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver > Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header > Silicon/Broadcom/Bcm283x: Add Bcm2838 RNG driver > Thanks for respinning this. For the series, Reviewed-by: Ard Biesheuvel I have pushed all three patches, but going forward, can we keep patches for new hardware together with patches that add the platform? There is currently no way to build test the new driver introduced in #3. Pushed as 8e75ee0c9653..d6b7f67e62da > Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- > Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- > Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c} | 18 +- > Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} | 6 +- > Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c | 285 ++++++++++++++++++++ > Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.inf | 46 ++++ > Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h | 22 ++ > Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 9 - > Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2838Rng.h | 30 +++ > 9 files changed, 397 insertions(+), 23 deletions(-) > rename Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.c => Bcm2835RngDxe/Bcm2835RngDxe.c} (93%) > rename Silicon/Broadcom/Bcm283x/Drivers/{RngDxe/RngDxe.inf => Bcm2835RngDxe/Bcm2835RngDxe.inf} (82%) > create mode 100644 Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c > create mode 100644 Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.inf > create mode 100644 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2835Rng.h > create mode 100644 Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2838Rng.h > > -- > 2.21.0.windows.1 >