From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=c7hs3zKN;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by groups.io with SMTP; Thu, 19 Sep 2019 02:29:33 -0700
Received: by mail-wm1-f66.google.com with SMTP id y21so3126635wmi.0
        for <devel@edk2.groups.io>; Thu, 19 Sep 2019 02:29:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=/AGbGheU32z2Boa1OZGDyPsthtgyY/881/LMKUhm+Rc=;
        b=c7hs3zKNm5Kt5vJMZ8tCdm6XO7ReK5+LL0Ss9TZDQR/u7tQ+u+lQj3yr9okUV3l9oy
         KZx5y1hQOIj3weJs/LXwszeUlXj1NCDgPzv9hxyuhy8oiOXQDEdtGH/3ba5VCCT0Oyxa
         jCPuXWsa8ySirKJzJwoeGL/Gy85tnWdghO+FwA01n1AMY5spKmAgbep4XuOyDvwQ35V7
         F1d8nGqk8nTXgdVquD2zcpAbNkjX+uQx02NAfgN7muJYEZ3vRyY/MQfcCnfS1C3im5ms
         1WY48L63VCShvMmfSQpDjOb0POhDXnxVAt6RYwxafOmFJQw4QqJhXR3Z5vZly8rtUvQM
         D+Eg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=/AGbGheU32z2Boa1OZGDyPsthtgyY/881/LMKUhm+Rc=;
        b=nQP9zlFj/CFDAsCVonMgshXdJivPCV0CkmNvCyceVtF1y1ODpBcO1iX27nd6jWhvAO
         MBd0MPELYpqd6tUw4GfmqYsRb/MJJ0f4OOrKy5g4/QwnWgJo4B678OjEmSX+mvEEfbzx
         FL/+N1Mr4XLDoSTadEVvz3E91H/s1nefhg3Uqa/sCh9YlMwATFSyNY7THvpUyeAB1o16
         JrUywvGEo6u6WP4MQLy+HOHduSTah/DliaGdlrWt9DjVsnROjoTnuB8mCoxX5/b8LSv/
         80ART3HIbXm4aft5b5QwUJMevNaXGFcmmZOv3qWNlT+veZb22+HLPkdqc7/yj2vMYkX1
         l2ag==
X-Gm-Message-State: APjAAAW6Bd6ua9fPlMLD3KACHATNg6ewL5Io05ixSY7L6ZOeErlZJD/H
	75RPzJHdQOsMtuNxVwqVbbNcpNQ/dFZLr9HjIq1E6w==
X-Google-Smtp-Source: APXvYqyve9Z/9OSiwO8s/k+Eohp6bEWUp6S/U4zK3GVND59jcM1ul2l6jxLBPCjGe+I9yvHYR0nerlunX5cOfRGf0zA=
X-Received: by 2002:a1c:e906:: with SMTP id q6mr1806424wmc.136.1568885370639;
 Thu, 19 Sep 2019 02:29:30 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1568808805.git.baptiste.gerondeau@linaro.org> <a15e00745b330af73235bfe6ec47f19127c6d57d.1568808805.git.baptiste.gerondeau@linaro.org>
In-Reply-To: <a15e00745b330af73235bfe6ec47f19127c6d57d.1568808805.git.baptiste.gerondeau@linaro.org>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 19 Sep 2019 12:29:03 +0300
Message-ID: <CAKv+Gu9bXKWX11VgNC+NCwebH2e-ro5_RzrbBY-o6ZwLLgNubA@mail.gmail.com>
Subject: Re: [PATCH 1/3] ArmPkg/MdePkg : Unify INF files format
To: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif.lindholm@linaro.org>, 
	"Kinney, Michael D" <michael.d.kinney@intel.com>, "Gao, Liming" <liming.gao@intel.com>, 
	"Zhang, Shenglei" <shenglei.zhang@intel.com>, Baptiste GERONDEAU <bgerondeau@gmail.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 18 Sep 2019 at 15:27, Baptiste Gerondeau
<baptiste.gerondeau@linaro.org> wrote:
>
> From: Baptiste GERONDEAU <bgerondeau@gmail.com>
>
> Add a space between the '|' and the name of the toolchain to use,
> as is the case in all other INF files.

Why?

> Note that I did not touch the RVCT lines, since a following commit in
> the set will address those.
>
> Signed-off-by: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>
> ---
>  ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf                 |  2 +-
>  MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> index f4fecbb4098a..33dddf1e2b97 100644
> --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> @@ -22,7 +22,7 @@ [Sources.AARCH64]
>
>  [Sources.ARM]
>    Arm/ArmMmuLibCore.c
> -  Arm/ArmMmuLibV7Support.S   |GCC
> +  Arm/ArmMmuLibV7Support.S   | GCC
>    Arm/ArmMmuLibV7Support.asm |RVCT
>
>  [Packages]
> diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> index e4e3d532e7b8..d38e1397eee1 100644
> --- a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> +++ b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> @@ -79,11 +79,11 @@ [Defines.ARM, Defines.AARCH64]
>    LIBRARY_CLASS = BaseMemoryLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER UEFI_DRIVER UEFI_APPLICATION
>
>  [Sources.ARM]
> -  Arm/ScanMem.S       |GCC
> -  Arm/SetMem.S        |GCC
> -  Arm/CopyMem.S       |GCC
> -  Arm/CompareMem.S    |GCC
> -  Arm/CompareGuid.S   |GCC
> +  Arm/ScanMem.S       | GCC
> +  Arm/SetMem.S        | GCC
> +  Arm/CopyMem.S       | GCC
> +  Arm/CompareMem.S    | GCC
> +  Arm/CompareGuid.S   | GCC
>
>    Arm/ScanMem.asm     |RVCT
>    Arm/SetMem.asm      |RVCT
> --
> 2.23.0
>