From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 29FBF211E0929 for ; Mon, 25 Mar 2019 01:29:05 -0700 (PDT) Received: by mail-it1-x142.google.com with SMTP id h9so12599387itl.1 for ; Mon, 25 Mar 2019 01:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bRmaIoWdlNuR+/E5fRP2HRAVsi6UxJoYniUqxvFGQww=; b=zEXwXJK3WrW48Kziyvj4BCerqt6O7ERSxHVh50Ee4WXWhT6GWnONcV77ojohRxxY1O kVPGynjPI0ATBK3yOJIHwRuEQ1PuAjHk1VcDfqINuB6FNBC6v4WI554JYadlWiILGpIv pfnlxfSP/IGAawohx451iBLs9F+1PsY7dburlu40a3lVp/FVF/KlQDZvRErVZybyKQHB uqatt62pcnKbigGFk2Soy+XO7CJisXc1bLS0rOuY33Pv40HOUp3eAKl1EfqKe3qVxCoD WAP6ldkM9ajgyxB2NDmmQPRWcGZMn6KZf4J0QVPk/kiQXwpAnDmeQ663JocJptumt4K4 mZ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bRmaIoWdlNuR+/E5fRP2HRAVsi6UxJoYniUqxvFGQww=; b=XDpnr+M8Ikh8lDe/TIO1O+wvIjhBigNZFwFKUVzSeGONOyqJaTyzm9spKwYwWjyvnE okrvoQeLRhxpIX4BI+CWw8g7qLXrdBauMI3P9XtEePbsovZ2alx2vd9l9FI0sIDtJmBU 28OJS1FjtQ3kxhx34q4/s+GdMHw2a4XUwtLy/XhfOtP4bjatvp+wEhKn/5hcC+nXuCKm 78FaqXU5fNfjU3lH68ilDCh0wyRAUiiYVStD38sh2cQx2IuGy1mR7wDuub3WxodU26B+ o+jJ0YI1TIvHUt5sMDc+gRk0qTuYBPIqa1YDKrsV1+13KFbC2Wa+K0U0HET1Y0PR/FTv b5pw== X-Gm-Message-State: APjAAAXAwz21ZXOYdACtfMYCQsoYxH1K40m6CBAWjffV5dZ3gPuAj7jw FR7sMzaVNgKI4iuualIno494BCj3tiongjbplVp0AA== X-Google-Smtp-Source: APXvYqzviGNnZB0xy8wgUCQlLbSEfY1O2sV1Gmx8g29gI0TuUnECHk87VD3qKYhYUmziwREa8qPzZ8jc5wvr2DtX+7I= X-Received: by 2002:a05:660c:7d1:: with SMTP id e17mr11329212itl.158.1553502544368; Mon, 25 Mar 2019 01:29:04 -0700 (PDT) MIME-Version: 1.0 References: <20190325052853.11220-1-hao.a.wu@intel.com> In-Reply-To: <20190325052853.11220-1-hao.a.wu@intel.com> From: Ard Biesheuvel Date: Mon, 25 Mar 2019 09:28:50 +0100 Message-ID: To: Hao Wu Cc: "edk2-devel@lists.01.org" , Jordan Justen , Laszlo Ersek , Ray Ni Subject: Re: [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 08:29:05 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 25 Mar 2019 at 06:28, Hao Wu wrote: > > The series is also available at: > https://github.com/hwu25/edk2/tree/ovmf_siobus_v2 > > V2 changes: > * Introduce a static build flag 'USE_LEGACY_ISA_STACK' in OVMF DSC files > for users to select between the ISA driver stacks. > * V1 patch 2/2 is split into 2 patches in V2. The first one will add the > new OVMF SioBusDxe driver and list it in the DSC files. Then second one > will add the whole new ISA stack in DSC/FDF files. > > > V1 history: > > This series will update the OVMF to stop using the ISA drivers within > IntelFrameworkModulePkg. > > As the replacement, a new OVMF Super I/O bus driver has been add which > will install the Super I/O protocol for ISA serial and PS2 keyboard > devices. By doing so, these devices can be managed by: > > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > respectively. > > > Tests done: > A. GCC5 & VS2015x86 tool chains build pass > B. Launch QEMU (2.4.50, Windows) with command: > > qemu-system-x86_64.exe -pflash \OVMF.fd -serial file:1.txt -serial file:2.txt > > Able to see the ISA COM1/COM2 UART and PS2Keyboard devices under Shell > using command 'devtree'; > > Both the serials and PS2 keyboard are working fine; > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Ray Ni > > > Hao Wu (3): > OvmfPkg: Drop the ISA Floppy device support > OvmfPkg: Add an Super IO bus driver > OvmfPkg: Add a build flag to select ISA driver stack > Thanks Hao. For the series, Acked-by: Ard Biesheuvel but I will leave the final decision to Laszlo.