public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Jan Dąbroś" <jsd@semihalf.com>,
	"Grzegorz Jaszczyk" <jaz@semihalf.com>,
	"Kostya Porotchkin" <kostap@marvell.com>,
	"Jeremy Linton" <jeremy.linton@arm.com>,
	"Jici Gao" <Jici.Gao@arm.com>
Subject: Re: [edk2-platforms: PATCH v3 1/1] Marvell/Library: ComPhyLib: Update mode parameter for PCIE power on
Date: Sat, 20 Apr 2019 19:39:47 +0200	[thread overview]
Message-ID: <CAKv+Gu9cGcZHv2OYzezbiug7+6pwirj1nW-2hpZnE_g_izR+1w@mail.gmail.com> (raw)
In-Reply-To: <1555536006-2356-1-git-send-email-mw@semihalf.com>

On Wed, 17 Apr 2019 at 23:20, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Most recent ARM-TF ComPhy PCIE initialization routines check
> additional mode parameter in order to determine, where the SMC
> is called from (OS / firmware). Adjust to that.
>
> This patch fixes the Linux boot with DT.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as af08f2f4d4a3..14d177e378bd

> ---
>  Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h b/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h
> index 9fd6602..e918f01 100644
> --- a/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h
> +++ b/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h
> @@ -43,11 +43,13 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   */
>
>  /* Helper macros for passing ComPhy parameters to the EL3 */
> +#define COMPHY_CALLED_FROM_FW       (1 << 21)
>  #define COMPHY_FW_MODE_FORMAT(mode) (mode << 12)
>  #define COMPHY_FW_FORMAT(mode, idx, speeds) \
>                                      ((mode << 12) | (idx << 8) | (speeds << 2))
>  #define COMPHY_FW_PCIE_FORMAT(pcie_width, mode, speeds) \
> -                      ((pcie_width << 18) | COMPHY_FW_FORMAT (mode, 0, speeds))
> +                              (COMPHY_CALLED_FROM_FW | ((pcie_width) << 18) | \
> +                               COMPHY_FW_FORMAT(mode, 0, speeds))
>
>  /* Comphy speed */
>  #define COMPHY_SPEED_1_25G          0
> --
> 2.7.4
>

      reply	other threads:[~2019-04-20 17:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 21:20 [edk2-platforms: PATCH v3 1/1] Marvell/Library: ComPhyLib: Update mode parameter for PCIE power on Marcin Wojtas
2019-04-20 17:39 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9cGcZHv2OYzezbiug7+6pwirj1nW-2hpZnE_g_izR+1w@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox