From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=MIuYVf1O; spf=pass (domain: linaro.org, ip: 209.85.166.68, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by groups.io with SMTP; Sat, 20 Apr 2019 10:40:00 -0700 Received: by mail-io1-f68.google.com with SMTP id x3so6633681iol.10 for ; Sat, 20 Apr 2019 10:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0TWqLOydKa/7kzbVN3rZ3eRxpGYWX+HhhSeFRmcTxy8=; b=MIuYVf1O/6Ufvrua7LeEDCY8p1hnoGq3ayE7e//x5jTsOAFe1VZpqV/QqFuNdxVTt/ ssLxsAp8hBgRIlvWde5aJhtXkXCT5gVUxle9J1+J2jrYdbwgSNYC419JOk6DX4hl70K5 IQF8OAWPzPG0YwUP3T8aB4O1/cma2halRlWunzAPf3tYXFkczTBED00j3t3o7uvVHvJg aCXScecRW7P8vBKvLAhLDFeZaG0VI++1mqGjrxz2gantMAdjT5pLUNZBdgjTxUoMsOLy BByEOxFI8SaA1XDpclWhFXk8kk5h+3wKXqwWi3ZftPA9/BMucDqYcfWJhFVqu/kB+Cbm uDOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0TWqLOydKa/7kzbVN3rZ3eRxpGYWX+HhhSeFRmcTxy8=; b=t3P8UNTWrtt07ywvPr0GocdIWIJwZ1NIa78LqOY+d9BT/3Qi7SqNxophWKY38/6NHz UAyQ4pzsttoD0EePHSgBV/1uvbGZDIX/kNSBA1rr9YdTOeIiiNYGKfdOcJeRu5lirdBj X9CWhgYMCDiJF99u3Mg/HwtQn0fYQKPw861TrTRjmaHbQL9ZGr1Jjd7vjSYa/Av0BgZM Y9mNNCPyIEzHsZsxsvaIigpYx0sKGvGortAkC4S9vScDx2gDWO0FV+UYESTAcVhjWXrF lI2AmkEt2gk0NHWRbR2XloIfV6iVpVTYt+pI4j5FKC4SqwLpqiUFz7dh6m3HMaSJ5mj9 AlWg== X-Gm-Message-State: APjAAAVr5uDCNZUeij59r7uyCYrnIqtM/sR/LcNBcHeR7V8rw3IZtORU B6u1kfzJn2TDygXQ681cGwjJZgXh3VQ97il2XivBfA== X-Google-Smtp-Source: APXvYqz+vLXcXWezhj4PtvthmHb3JXcPd6OmOag3ZcoHqkzy1ZSAe8gMc+NP8JG9HVJKo9BaSQh/oWdqas1Q9Q2JRcs= X-Received: by 2002:a05:6602:2246:: with SMTP id o6mr2990254ioo.170.1555781999517; Sat, 20 Apr 2019 10:39:59 -0700 (PDT) MIME-Version: 1.0 References: <1555536006-2356-1-git-send-email-mw@semihalf.com> In-Reply-To: <1555536006-2356-1-git-send-email-mw@semihalf.com> From: "Ard Biesheuvel" Date: Sat, 20 Apr 2019 19:39:47 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH v3 1/1] Marvell/Library: ComPhyLib: Update mode parameter for PCIE power on To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Jeremy Linton , Jici Gao Content-Type: text/plain; charset="UTF-8" On Wed, 17 Apr 2019 at 23:20, Marcin Wojtas wrote: > > Most recent ARM-TF ComPhy PCIE initialization routines check > additional mode parameter in order to determine, where the SMC > is called from (OS / firmware). Adjust to that. > > This patch fixes the Linux boot with DT. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Pushed as af08f2f4d4a3..14d177e378bd > --- > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h b/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > index 9fd6602..e918f01 100644 > --- a/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > +++ b/Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > @@ -43,11 +43,13 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > /* Helper macros for passing ComPhy parameters to the EL3 */ > +#define COMPHY_CALLED_FROM_FW (1 << 21) > #define COMPHY_FW_MODE_FORMAT(mode) (mode << 12) > #define COMPHY_FW_FORMAT(mode, idx, speeds) \ > ((mode << 12) | (idx << 8) | (speeds << 2)) > #define COMPHY_FW_PCIE_FORMAT(pcie_width, mode, speeds) \ > - ((pcie_width << 18) | COMPHY_FW_FORMAT (mode, 0, speeds)) > + (COMPHY_CALLED_FROM_FW | ((pcie_width) << 18) | \ > + COMPHY_FW_FORMAT(mode, 0, speeds)) > > /* Comphy speed */ > #define COMPHY_SPEED_1_25G 0 > -- > 2.7.4 >