From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE17C211A2D93 for ; Fri, 14 Dec 2018 07:31:16 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id o19so9352651itg.5 for ; Fri, 14 Dec 2018 07:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sOV7PgF1MiH1J8K9gqmDqeWcLvbpIWpcpEdru/OxvmQ=; b=G7oNmwrYAKY0c7EKERZDp91c5oKSSJuPHgMBYKdh5tqc2uKrjdCe4qi4t2TDe/Thsk xkRa6xkBDmHscU69d/KO70VeVPUg5+lS6ZbEesS+DzGIk0q28aG8X2wEbMQcUJNMISWA TUevOMDyOO4ioDou6cFDm+pEYgM52NHD6rb9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sOV7PgF1MiH1J8K9gqmDqeWcLvbpIWpcpEdru/OxvmQ=; b=MBrbTYc94FPa2hD56yd7S65805ZRFQrL7pvJ/FW2jSn4iwasY3tJATsVTtGGwJmU46 LeubyRMmPVuJOcUTckhQjKdjz8Kf6YvvCgS0DSx7YyNdGgR0uMzzNkBVLVqfs6rCqqFE CWkdHvOoHbt7b+njAkF/HOJBEJgCxqqGY9ujl9/oyzHE/LuBRvs1o4HSmMquSmxowFm1 4F/5XiJPrUP13j0OWUvGx2sIMAlUfr3dWE39/JDSYo/vrgCO4oLF/Qo24Gl0KnCB7g1Z F0VeDPcI8ne0meB5IX21Kl1Pl78rmq0W9au9P+gu0PgknxM5AS9rdWEVCtALP2j6iNJJ VZ9A== X-Gm-Message-State: AA+aEWb2JqQHMl+DbooUl9Wnbutt2kHO4BYzb0j9umDMQ9r9T0e2hBAS SU2X/myPn/NgqML6qUQSutoi5tpxmUDntUL8ibotSg== X-Google-Smtp-Source: AFSGD/X/wYKowVwkxGJ1USZzMA/nDNip1nbgG8WtjM8IyBHxnpDqVyj1pDWdDUq+zuGc5OPmjtpeoa8z/EVwj6ARbqU= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr3620396itk.71.1544801475838; Fri, 14 Dec 2018 07:31:15 -0800 (PST) MIME-Version: 1.0 References: <20181210123853.4864-1-pete@akeo.ie> <20181210123853.4864-10-pete@akeo.ie> In-Reply-To: <20181210123853.4864-10-pete@akeo.ie> From: Ard Biesheuvel Date: Fri, 14 Dec 2018 16:31:04 +0100 Message-ID: To: Pete Batard Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH v2 edk2-platforms 09/20] Platform/Broadcom/RPi3: Add Graphic Console driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 15:31:17 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 10 Dec 2018 at 13:39, Pete Batard wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard > --- > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/ComponentName.c | 183 ++ > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/GraphicsConsole.c | 1836 ++++++++++++++++++++ > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/GraphicsConsole.h | 591 +++++++ > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 74 + > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxe.uni | 19 + > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/GraphicsConsoleDxeExtra.uni | 20 + > Platform/Broadcom/Bcm283x/Drivers/GraphicsConsoleDxe/NewFont.c | 288 +++ > Platform/Broadcom/Bcm283x/Include/Protocol/ExtendedTextOut.h | 36 + > 8 files changed, 3047 insertions(+) > Same as the previous patches: please check for the usual suspects. Also, please make global variables STATIC if they are never referenced from another object file.