From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by mx.groups.io with SMTP id smtpd.web10.45686.1585555669981231055
 for <devel@edk2.groups.io>;
 Mon, 30 Mar 2020 01:07:50 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=Vg6zOKzz;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f66.google.com with SMTP id g62so20821347wme.1
        for <devel@edk2.groups.io>; Mon, 30 Mar 2020 01:07:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=RXbE0rd0NOjmlmMDW1JPVfP0edUJnLEPdIGcacwSNy0=;
        b=Vg6zOKzzecUlIOof+Oq5kVBgYQbehDugUjDubkzUplCy9p8WsaXA/YQUGiA+MgRIMN
         SPtrLVV/xA4StkI4ozZnrb/HWzkPKy0VXjk6UaHAcxtb1IrnK5zmNZMtnYqdOKMTgBUG
         GO2vDDuQMFmdGGJ5Gq+vhusRctChy4gyTGPPUtX6XGzb6P9DUSNnf95i/7apCLxj3NI5
         JDL256gr3IsS5KbOKa0mkT1Mt/d5aOF3FukLwMZ3Snhfj6rb+G1MZuuQBqryejFv/GIs
         epukS9lsv1vE44tDHv7w8nlneH/b7ElPZcz/vEdUCXygg8kJYEBSI9rjBfO5CL0Wptsr
         R6tQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=RXbE0rd0NOjmlmMDW1JPVfP0edUJnLEPdIGcacwSNy0=;
        b=m8ddAf9nnOwWPV+GFarJEIsQRAtGWOSL7V7sM3oBrhAc7NXsPTpKgtpvmRbwPZd24s
         fXlB2VQrqiJA2A2H/NxXIQ3dXTuBB3z/xPtWgASkjiW4UWf308X9yKy29Ip28V6mTNR0
         cJ3wQ47HX2TOpTfi8aYR9fAxDvghKKZoK/BmiGtK29RGNkDKJrfsRJqgRWV2IRliqs7q
         wCQYv3MEY9vdlTTLjIFjAsEIuLyd57nbtrklXmq7Kw/yrHVa6b6+Xnzst7tmTN+ywawg
         c9PaDKdHyNGclMtLlKeIiQKD3Kus0McSEydry0Q7jhBp+GnA4eFE+Wx8VWSMflfZw6Bg
         m0lw==
X-Gm-Message-State: ANhLgQ0bwclRVIr8/KuUvNtLhwvwcSnd9m9OprB9go9R7Bp99yxokt6t
	um8zVcm8vKa7P8oVSeFaSEhJnOvpx2lM6op/cEntDZ+1GCA=
X-Google-Smtp-Source: ADFU+vs+3vcE2c4RxcB0s2+AOIgZGz7my2near6KKHC7qm5mnh9SEH2pEuqO0bXBnB4brkYAEn7j1TGmoqUAMx6wgH0=
X-Received: by 2002:a1c:ac8a:: with SMTP id v132mr11416916wme.62.1585555668329;
 Mon, 30 Mar 2020 01:07:48 -0700 (PDT)
MIME-Version: 1.0
References: <20200329173748.7288-1-sami.mujawar@arm.com> <20200329173748.7288-2-sami.mujawar@arm.com>
In-Reply-To: <20200329173748.7288-2-sami.mujawar@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 30 Mar 2020 10:07:36 +0200
Message-ID: <CAKv+Gu9cuVZpBBR1WvHdU0Anh9Xt2OC61wino+25Y16kZvx7jA@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: SRAT: Fix entry points
To: edk2-devel-groups-io <devel@edk2.groups.io>, Sami Mujawar <sami.mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>, Matteo Carlini <Matteo.Carlini@arm.com>, 
	Laura Moretta <Laura.Moretta@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Sun, 29 Mar 2020 at 19:38, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> VS2017 reports 'warning C4028: formal parameter 2 different
> from declaration' for the library constructor and destructor
> interfaces for the SRAT Generator modules.
>
> Remove the CONST qualifier for the SystemTable pointer (the
> second parameter to the constructor/destructor/DXE Entry
> point) to make it compatible with the formal declaration.
>

You are removing the CONST qualifier from two places, no?

> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> index 5d56af66608d862e6eca81da812d719f110867d2..74cb7d92a5d8cddd3df8334f3ab55e6fa3e7267a 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c
> @@ -800,8 +800,8 @@ ACPI_TABLE_GENERATOR SratGenerator = {
>  EFI_STATUS
>  EFIAPI
>  AcpiSratLibConstructor (
> -  IN CONST EFI_HANDLE                ImageHandle,
> -  IN       EFI_SYSTEM_TABLE  * CONST SystemTable
> +  IN  EFI_HANDLE           ImageHandle,
> +  IN  EFI_SYSTEM_TABLE  *  SystemTable
>    )
>  {
>    EFI_STATUS  Status;
> @@ -823,8 +823,8 @@ AcpiSratLibConstructor (
>  EFI_STATUS
>  EFIAPI
>  AcpiSratLibDestructor (
> -  IN CONST EFI_HANDLE                ImageHandle,
> -  IN       EFI_SYSTEM_TABLE  * CONST SystemTable
> +  IN  EFI_HANDLE           ImageHandle,
> +  IN  EFI_SYSTEM_TABLE  *  SystemTable

Can we keep the * with the argument name, please?

>    )
>  {
>    EFI_STATUS  Status;
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
> 
>