From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C1BA4223E0B8C for ; Fri, 23 Mar 2018 02:19:22 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id v194-v6so1797788itb.0 for ; Fri, 23 Mar 2018 02:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zkdKcXFg4tGw2cJ6n8vB5Mv1rmbybEhjKM6YmAr2FsI=; b=dyxEi4qezoZapm8LjFx/OAZIuBBRjOu3Omdpuu2TQY0BCBm+4ApzIF/X5R9JybocsK kSbDoLWptVWzVwNcmJhW30fmiMbTdjRNV+04Y0gCssB6BHEI+XsYaZT4lCMsOp9mD0nA s9rQ+U9Xt+eQ1BBrE5YzcqorR05Pmz0J+1hsA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zkdKcXFg4tGw2cJ6n8vB5Mv1rmbybEhjKM6YmAr2FsI=; b=j6kkGA/jZeXfefFSERUhQgNf07l9jg7UCSL//Xb4jtPPibTBYg37kDZ5v1buT7Ahc/ RrxZL3dkUA+Z+vdnXLH+VhJrxMlpXuIE0Pkv8OORlFlIi8JXFGadnAfGoBlWqR6KlHQe 5shBfO1hghdC7ez5+zh7rq8kh3sqi/BLfJ/9SnhohHAz4FCASlb4mrmWn4zSeiRpT7jy +9zeoNWzUXnzObDO2lmTmuQMTFYBz5ZjWJ9Z2haotZLCQv5v8u0tk9fHR1KIfWK1mTVT xRWYYPrEQwqNsoyDVGaqh5vZBWblo+fdrpLOi7Q2FHL3xhPUSLXLtll603NagHl/xfKH zbWw== X-Gm-Message-State: AElRT7FozzE9ElZNAv50aekb0QUropEjl/P9XJaA/nmG7mhRt/vNP7gV JH78nVr1Rf9/ENDNwzRQ5ErN9t37vPZBI9LQFKfnow== X-Google-Smtp-Source: AG47ELud1wU8pCmaHt5sTiFbbmobUb546DBqtm+S03sErMBiuQNqU4CyFomjGs5WjtHo8S7Nzxt4dQswCAF8BbJv8sY= X-Received: by 2002:a24:9c82:: with SMTP id b124-v6mr12252932ite.42.1521797154574; Fri, 23 Mar 2018 02:25:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 23 Mar 2018 02:25:54 -0700 (PDT) In-Reply-To: <1521716541-54412-2-git-send-email-heyi.guo@linaro.org> References: <1521716541-54412-1-git-send-email-heyi.guo@linaro.org> <1521716541-54412-2-git-send-email-heyi.guo@linaro.org> From: Ard Biesheuvel Date: Fri, 23 Mar 2018 17:25:54 +0800 Message-ID: To: Heyi Guo Cc: "edk2-devel@lists.01.org" , Yi Li , Leif Lindholm , Michael D Kinney Subject: Re: [PATCH edk2-non-osi 1/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 09:19:23 -0000 Content-Type: text/plain; charset="UTF-8" On 22 March 2018 at 19:02, Heyi Guo wrote: > The code in SM750 driver treated the address returned from > PciIo->GetBarAttributes() as device address; this should be fixed > after edk2 commit dc080d3 since GetBarAttributes() returns host > address from then on. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Signed-off-by: Yi Li > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 18432 bytes > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 18464 bytes Hi Heyi, If this is a PCI device, why do we have separate binaries for D03 and D05? > 2 files changed, 0 insertions(+), 0 deletions(-) > > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > index 16c91e2b18ef..3c7aae7dc6f6 100644 > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > index b8de0259c785..7d4fe1b3228f 100644 > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > -- > 2.7.4 >