From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::235; helo=mail-io0-x235.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A4FC62035BB1F for ; Fri, 17 Nov 2017 11:05:56 -0800 (PST) Received: by mail-io0-x235.google.com with SMTP id t11so9756419iof.13 for ; Fri, 17 Nov 2017 11:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z8lgP04LbG1BLyKpK7OdDmzZ3JzZPiWrnBrpbwC6OG4=; b=TBDoOdMOyP3vJAym1BvDFWXrPn940cjlQkFYp0Aspkw9fDHiwPJnKDDCy59Xuwa3uS PbeMaf7E3hqD/m0b1824oRLDZv4hZAhUz8KGCgMSJrOh0Kq/COUwOwsiuT3xrpnPXbN7 U9CdQ6YmAxh9SjwiDtJdRj0WGSSIUMlNNjs60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z8lgP04LbG1BLyKpK7OdDmzZ3JzZPiWrnBrpbwC6OG4=; b=L1VoeLLa9oR5FLKHc95/NAbhqECKOCtYO0lzjldGAwKmrni0w5C0s+ntW091Xep5xA cvAcqYol3FcBlMhxHgswrYxiJ03M043w1d8CeTSlewLclUKBYOOOqpY4x1GXMpS0WB+Y U+BVyBvkeiTV2so6YQdYWr4Wf8v81dNSM/w7Irg9roqNee8oGHJjTK39V1JwHZZLzHIh UIh8A6vWWCTFpLnewxvQdAEAFZ6/6gxrVFGecJgEWuIXZLmEeS8nufrTcsJasaY51aBa H0pe38kR56GFeD5TcL14HuG2XB8KX9oWgUYZGRwbcJbA8VuGxfum0tc5i7mzywN2wiuy UI4Q== X-Gm-Message-State: AJaThX6HjllHsEXJr18e1xQVktbNIawKRTD+oXU16uv7Xh4N/Q0Bass3 w+R0KRRuvHXi4qi7/GtoyVeTuKvt+5zB3yWECm4Os55+ASI= X-Google-Smtp-Source: AGs4zMZ3DS4XFirLo7Tish7Pae1lpdOaFAfYQ/MyuYXe2WZsqIVke4lgXWXQjoC/Og0gOAMscFfnbTwkJWClDGBHmf0= X-Received: by 10.107.69.17 with SMTP id s17mr983327ioa.253.1510945806348; Fri, 17 Nov 2017 11:10:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.3 with HTTP; Fri, 17 Nov 2017 11:10:05 -0800 (PST) In-Reply-To: <20171117162858.57cujpgykqhc2mq3@bivouac.eciton.net> References: <20171117160913.17292-1-ard.biesheuvel@linaro.org> <20171117160913.17292-2-ard.biesheuvel@linaro.org> <20171117162026.45dgzazw2scsdlhw@bivouac.eciton.net> <20171117162858.57cujpgykqhc2mq3@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 17 Nov 2017 19:10:05 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Subject: Re: [PATCH 01/15] ArmPlatformPkg/ArmPlatformLibNull: remove bogus PCD dependencies X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 19:05:56 -0000 Content-Type: text/plain; charset="UTF-8" On 17 November 2017 at 16:28, Leif Lindholm wrote: > On Fri, Nov 17, 2017 at 04:23:04PM +0000, Ard Biesheuvel wrote: >> On 17 November 2017 at 16:20, Leif Lindholm wrote: >> > On Fri, Nov 17, 2017 at 04:08:59PM +0000, Ard Biesheuvel wrote: >> >> Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and >> >> gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in >> >> a [FixedPcd] section makes this module unusable for ArmVirtQemu. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel >> > >> > Question: shouldn't specifically ArmVirtQemu work fine with these, >> > since it defines them as PcdsFixedAtBuild? >> > Whereas both ArmVirtQemuKernel and ArmVirtXen define them as >> > patchable. >> >> PcdSystemMemorySize is dynamic in ArmVirtQemu, and is the only >> platform that will include this library after this series. The others >> have their own PrePi implementation, allowing me to drop any >> dependencies on ArmPlatformLib altogether. > > Right. > > Of course I only looked at *Base for ArmVirtQemu. > Never mind. > > Reviewed-by: Leif Lindholm > Pushed as b2662641d56a