From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D7142194D387 for ; Fri, 21 Dec 2018 01:14:02 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id g17so1726156ioc.10 for ; Fri, 21 Dec 2018 01:14:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZPh/DkuYmR4Bw0z5A6nQap66ZCj/Y6VWUB3kYvjlT7o=; b=G6sPZ0CChN8yJ8A395XwceH5kSG/2MTCYcilkg/jjSgbO9WoqhJxOKfjzQ+/sX/76L srptR2fv2bKMd1A6O7AKeu953I6OUE+uY4uQUjK2jStGESGiR51UwefcdyLuQ1P+cPmC 3D1adPv+Fsr0A8agqXXH4ijPYjhJacgLDPImM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZPh/DkuYmR4Bw0z5A6nQap66ZCj/Y6VWUB3kYvjlT7o=; b=uLkja6f2B5oSIZE7lHG9NReq6MiUbtYcmcf6bWmsMJ+RlUcti4iRs/uN82eP3pjPen Qh5M4xJpqADCcA/HFt7LJSGdFhWICLwieQVi1J6v3gh3JecbuxkETDh46YgxQlgC3lef ebhGW4YBQfvqUP7aSCgtDCwweFOLS7BaSX1k4pmiRFLgnUEtT2f1/3cyh0a8gSVvW836 y1ApEYBR2DLXma6mRsgb5XdFaXVpBZM126AXgRVzwtA1AxwWlWxWc8pca3QSGd72GeUZ LOM9D9teift6vaMblIThHJQSA6s3ZdQNTx+rU96+r4R2S/Eo5U15Dd+F28atz51eil86 QiXg== X-Gm-Message-State: AJcUukdYtT2mchWwP5frKvIjspjKrOnzDFOFZ3/yABMmM5GpPweqrHBW SNlnrlvYpsEkifdiTGbAw/ERSwsN3vY548sQKXT5wQ== X-Google-Smtp-Source: ALg8bN5B4My31F6o8zN9IBxd+bJmHdsZ6nOPTtMisuFsh56NqwfOoiU0wDLy70TFnmxMnaidlhpC+/3RtiUDIGAtomQ= X-Received: by 2002:a5e:cb0b:: with SMTP id p11mr1132303iom.60.1545383642039; Fri, 21 Dec 2018 01:14:02 -0800 (PST) MIME-Version: 1.0 References: <1544789607-11316-1-git-send-email-jagadeesh.ujja@arm.com> <1544789607-11316-4-git-send-email-jagadeesh.ujja@arm.com> In-Reply-To: <1544789607-11316-4-git-send-email-jagadeesh.ujja@arm.com> From: Ard Biesheuvel Date: Fri, 21 Dec 2018 10:13:50 +0100 Message-ID: To: Jagadeesh Ujja Cc: "edk2-devel@lists.01.org" , "Gao, Liming" , "Zhang, Chao B" , Leif Lindholm Subject: Re: [PATCH 03/13] MdeModulePkg: Add a PCD to indicate Standalone MM supports secure variable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 09:14:03 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 14 Dec 2018 at 13:13, Jagadeesh Ujja wrote: > > Add a flag that indicates whether Standalone MM mode supports > secure storage of variables. > Why? And why does it need to reside in MdeModulePkg? > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jagadeesh Ujja > --- > MdeModulePkg/MdeModulePkg.dec | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 41d2b04..badea4a 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1041,6 +1041,11 @@ > # @Prompt Enable UEFI Stack Guard. > gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard|FALSE|BOOLEAN|0x30001055 > > + ## This flag indicates secure variable functionality is implemented by Standalone MM > + # TRUE - Secure variable storage supported by Standalone MM code. > + # FALSE - Standalone MM code does not support secure storage of variables > + gEfiMdeModulePkgTokenSpaceGuid.PcdStandaloneMmVariableEnabled|FALSE|BOOLEAN|0x30001056 > + > [PcdsFixedAtBuild, PcdsPatchableInModule] > ## Dynamic type PCD can be registered callback function for Pcd setting action. > # PcdMaxPeiPcdCallBackNumberPerPcdEntry indicates the maximum number of callback function > -- > 2.7.4 >