From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Dennis Chen <dennis.chen@arm.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
nd@arm.com, Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit
Date: Mon, 17 Oct 2016 18:09:00 +0100 [thread overview]
Message-ID: <CAKv+Gu9h6vPPNyHmrz0d_mS-N_2xE7mzVO+eWFVNJiCSM+Mx-w@mail.gmail.com> (raw)
In-Reply-To: <1476694460-29877-1-git-send-email-dennis.chen@arm.com>
On 17 October 2016 at 09:54, Dennis Chen <dennis.chen@arm.com> wrote:
> Since ACPI spec defines the GIC base addresses (CPU interface,
> Distributor and Redistributor*GICv3 only*) as 64-bit, so we should
> define these corresponding base address variables as 64-bit instead of
> 32-bit. This patch redefines them according to the ACPI spec.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Dennis Chen <dennis.chen@arm.com>
After a closer look, I noticed the following:
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicInterruptInterfaceBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicInterruptInterfaceBase,
ArmPkg/Include/Library/ArmGicLib.h: IN INTN
GicInterruptInterfaceBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicRedistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicRedistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicRedistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase,
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicInterruptInterfaceBase
ArmPkg/Include/Library/ArmGicLib.h: IN UINTN
GicInterruptInterfaceBase,
so I think we need to clean up the use of these values more widely
than we have done up till now
Leif: I was wondering if EFI_PHYSICAL_ADDRESS would be more
appropriate for MMIO base addresses?
next prev parent reply other threads:[~2016-10-17 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 8:54 [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit Dennis Chen
2016-10-17 17:09 ` Ard Biesheuvel [this message]
2016-10-18 2:50 ` Dennis Chen
2016-10-18 8:40 ` Ard Biesheuvel
2016-10-18 9:26 ` Dennis Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9h6vPPNyHmrz0d_mS-N_2xE7mzVO+eWFVNJiCSM+Mx-w@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox