From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 218771A1DFF for ; Mon, 17 Oct 2016 10:09:02 -0700 (PDT) Received: by mail-it0-x229.google.com with SMTP id 139so49276315itm.1 for ; Mon, 17 Oct 2016 10:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=x3fxHgemdPWET81DBmLYSYiToLq+YZPMugMr8YKFFiQ=; b=VbBPlsYXHLKGjLJIj5drUZKYQC2JYDQjxT3PeMRgSFEn7fzQdD0vuq08nlp62i3j0D NCLNGi9i5Du2FFjL3eXLDGpC8XzELFX2Nbw1T1Ap7WaLJrNNs8BdAMNmMYh0NV1AACFS MK8zuyOEahToAvw4Zg0IjAlQeSKilh9WDop0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=x3fxHgemdPWET81DBmLYSYiToLq+YZPMugMr8YKFFiQ=; b=LTINGDQJBflx6Y6mw5ozZRGTKiBo+nOz5NafzCmJUTRKZW63dhh1sbpzpn8oJeG3eu NTLNd4KR9kcePwvGmrth9iHLqsBsPPFNCSu8ihk+pTfYX3imhIH89YLr3GiTkmrh6jGa BIHR1+cwmPAygx//rCzCWY+MnqgF+6X/0Ta6aEc9ENhWSsEq01hMvSd2gt1pZnwOFhSh QaxMAF4oVPsw5Hw+qhrcEPBwua5bPmStZ/G2VrmgXvPuF7fIzHQFFRIFbXYedI+jR5wY 9g0GAy+brhTCb+SY2sRIufoy46ZRk2HLfzJiCzVrcB+UzTW2Yt5cMLXlR+GBNnJWrggI klkw== X-Gm-Message-State: AA6/9RlEQJTPih58hV3Nz3WI3eG5rKpOjNelpXntvE/dVjBozUrrMLQS0thc5tHXlAFmhgmWY28XZpdxz8L77hVu X-Received: by 10.36.5.65 with SMTP id 62mr9369319itl.63.1476724141360; Mon, 17 Oct 2016 10:09:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.5.139 with HTTP; Mon, 17 Oct 2016 10:09:00 -0700 (PDT) In-Reply-To: <1476694460-29877-1-git-send-email-dennis.chen@arm.com> References: <1476694460-29877-1-git-send-email-dennis.chen@arm.com> From: Ard Biesheuvel Date: Mon, 17 Oct 2016 18:09:00 +0100 Message-ID: To: Dennis Chen Cc: edk2-devel-01 , nd@arm.com, Leif Lindholm Subject: Re: [PATCH] ArmPkg: Fix the GIC base address variables as 64-bit X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 17:09:02 -0000 Content-Type: text/plain; charset=UTF-8 On 17 October 2016 at 09:54, Dennis Chen wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > define these corresponding base address variables as 64-bit instead of > 32-bit. This patch redefines them according to the ACPI spec. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Dennis Chen After a closer look, I noticed the following: ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicRedistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicRedistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicRedistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase, so I think we need to clean up the use of these values more widely than we have done up till now Leif: I was wondering if EFI_PHYSICAL_ADDRESS would be more appropriate for MMIO base addresses?