From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B3E0022344345 for ; Fri, 19 Jan 2018 07:27:57 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id b77so2564466itd.0 for ; Fri, 19 Jan 2018 07:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nk+Lb1hv+mwAbELynqlbbkdFLwRETLub+KW0fAp6Mfw=; b=aIwYo8PgD9brR9tqsd0AjebaFqNqti+Va4AGqihbRq1VAb34QhLcnKFSIz9o5DOt5v sVVxRHTJx7Jy20XVDKumq16vmzKt/bsNgn7A7V8n3GY0eCqBsiZQ834AgHJHEhf3Xnrw yoAgf0yR4wVzaEIG/LCvGq6ziXI7rChCgFsEc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nk+Lb1hv+mwAbELynqlbbkdFLwRETLub+KW0fAp6Mfw=; b=KyRFlT52jSjyFADURuskRBszMRhT9tG265/44jTOKPJ+S0xacLWHBzVBDtYRr2JRlt XsvBKinC/9342ZSRiMIOuOPQCiVXrikOjip89Pp55HyuaRVfJLvxYizhYHBQU5fnA8dX Gx3Q4ZESotMsnBKpQagl6vwJ/CCCBJhLNweztFbR9z9qMaFvRBNCNbN86e3vDkaHx+L7 p7PN2aDi1E9LxuVVsbCCid+ejli+0/Hfu1vaf/NbaJcI5aDmgL3owOh64i4FJXocwMGr PaIjqbhMytpp71khQurSuRBw0nwQMPlfF6WU1Lv2XXzfekZIXLT+a7hh/nRTZf7voMlI iYRQ== X-Gm-Message-State: AKwxytfV3O46kPZZ/y7VwluMzl/hndcs1m9pRJ9rsHLovU452vlyeN7Z mjNEmSU4rdY0fYtWPh3HZbp6f6/QlVq1Jmei3NcqWg== X-Google-Smtp-Source: ACJfBotKuIU+rJM+FctUvtcDy8TrEBxmvKVLj8h4EE8I2IzQQNWmvZeEnd978nzcl9ERrJn6M9oX2s8AXTieOc9yRIY= X-Received: by 10.36.207.87 with SMTP id y84mr29790012itf.59.1516375999552; Fri, 19 Jan 2018 07:33:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Fri, 19 Jan 2018 07:33:19 -0800 (PST) In-Reply-To: References: <1516089693-112214-1-git-send-email-heyi.guo@linaro.org> From: Ard Biesheuvel Date: Fri, 19 Jan 2018 15:33:19 +0000 Message-ID: To: "Long, Qin" Cc: Heyi Guo , "edk2-devel@lists.01.org" , "Ye, Ting" Subject: Re: [PATCH] CryptoPkg/OpensslLib: ignore uninitialized warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 15:27:58 -0000 Content-Type: text/plain; charset="UTF-8" On 16 January 2018 at 08:04, Long, Qin wrote: > Reviewed-by: Long Qin > This patch breaks the Clang 3.5 build, so we will need to add it for GCC48 only. error: unknown warning option '-Werror=maybe-uninitialized'; did you mean '-Werror=uninitialized'? [-Werror,-Wunknown-warning-option] > > Best Regards & Thanks, > LONG, Qin > > -----Original Message----- > From: Heyi Guo [mailto:heyi.guo@linaro.org] > Sent: Tuesday, January 16, 2018 4:02 PM > To: edk2-devel@lists.01.org > Cc: Heyi Guo ; Long, Qin ; Ye, Ting ; Ard Biesheuvel > Subject: [PATCH] CryptoPkg/OpensslLib: ignore uninitialized warning > > We also got maybe-uninitialized warning when building OpensslLib.inf with GCC48 for ARM and AARCH64, so add -Wno-error=maybe-uninitialized build option just as other platforms. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Cc: Qin Long > Cc: Ting Ye > Cc: Ard Biesheuvel > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 10021f8..55a6fa3 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -559,8 +559,8 @@ > GCC:*_*_IA32_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format > - GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) > - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-format > + GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized > + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) > + -Wno-error=maybe-uninitialized -Wno-format > > # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: > # 1295: Deprecated declaration - give arg types > -- > 2.7.4 >