From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=DBS0jSXP; spf=pass (domain: linaro.org, ip: 209.85.166.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by groups.io with SMTP; Fri, 26 Apr 2019 07:18:43 -0700 Received: by mail-io1-f67.google.com with SMTP id m188so3051766ioa.9 for ; Fri, 26 Apr 2019 07:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MSqr7ow53CnNicvHx9SRhJGBoZk/ZsTYvYifFO2ayig=; b=DBS0jSXPyclBpKiAkuw03/SAC1XIAhAU3sAORszPfwEFpba7XlzXMQ+R6gRiQZ+/Fx bZ3PUeYxIvDKqzKprQeuQU0qS4XyZOAgl5+uQnH5q3vqbREsIl9Ote9OFeB5GbMq5vJ6 +T36WnP6758et3qIwvOhd8pqhzVyMFcvLyav/s6LQQrW1l8Wc95DIlEwN1r3MyrhQ2pC OiQb1J8WMPci4tC/ZXOjO8m+jt8NspkNR4ak2x39bqkbpJHK3kdQp5tq+FkR/5ghsmSJ MPDhgTi3F4EwjbYMuqbXCdVyTOAqC0H8Ds9DMh9q9HY/XywoUdS0p788SMBBM9X9D7kD IMNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MSqr7ow53CnNicvHx9SRhJGBoZk/ZsTYvYifFO2ayig=; b=joK3qTRjdL6jqfJ1x2eplgdBrvOWZD72S9M/yC2qjSz/HwvqTEQNjnhmnPcrG6Ophl zE20qvxfBhvnd+GfqJezWr/EbkphMMSIf4ugY+sE0qv3r+984ZPJQuSxJ5AnYMQx1skS 8T4iMxvsIoAXBQgbepV05XTikabtI2VSsrv0m5CnbB9aFjEhpZ5AySmWls3HMTozvTeY +Q1w66ZirF1kjTdbkB+TTwhpf/BUT20fih7Ewx5W3POxQPtcJVc5+iRYAfuWbIuBFwkm q7evR8Hz2sEigTlbxr/UKUuuSPe51ROUyZeDvwtu7Mnv0TLS6esxuP+QKu6yKeysR5as h/GA== X-Gm-Message-State: APjAAAUv8Hcc+/DpBvVlBd+aZzUWN30kHO8AjdCS63vo3uv2ESHAjSC6 PtaX2r8IT0r6SL7ASmWSU5lAgHPzRj6B2ucV1M9l3Q== X-Google-Smtp-Source: APXvYqwl+ya5VEAcYtv6fNo9gRFKqwo0+foU3vCw4hzjIcxTHDbelH7rviajVh4t/WE8x5iMdJMxj3wVqDKLfvO+tC0= X-Received: by 2002:a5e:8b0d:: with SMTP id g13mr16681599iok.170.1556288322578; Fri, 26 Apr 2019 07:18:42 -0700 (PDT) MIME-Version: 1.0 References: <20190425123254.16396-1-ard.biesheuvel@linaro.org> <20190425123254.16396-4-ard.biesheuvel@linaro.org> <20190426111610.w5cnegxjn66paavb@bivouac.eciton.net> <20190426141738.q4gm4s3jbrj42mib@bivouac.eciton.net> In-Reply-To: <20190426141738.q4gm4s3jbrj42mib@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Fri, 26 Apr 2019 16:18:30 +0200 Message-ID: Subject: Re: [PATCH edk2-platforms 3/3] Platform/Secure96Dxe: add ACPI description of the GPIO LEDs To: Leif Lindholm Cc: edk2-devel-groups-io , Graeme Gregory , Masahisa Kojima Content-Type: text/plain; charset="UTF-8" On Fri, 26 Apr 2019 at 16:17, Leif Lindholm wrote: > > On Fri, Apr 26, 2019 at 01:56:54PM +0200, Ard Biesheuvel wrote: > > On Fri, 26 Apr 2019 at 13:16, Leif Lindholm wrote: > > > > > > On Thu, Apr 25, 2019 at 02:32:54PM +0200, Ard Biesheuvel wrote: > > > > Wire up the new 96boards mezzanine SSDT loading support, and use it > > > > to describe the four GPIO LEDs on the Secure96 mezzanine board. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel > > > > --- > > > > Platform/96Boards/Secure96Dxe/Secure96.asl | 103 ++++++++++++++++++++ > > > > Platform/96Boards/Secure96Dxe/Secure96Dxe.c | 59 ++++++++++- > > > > Platform/96Boards/Secure96Dxe/Secure96Dxe.inf | 1 + > > > > 3 files changed, 158 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/Platform/96Boards/Secure96Dxe/Secure96.asl b/Platform/96Boards/Secure96Dxe/Secure96.asl > > > > new file mode 100644 > > > > index 000000000000..bb9dac462a33 > > > > --- /dev/null > > > > +++ b/Platform/96Boards/Secure96Dxe/Secure96.asl > > > > @@ -0,0 +1,103 @@ > > > > +/** @file > > > > + * Copyright (c) 2019, Linaro Limited. All rights reserved. > > > > + * > > > > + * This program and the accompanying materials are licensed and made > > > > + * available under the terms and conditions of the BSD License which > > > > + * accompanies this distribution. The full text of the license may be > > > > + * found at http://opensource.org/licenses/bsd-license.php > > > > + * > > > > + * THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > > > + * WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > > > > + * IMPLIED. > > > > + */ > > > > + > > > > +#include "Secure96.h" > > > > + > > > > +DefinitionBlock ("Secure96.aml", "SSDT", 2, "LINARO", "SECURE96", 1) > > > > +{ > > > > + External (\_SB.LS96.GPIO) > > > > + > > > > + Scope (_SB) > > > > + { > > > > + Device (LD96) > > > > + { > > > > + Name (_HID, "PRP0001") // _HID: Hardware ID > > > > + Name (_UID, 0x00) // _UID: Unique ID > > > > + Name (_DSD, Package () { > > > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > > > > > Surely the above stanza is the most repeated bit of boiler plate in > > > the entire tree? I count 207 instances before this goes in. > > > Can we stick a #define in some common header for this and reuse? > > > ACPI_DSD_UUID? > > > > > > As I said, not required for this patch, but would be worth addressing. > > > > > > > We should add the GUID to MdePkg, given that it occurs in the ACPI spec. > > Yeah. What form would be practically consumable by .asl? > I think only a CPP macro including the "" is workable in practice.