From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Alan Ott <alan@softiron.co.uk>,
Graeme Gregory <graeme.gregory@linaro.org>
Subject: Re: [PATCH edk2-platforms 0/2] Silicon/Styx: merge and simplify ACPI platform driver
Date: Tue, 11 Dec 2018 09:02:14 +0100 [thread overview]
Message-ID: <CAKv+Gu9jSwHUNsn1ZMe1cE5-DOhPK-VV0XAeWQmyW8UR62OYtg@mail.gmail.com> (raw)
In-Reply-To: <20181210222034.rsfuzb7cac26br4m@bivouac.eciton.net>
On Mon, 10 Dec 2018 at 23:20, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Thu, Dec 06, 2018 at 01:12:02PM +0100, Ard Biesheuvel wrote:
> > After fixing the iasl issue yesterday, I got a bit carried away and ended
> > up rewriting most of the ACPI table generation logic for Styx. So this
> > applies on top of the patches I sent out yesterday.
> >
> > Patch #1 merges the DXE driver and the library, that are split in two for
> > no good reason.
> >
> > Patch #2 simplifies the MADT generation code.
>
> I would be lying if I said I'd properly reviewed this series, but
> superficially it looks good, and I trust you to have tested it
> properly. So:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as 217713e2cfc9..d645d82b5868
prev parent reply other threads:[~2018-12-11 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 12:12 [PATCH edk2-platforms 0/2] Silicon/Styx: merge and simplify ACPI platform driver Ard Biesheuvel
2018-12-06 12:12 ` [PATCH edk2-platforms 1/2] Silicon/AMD/Styx: merge ACPI table drivers Ard Biesheuvel
2018-12-06 12:12 ` [PATCH edk2-platforms 2/2] Silicon/Styx/AcpiPlatformDxe: simplify MADT generation logic Ard Biesheuvel
2018-12-10 22:20 ` [PATCH edk2-platforms 0/2] Silicon/Styx: merge and simplify ACPI platform driver Leif Lindholm
2018-12-11 8:02 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9jSwHUNsn1ZMe1cE5-DOhPK-VV0XAeWQmyW8UR62OYtg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox