From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED28621198CB9 for ; Tue, 11 Dec 2018 00:02:26 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id x19so2237143itl.1 for ; Tue, 11 Dec 2018 00:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bef0M+zVVMuKPBr6nXoqjuI0dJ5dOD20WP0r2d4wK64=; b=bxkQlUssy+nX31swzgUqo5Qeax94ih7GmdcnKop9LhcQXhqJjMGY/re1uiJr0g+eTG vYNKfwRrp+rTLlj4A6oCcurSVHSIZRJRlW6fvE6JF8puYHSDaPxz6BOXX9g5QiFk732M sPlxrYXl66/IBKXHmaQ/nqqMg+uINqOEXj9KQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bef0M+zVVMuKPBr6nXoqjuI0dJ5dOD20WP0r2d4wK64=; b=sbCOK4MZ/eSa5POlGSZSNgYgc19DoSLQl6+yWJF2Ahc9E2Zj3onUmpciK/kelYKosy 1jrWfwQBAQyoA4sQOEsMA1DY/da1uy0vODoMGZgE8LvCy5/69Un4IyomjzNh7ruNQ5Wb 1yAB9vYWttRuTVs5Rz5z4ssggutcTSJIxxHdfTIVwNibl3eT5kGc7bfN8hTnLzVuednP YA055g9Ab6jUrMmiyC23lkrE1/hnyHOuaRNgU+v1vSJlHHc/D1MTtStUm2KyhLZ6qGri 10bftQ5H6VfNxlFnC7R/gQmr9LsU3LAUyD8V2gqqXJcb/dkKlZ2L9w1uab3/iEABtjwX bbOQ== X-Gm-Message-State: AA+aEWY7vnKusM/WLRUMfqxT7R35ueS5TNZMRNq2DgucsA2N+nIS8oSE fk+Cj3MpKIISX9g61xNFs2bQiU0Vrd2ixqlFSK9MDw== X-Google-Smtp-Source: AFSGD/W9AGimfGKfVhay8Om/+pBgeDbyuJJX1AbnvGZUFJxP4nHW9OxY/GcjQmP2GOIW3Hhmtp3GXvY6sLIUH/BJtsA= X-Received: by 2002:a24:edc4:: with SMTP id r187mr1490145ith.158.1544515346191; Tue, 11 Dec 2018 00:02:26 -0800 (PST) MIME-Version: 1.0 References: <20181206121204.4057-1-ard.biesheuvel@linaro.org> <20181210222034.rsfuzb7cac26br4m@bivouac.eciton.net> In-Reply-To: <20181210222034.rsfuzb7cac26br4m@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 11 Dec 2018 09:02:14 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Alan Ott , Graeme Gregory Subject: Re: [PATCH edk2-platforms 0/2] Silicon/Styx: merge and simplify ACPI platform driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 08:02:27 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 10 Dec 2018 at 23:20, Leif Lindholm wrote: > > On Thu, Dec 06, 2018 at 01:12:02PM +0100, Ard Biesheuvel wrote: > > After fixing the iasl issue yesterday, I got a bit carried away and ended > > up rewriting most of the ACPI table generation logic for Styx. So this > > applies on top of the patches I sent out yesterday. > > > > Patch #1 merges the DXE driver and the library, that are split in two for > > no good reason. > > > > Patch #2 simplifies the MADT generation code. > > I would be lying if I said I'd properly reviewed this series, but > superficially it looks good, and I trust you to have tested it > properly. So: > Reviewed-by: Leif Lindholm > Thanks Pushed as 217713e2cfc9..d645d82b5868