public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h
Date: Mon, 11 Feb 2019 19:03:09 +0100	[thread overview]
Message-ID: <CAKv+Gu9jZQHwpDJ1_GP4djrqMDKaS9V6_1egHtYjOd_ctzwhcw@mail.gmail.com> (raw)
In-Reply-To: <20190211180202.991-1-leif.lindholm@linaro.org>

On Mon, 11 Feb 2019 at 19:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe
> .vfr rather than local definitions.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr   | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> index 8a395eac68..25b7b49a3d 100644
> --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr
> @@ -15,14 +15,7 @@
>  #include <Guid/HiiPlatformSetupFormset.h>
>  #include <Guid/SynQuacerPlatformFormSet.h>
>  #include <Platform/VarStore.h>
> -
> -//
> -// EFI Variable attributes
> -//
> -#define EFI_VARIABLE_NON_VOLATILE       0x00000001
> -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002
> -#define EFI_VARIABLE_RUNTIME_ACCESS     0x00000004
> -#define EFI_VARIABLE_READ_ONLY          0x00000008
> +#include <Uefi/UefiMultiPhase.h>
>
>  formset
>    guid      = SYNQUACER_PLATFORM_FORMSET_GUID,
> --
> 2.11.0
>


  reply	other threads:[~2019-02-11 18:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 18:02 [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h Leif Lindholm
2019-02-11 18:03 ` Ard Biesheuvel [this message]
2019-02-11 19:06   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9jZQHwpDJ1_GP4djrqMDKaS9V6_1egHtYjOd_ctzwhcw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox