From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F1C6208AEA1D for ; Mon, 11 Feb 2019 10:03:23 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id z20so402870itc.3 for ; Mon, 11 Feb 2019 10:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x92Zuf256RO80Fx7c1JWAX5VAQZNHwgs+0ZMK+Pxbxw=; b=kTKt4gnQVhvXuNdwN/Jxl7F1Hjuumr1lD5i9E9ZinxKE//3sgFwMC34GoI+DYKJJGB aJ2Z3gu8HhHxxygYI6sEpfCfVkD+SdOeumoXYZMp7Pq3XzRiGBsEuzElDlgYF3FHQsjU +PTtNZxMyhrdueSZsiuXAGzGefucEgX/cf0dRgU+JKNogDESUMYezHKpjuM4YD0MyDC9 /2ejwKYe2+k5VWyuOKh3ATZC3EIS20ykDhffT2jnSSGEeePBaQ4c+MIcBXdysnzdDzQ8 P72xMLcQpAX5wLIQLdqegWDRIhrEE/GXbysk95AIog8tq8LN2lvc3YRjl/+ZFHTeJANk +9VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x92Zuf256RO80Fx7c1JWAX5VAQZNHwgs+0ZMK+Pxbxw=; b=Ps4I6c3swooevUV+9i2lq516Ky0ajX77Ghhe3Xdl9zwYWOC+Fz/IYsyVccngR2gCB1 YNvzkXbGx80a0QwRha2RZ8M8gCEz1GasUMQ2b2ZGchl6svYxm8apb0ZGoUtDyydwcOYx LKB94tUszrbeBFcNkIl6Y1YTIfjZ8p7ONaWY+eJvDEcqEtR5TqmKQtf67th5PSMW7/rb GQHFX82wVP2gPpBTs/+Se8khsnJEMFN7avp0Xj3sCCLiO2UXApZr2fqMWIYf2lmG4xHh MZBdcTVUR0vVNTyasic3tNBTGB9xWKsb/rUWs4M75Ao+6xpL5mHEo+88e/g8exlhB83l GIjg== X-Gm-Message-State: AHQUAuYLCT0V1BABBZgE7br9S5Z4vV9c/+QfSiPA0L1ZGAub0iFuaBLL P8tUIDLiXW6WxJXtn04xQRUxdVgc9NVMVw6paXRYjAIy X-Google-Smtp-Source: AHgI3IYexQu5dr+6U9tYyKPa7nCeKTGSUhsPvwe1AgqWSKGmGJKgYYn0wWtzFhsnUqAgz5x5VU/21QLdpcyZ/R+quJ0= X-Received: by 2002:a24:710:: with SMTP id f16mr378497itf.121.1549908202604; Mon, 11 Feb 2019 10:03:22 -0800 (PST) MIME-Version: 1.0 References: <20190211180202.991-1-leif.lindholm@linaro.org> In-Reply-To: <20190211180202.991-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Mon, 11 Feb 2019 19:03:09 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Silicon/Socionext: use variable attributes from Uefi/UefiMultiPhase.h X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 18:03:23 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 11 Feb 2019 at 19:02, Leif Lindholm wrote: > > Use EFI variable attributes from Uefi/UefiMultiPhase.h in PlatformDxe > .vfr rather than local definitions. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > .../Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > index 8a395eac68..25b7b49a3d 100644 > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxeHii.vfr > @@ -15,14 +15,7 @@ > #include > #include > #include > - > -// > -// EFI Variable attributes > -// > -#define EFI_VARIABLE_NON_VOLATILE 0x00000001 > -#define EFI_VARIABLE_BOOTSERVICE_ACCESS 0x00000002 > -#define EFI_VARIABLE_RUNTIME_ACCESS 0x00000004 > -#define EFI_VARIABLE_READ_ONLY 0x00000008 > +#include > > formset > guid = SYNQUACER_PLATFORM_FORMSET_GUID, > -- > 2.11.0 >