Re: [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 5 September 2016 at 12:21, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Sep 05, 2016 at 12:06:01PM +0100, Ard Biesheuvel wrote:
>> Now that the MMU manipulation routines have been moved out of ArmLib into
>> ArmMmuLib, we are left with the following implementations of ArmLib which
>> are all identical except for the fact that they target either ARM or AARCH64
>> but not both.
>>
>>   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf
>>   ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf
>>   ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf
>>   ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf
>>   ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
>>   ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf
>>   ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf
>>
>> So implement a new version 'ArmBaseLib' which does target both ARM and AARCH64,
>> and replace all ArmLib references with ArmBaseLib.
>>
>> NOTE: this requires changes for existing out of tree users of ArmLib
>
> I like this one. However, given the invasiveness, I would quite like
> to see a couple of Tested-by:s for out-of-tree platforms. With that:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

As discussed off-ML, pushed as

2ede1ac0cc74 ArmPkg/ArmLib: remove NullArmLib
c52c592a0318 ArmPkg/ArmLib: introduce ArmBaseLib
4af5227cdefb BeagleBoardPkg EmbeddedPkg Omap35xxPkg: move to ArmBaseLib
550eaa4a76fc ArmVirtPkg: replace all ArmLib resolutions with ArmBaseLib
2bdf3f2ca78e ArmPkg/ArmLib: remove all ArmLib flavors except ArmBaseLib

I will follow up with a couple of cleanup patches