From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED2921A1F1E for ; Thu, 8 Sep 2016 02:41:14 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id e124so69618479ith.0 for ; Thu, 08 Sep 2016 02:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Qkdfptc0lLeMA4YYKDFrHbhtuCUj5wlAu4ZCivDn9X0=; b=GsHEGu8QdXypJlAjfA+HnnO1EhsTXO4bHGNtwWPxiLAmU2GXayVkM/RZpsxKrk64ca UYztq4wZx3qfXjW8KK19uRWxZ3aFjFKMcZwA9+IaP5PtCAGvMgn6NQurqnwXotUlkvEp CrxLVtTO9lFI8C9waJ7LbBM0A0SYx1+HdgVsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Qkdfptc0lLeMA4YYKDFrHbhtuCUj5wlAu4ZCivDn9X0=; b=WtfHNZs6+OtjYxD7GcLWi7CkncJouYokhO4TLLtq84VUVUhJ9S32D8W7azXMLEqrvC CPpDbutJNZ2cG/rk2OlaFUhP5fupeEBOzooJAdcCvGDNsamwDJiIjXTTabiaivO/vmTN xifIDZqkqbH5i6hPJETQjuY3GsN0VQBM5nVUEXqH592Qh+kaQOZ+qrSnbc3sUjvNzgya Dw000L9QQTfttoS8umZ7+JOlNpFMH50yM8HMH2YoogvQb6ynVORMDEDiZ6ns+c1m8FzQ dWnYqC8tVbUsguknx2kdk3IKZYtEoihjBQKvyHZZ4xBTn3RJAYw28z6XMSSBa0dQQFgn c9Wg== X-Gm-Message-State: AE9vXwMTzd6ncrJSr2Wp5vJvFlYRkbVpBuQaY5aLzFoy6uWk6bDlLK/CdeTOpM7u75Abeix07AhiBKjaQHcSLj6u X-Received: by 10.36.137.193 with SMTP id s184mr13099350itd.51.1473327674296; Thu, 08 Sep 2016 02:41:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 8 Sep 2016 02:41:13 -0700 (PDT) In-Reply-To: <20160905112155.GI4715@bivouac.eciton.net> References: <1473073566-1504-1-git-send-email-ard.biesheuvel@linaro.org> <20160905112155.GI4715@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 8 Sep 2016 10:41:13 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Laszlo Ersek Subject: Re: [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 09:41:15 -0000 Content-Type: text/plain; charset=UTF-8 On 5 September 2016 at 12:21, Leif Lindholm wrote: > On Mon, Sep 05, 2016 at 12:06:01PM +0100, Ard Biesheuvel wrote: >> Now that the MMU manipulation routines have been moved out of ArmLib into >> ArmMmuLib, we are left with the following implementations of ArmLib which >> are all identical except for the fact that they target either ARM or AARCH64 >> but not both. >> >> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf >> ArmPkg/Library/ArmLib/AArch64/AArch64LibPei.inf >> ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf >> ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf >> ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf >> ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf >> ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf >> >> So implement a new version 'ArmBaseLib' which does target both ARM and AARCH64, >> and replace all ArmLib references with ArmBaseLib. >> >> NOTE: this requires changes for existing out of tree users of ArmLib > > I like this one. However, given the invasiveness, I would quite like > to see a couple of Tested-by:s for out-of-tree platforms. With that: > Reviewed-by: Leif Lindholm > As discussed off-ML, pushed as 2ede1ac0cc74 ArmPkg/ArmLib: remove NullArmLib c52c592a0318 ArmPkg/ArmLib: introduce ArmBaseLib 4af5227cdefb BeagleBoardPkg EmbeddedPkg Omap35xxPkg: move to ArmBaseLib 550eaa4a76fc ArmVirtPkg: replace all ArmLib resolutions with ArmBaseLib 2bdf3f2ca78e ArmPkg/ArmLib: remove all ArmLib flavors except ArmBaseLib I will follow up with a couple of cleanup patches