public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	 Ray Ni <ray.ni@intel.com>, Julien Grall <julien.grall@arm.com>,
	 Leif Lindholm <leif.lindholm@linaro.org>,
	Jian J Wang <jian.j.wang@intel.com>,
	 Hao A Wu <hao.a.wu@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID
Date: Thu, 6 Jun 2019 19:17:07 +0200	[thread overview]
Message-ID: <CAKv+Gu9jx+xgQBfD0DOc+ZLJ1XqKb6=TJDBh09_LUAwdSXs-hg@mail.gmail.com> (raw)
In-Reply-To: <37fb4041-9b04-43bb-8e02-b41fb25afce2@redhat.com>

On Thu, 6 Jun 2019 at 19:16, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 06/06/19 15:14, Anthony PERARD wrote:
> > The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> > once without defining the macro. This patch series define a macro in
> > MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
> > EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> >
> > Note that I haven't build/test those changes, but I have test the first patch
> > by applying a similar change to a patch series I'm working on.
> >
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
> >
> > Thanks.
> >
> > Anthony PERARD (4):
> >   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> >   ArmVirtPkg/PlatformBootManagerLib: Use
> >     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> >   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> >     from MdeModulePkg
> >   UefiPayloadPkg/PlatformBootManagerLib: Use
> >     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> >
> >  MdeModulePkg/MdeModulePkg.dec                 |  3 +++
> >  .../Universal/SerialDxe/SerialDxe.inf         |  1 +
> >  .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
> >  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
> >  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
> >  MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
> >  .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
> >  7 files changed, 31 insertions(+), 14 deletions(-)
> >  create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> >
>
> For patches #1 and #2:
>
> Tested-by: Laszlo Ersek <lersek@redhat.com>
>

For the series:

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

  reply	other threads:[~2019-06-06 17:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 13:14 [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID Anthony PERARD
2019-06-06 13:14 ` [PATCH v2 1/4] MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID Anthony PERARD
2019-06-06 17:13   ` Laszlo Ersek
2019-06-13  6:49     ` [edk2-devel] " Wu, Hao A
2019-06-06 13:14 ` [PATCH v2 2/4] ArmVirtPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg Anthony PERARD
2019-06-06 17:09   ` Laszlo Ersek
2019-06-06 13:14 ` [PATCH v2 3/4] ArmPkg/PlatformBootManagerLib: " Anthony PERARD
2019-06-06 13:14 ` [PATCH v2 4/4] UefiPayloadPkg/PlatformBootManagerLib: " Anthony PERARD
2019-06-13 16:06   ` [edk2-devel] " Ma, Maurice
2019-06-06 17:15 ` [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID Laszlo Ersek
2019-06-06 17:17   ` Ard Biesheuvel [this message]
2019-06-13 15:32 ` [edk2-devel] " Laszlo Ersek
2019-06-13 15:33   ` Laszlo Ersek
2019-06-13 16:09   ` Ma, Maurice
2019-06-14 19:35 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9jx+xgQBfD0DOc+ZLJ1XqKb6=TJDBh09_LUAwdSXs-hg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox