From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=kzN7t+D7; spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193]) by groups.io with SMTP; Thu, 06 Jun 2019 10:17:23 -0700 Received: by mail-it1-f193.google.com with SMTP id a186so1215198itg.0 for ; Thu, 06 Jun 2019 10:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7MF/SjrCpuuw011NwI7I4Clyz6wQT8CQvyKN0k1SDFE=; b=kzN7t+D7NoGaDz93J6v9QPL8X098rux4xU5gTgYgZJRyaeDhoVJrYo5wgE078GGI74 nndeEA49nIRa9Sg6nMZlSta9xbmGYt2cAGjqFu19Vooa5Pzet3DQmR6X9MhmoQ2kOpm8 bq2tEV3scMc+57NrByIHb9318oNvW9cMBpFPtRVia8ne8YLfaq4nZgZp5N71qcNtKQpk +okyKBrcUm3S4tMRcMwHO4fAGADqPMvTF2/tWNMgH627xdAkQSmeJD9n4Z5IMAxNUV0X dqilcv9L49hAOQXyR32WrmBity7NbkdqIpbFo3/jk54+mslxDeV1nn78WQcYsgqmx2YS LeEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7MF/SjrCpuuw011NwI7I4Clyz6wQT8CQvyKN0k1SDFE=; b=X3FaACT5LPP6Fs8BhRTkRMj+tEsako5K9oEur/ecUzq6oPiRRyBMwFHooiv4PpcKJ+ TlJ1guNkuSH+nKsX3vYPbo67r5smp4UI65JROcvWRItawcLgXx6BakY21hpSZXVTcotZ zTS90HIDxBhc4yAnkN5HsihyrZsTVdSssqMk4hlc0B3ouinTTgb71G4bBoBdFE2rZh20 F7fl5duBcSvWyKVkQhU+B0uGtTzi887Gr6IQV5YwWS8wPYDqduU9E0CMsBhTImzn3mSk latnZlnBT1C9spaAguEAxKSOC2MaWYfEC/urMlPQfgubEhCh3XweSMEeMgfYxy1WVBw1 k7Cg== X-Gm-Message-State: APjAAAWdVl0m0kfT2iz5BrZBhVjDXWv31YGaQoynE5NKPEZglqX89dh+ c7ODQXyu2FfDxe8QgNmT9WlsFI+HLgpGNHta3413kQ== X-Google-Smtp-Source: APXvYqxjm4I9cJTKidhivuljuMrkhRzApEU23rh7SZ8KEAL2+zCJZZRU+zXPUxvWyqKds0WBS41RmIn+6bRy6M+nGm8= X-Received: by 2002:a02:b01c:: with SMTP id p28mr32459412jah.130.1559841443008; Thu, 06 Jun 2019 10:17:23 -0700 (PDT) MIME-Version: 1.0 References: <20190606131459.1464-1-anthony.perard@citrix.com> <37fb4041-9b04-43bb-8e02-b41fb25afce2@redhat.com> In-Reply-To: <37fb4041-9b04-43bb-8e02-b41fb25afce2@redhat.com> From: "Ard Biesheuvel" Date: Thu, 6 Jun 2019 19:17:07 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID To: Laszlo Ersek Cc: Anthony PERARD , edk2-devel-groups-io , Ray Ni , Julien Grall , Leif Lindholm , Jian J Wang , Hao A Wu , Star Zeng Content-Type: text/plain; charset="UTF-8" On Thu, 6 Jun 2019 at 19:16, Laszlo Ersek wrote: > > On 06/06/19 15:14, Anthony PERARD wrote: > > The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used > > once without defining the macro. This patch series define a macro in > > MdeModulePkg where the SerialDxe is, and replace all other use by this new one, > > EDKII_SERIAL_PORT_LIB_VENDOR_GUID. > > > > Note that I haven't build/test those changes, but I have test the first patch > > by applying a similar change to a patch series I'm working on. > > > > Patch series available in this git branch: > > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2 > > > > Thanks. > > > > Anthony PERARD (4): > > MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID > > ArmVirtPkg/PlatformBootManagerLib: Use > > EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg > > ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID > > from MdeModulePkg > > UefiPayloadPkg/PlatformBootManagerLib: Use > > EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg > > > > MdeModulePkg/MdeModulePkg.dec | 3 +++ > > .../Universal/SerialDxe/SerialDxe.inf | 1 + > > .../Include/Guid/SerialPortLibVendor.h | 19 +++++++++++++++++++ > > .../PlatformBootManagerLib/PlatformBm.c | 8 ++------ > > .../PlatformBootManagerLib/PlatformBm.c | 8 ++------ > > MdeModulePkg/Universal/SerialDxe/SerialIo.c | 3 ++- > > .../PlatformBootManagerLib/PlatformConsole.c | 3 ++- > > 7 files changed, 31 insertions(+), 14 deletions(-) > > create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h > > > > For patches #1 and #2: > > Tested-by: Laszlo Ersek > For the series: Acked-by: Ard Biesheuvel