Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 4 July 2017 at 12:04, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi,
>
> 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>> Switch to the generic implementation of the ResetSystem() runtime
>> service call, which is preferred over the one in EmbeddedPkg. This
>> involves selecting another DXE runtime driver, and morphing the
>> existing EfiResetSystemLib implementation into a ResetSystemLib one
>> (which is what the generic driver depends on for platform glue)
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  Platforms/Marvell/Armada/Armada.dsc.inc                       |   4 +-
>>  Platforms/Marvell/Armada/Armada70x0.fdf                       |   2 +-
>>  Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c   | 110 ++++++++++++++------
>>  Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf |   7 +-
>>  4 files changed, 87 insertions(+), 36 deletions(-)
>>
>> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc
>> index 475fc6d05379..32eaa2942564 100644
>> --- a/Platforms/Marvell/Armada/Armada.dsc.inc
>> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc
>> @@ -94,7 +94,7 @@
>>    # Reset and Time libraries
>>    EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf
>>    RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf
>> -  EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf
>> +  ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf
>
> Isn't it better to switch to generic PSCI:
> EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf
> and remove MvResetSystemLib whatsoever?
>

Yes. But Leif tells me that 7040 does not support PSCI?