From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D24C021A00AC9 for ; Tue, 4 Jul 2017 04:09:10 -0700 (PDT) Received: by mail-it0-x230.google.com with SMTP id k192so69890278ith.1 for ; Tue, 04 Jul 2017 04:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=y9mDIxfheNNIaFuLl9VDsRjwIH8l2lL6j7Z/iHC5exY=; b=K8p+dtdoHD5KzozuGrgKDJAdTdS91nxTkWzjGBRGxSmrW5xjl9HhUSIvjGqZEtE1lR wgTH/DpkdmBsXSP3lM9bVJuJsSoKLEt1HQ3f/QS8nZovPVc7GoDZ5tpetti1ttJ2dkXG Q1P3AfWlu1bmhdgTghezW3Tjy7knKwW18dj74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y9mDIxfheNNIaFuLl9VDsRjwIH8l2lL6j7Z/iHC5exY=; b=di9k38evsNKi81cUQH2NyP51zMhfMY5NSCRbcXrLMcDrEvXV5+5Rm4r0aK0i8g+F8n V4gSy/oobr+AHImGBs16Ht2lbPeW6IjQAgPUKEhQu4Q1llRkv6IXIItii7VXpAFYm7gm HTHJkzkVUCO2Izc3ujFy095IOx6+koIX/7dcXvSSIj+pjqhIYuCqIlwolb/TN2i35UWA AAFdmSN+d0hvBtO/fBPpCngF5QHOO08GCxddIcEQVF0dN7Hlnr/gp9N1N5QnQo1lFAYK jymKqHey5IdHIlG5Zhycue4KczunEXOJvO3mwXgH6H3zgWvwqDDuDKG3ihr2QgOXkHxu pLGg== X-Gm-Message-State: AKS2vOxe5essIV6BTqDW6kOQkeKObehedZ2j8oiN200Mvw+al52/tWnZ 85tU+C5K5/S3Q8EWhuAxtEtJvRSwFXxC+zM= X-Received: by 10.36.4.4 with SMTP id 4mr37476657itb.73.1499166648407; Tue, 04 Jul 2017 04:10:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.134.134 with HTTP; Tue, 4 Jul 2017 04:10:47 -0700 (PDT) In-Reply-To: References: <20170704110017.32042-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 4 Jul 2017 12:10:47 +0100 Message-ID: To: Marcin Wojtas Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:09:11 -0000 Content-Type: text/plain; charset="UTF-8" On 4 July 2017 at 12:04, Marcin Wojtas wrote: > Hi, > > 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel : >> Switch to the generic implementation of the ResetSystem() runtime >> service call, which is preferred over the one in EmbeddedPkg. This >> involves selecting another DXE runtime driver, and morphing the >> existing EfiResetSystemLib implementation into a ResetSystemLib one >> (which is what the generic driver depends on for platform glue) >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> Platforms/Marvell/Armada/Armada.dsc.inc | 4 +- >> Platforms/Marvell/Armada/Armada70x0.fdf | 2 +- >> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c | 110 ++++++++++++++------ >> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf | 7 +- >> 4 files changed, 87 insertions(+), 36 deletions(-) >> >> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc >> index 475fc6d05379..32eaa2942564 100644 >> --- a/Platforms/Marvell/Armada/Armada.dsc.inc >> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc >> @@ -94,7 +94,7 @@ >> # Reset and Time libraries >> EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf >> RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf >> - EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >> + ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf > > Isn't it better to switch to generic PSCI: > EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf > and remove MvResetSystemLib whatsoever? > Yes. But Leif tells me that 7040 does not support PSCI?