From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Alexei Fedorov <Alexei.Fedorov@arm.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"liming.gao@intel.com" <liming.gao@intel.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Evan Lloyd <Evan.Lloyd@arm.com>
Subject: Re: [PATCH] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT
Date: Tue, 18 Apr 2017 11:13:25 +0100 [thread overview]
Message-ID: <CAKv+Gu9kYUduDDWrrw1gqMZG39BLe0yyfu+8pBe+rigv5fpJXQ@mail.gmail.com> (raw)
In-Reply-To: <AM5PR0801MB19556CD7F8DED3ECF1C161579A190@AM5PR0801MB1955.eurprd08.prod.outlook.com>
On 18 April 2017 at 11:07, Alexei Fedorov <Alexei.Fedorov@arm.com> wrote:
>
> Aren't comments like
>
> //
> // Table header
> //
>
> ,
>
> //
> // Definition for ID mapping table shared by all node types
> //
>
> etc. not allowed according to EDK II C Coding Standards Specification?
>
> 6.2.3 Avoid comments where the opening comment characters are alone on a
> line.
>
> //
>
> // VIOLATION: Horror Vacui
>
> //
>
You must be joking
$ git grep -E '/\*\*\s$' MdePkg/ MdeModulePkg/ |wc -l
16193
IOW, there are more than 16000 occurrences of opening comment
characters alone on a line in MdePkg+MdeModulePkg only
next prev parent reply other threads:[~2017-04-18 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 16:37 [PATCH] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT Ard Biesheuvel
2017-04-18 10:07 ` Alexei Fedorov
2017-04-18 10:13 ` Ard Biesheuvel [this message]
2017-04-18 11:01 ` Alexei Fedorov
2017-04-18 11:11 ` Ard Biesheuvel
2017-04-18 17:56 ` Ard Biesheuvel
2017-04-18 20:54 ` Kinney, Michael D
2017-04-18 22:21 ` Ard Biesheuvel
2017-04-18 23:51 ` Kinney, Michael D
2017-04-19 7:03 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9kYUduDDWrrw1gqMZG39BLe0yyfu+8pBe+rigv5fpJXQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox