From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4A8A7208F7AA8 for ; Mon, 14 Jan 2019 00:27:04 -0800 (PST) Received: by mail-io1-xd42.google.com with SMTP id s22so16955987ioc.8 for ; Mon, 14 Jan 2019 00:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q2WlV5f1lVmEsJweybjHHMIWAASBwVHxGFSROUFoaMM=; b=SLTl9h9ANEuweB9VlS+dprUWxiWxQE0Uy7X9aAbzbnfVRs4CaW9whBx3uYnYZTt4Ls XPMrZ1P/yxVyaSNnAh9YtdS9yfCUWUEo6KaPuXvNQVLrgH0+AGdJdgFzJ1GuvTPBseG2 1mGTgEoF4Vmmg75UD8STYFrtzAdQlH/mznBnE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q2WlV5f1lVmEsJweybjHHMIWAASBwVHxGFSROUFoaMM=; b=aBYz2cqkKaT2fUwh0ok3NjP/aBLIBqx7H43+NTFOezvMPouUH/f1kzUepWOzhMdmkM 8NIdX5Q7pRfzAdDKY6l1NUqGx6oCvyG4FqpPuYszW7nn+2L+Ud8IxMLBWIXdD7zESLR1 oWyIAGmpJSJbw8ySCDhwF2R7GESNnQrJCP9uC0pGw1be2CfGRBdndlSGkHAmpawHSR+H zlP7+lBhzH8u6s6KKH9SQ5E2S8KUseXRd2D3ypo75/mCI+JDisjOXcELidvp+ZjMoKt+ eYmsVutzGKhbOJS5mBxlpH4WAlvCUYhEP2l0nU59I+UKOSr9vMFNozzpQvPuQgt8JeY2 b3aQ== X-Gm-Message-State: AJcUukeBlEplJIvsuDEz6sXjBTgt9RXRihzpGvEG6WlSqZ8IaW8wu63R rMaoAV5rd4336AqHUQ+qSO608b6WockkxO0G92vfzw== X-Google-Smtp-Source: ALg8bN4b08Gzm8gWIzsrEwOEoxWGLrxrDom0UmZBheWpOIyj8Ej/1zyFXu7TkreEPgYHR54BdaNIIrOp4Yz+Kho6Rqk= X-Received: by 2002:a5d:8410:: with SMTP id i16mr15707075ion.173.1547454424184; Mon, 14 Jan 2019 00:27:04 -0800 (PST) MIME-Version: 1.0 References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AD13F@SHSMSX152.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AE768@SHSMSX152.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B0F9E@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B0F9E@SHSMSX152.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 14 Jan 2019 09:26:52 +0100 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" , Jagadeesh Ujja , Achin Gupta , Thomas Panakamattam Abraham , Sami Mujawar Subject: Re: [PATCH 0/6] implement standalone MM versions of the variable runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 08:27:05 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 14 Jan 2019 at 03:55, Gao, Liming wrote: > > Ard: > I don't find the function issue in this patch. I have no other comments= for the change in MdePkg. Reviewed-by: Liming Gao . = For this patch set, if you push the change, please push the patches in MdeP= kg first, and tell me the revision. I will update our internal platform DSC= to include new MmServicesTableLib library instance. After I am done, I wil= l let you know. Then, you can continue to push the change in MdeModulePkg. = Is it OK? > Yes, that is fine. I will need to respin the remaining patches anyway. I have pushed the following patches b94aecb4ec94 MdePkg/Include: add MmServicesTableLib header file 17f5fd9291e0 MdePkg: implement MmServicesTableLib based on traditional SMM with Star's and Jian's feedback addressed, and your R-b's added. > I see you will continue to look add MmStandaloneEntryPointLib and MmSer= viceLib for MmStandalone driver. You can create another BZ for it. I will r= eview them once you are done. > OK. > >-----Original Message----- > >From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > >Sent: Wednesday, January 09, 2019 11:30 PM > >To: Gao, Liming > >Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Leif Lind= holm > >; Kinney, Michael D ; > >Wang, Jian J ; Wu, Hao A ; > >Jagadeesh Ujja ; Achin Gupta > >; Thomas Panakamattam Abraham > >; Sami Mujawar > >Subject: Re: [PATCH 0/6] implement standalone MM versions of the variabl= e > >runtime drivers > > > >On Wed, 9 Jan 2019 at 14:56, Gao, Liming wrote: > >> > >> Ard: > >> Now, the impact is to update platform DSC to include MmServicesTable= Lib > >library instance. This change is acceptable for me. I suggest your creat= e one BZ > >for this patch set. > > > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D1442 > > > >> Besides, I can't apply for these patches in my machine. Could you sh= are git > >branch to me? Then, I can further verify its functionality on SMM mode. > >> > > > >https://github.com/ardbiesheuvel/edk2/tree/variable-ftw-standalone-mm- > >conversion > > > >Note that I included the changes to add the MmServicesTableLib > >resolution to consumers of the FTW and variable drivers. > > > >Thanks, > >Ard. > > > > > > > >> Thanks > >> Liming > >> > -----Original Message----- > >> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > >> > Sent: Monday, January 7, 2019 9:06 PM > >> > To: Gao, Liming > >> > Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Leif > >Lindholm ; Kinney, Michael D > >> > ; Wang, Jian J ; = Wu, > >Hao A ; Jagadeesh Ujja > >> > ; Achin Gupta ; > >Thomas Panakamattam Abraham ; > >> > Sami Mujawar > >> > Subject: Re: [PATCH 0/6] implement standalone MM versions of the > >variable runtime drivers > >> > > >> > On Mon, 7 Jan 2019 at 13:44, Gao, Liming wrot= e: > >> > > > >> > > Ard: > >> > > I agree this design is good. But, I need some time to evaluate i= ts impact > >on our X86 platform. Could you wait for several days? > >> > > > >> > > >> > Of course. > >> > > >> > Thanks, > >> > > >> > > > -----Original Message----- > >> > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > >> > > > Sent: Friday, January 4, 2019 2:28 AM > >> > > > To: edk2-devel@lists.01.org > >> > > > Cc: Ard Biesheuvel ; Laszlo Ersek > >; Leif Lindholm ; > >> > Kinney, > >> > > > Michael D ; Gao, Liming > >; Wang, Jian J ; Wu, Hao A > >> > > > ; Jagadeesh Ujja ; > >Achin Gupta ; Thomas Panakamattam > >> > > > Abraham ; Sami Mujawar > > > >> > > > Subject: [PATCH 0/6] implement standalone MM versions of the > >variable runtime drivers > >> > > > > >> > > > This series proposed an alternative approach to the series sent = out by > >> > > > Jagadeesh [0]. In particular, it gets rid of the InMm() calls an= d the > >> > > > special PCD, as well as some other if() conditionals. > >> > > > > >> > > > The primary difference is that this series defines and implement= s > >> > > > MmServicesTableLib in such a way that the traditional SMM driver= s > >> > > > can use it as well. This is appropriate, considering that the PI > >> > > > spec has rebranded traditional SMM as one implementation of the > >generic > >> > > > MM framework. > >> > > > > >> > > > Patch #1 is based on Jagadeesh's patch, and introduces the > >MmServicesTableLib > >> > > > library class, but for all SMM flavours, not only for standalone= MM. > >> > > > > >> > > > Patch #2 implements MmServicesTableLib for traditional SMM > >implementations. > >> > > > > >> > > > Patch #3 refactors FaultTolerantWriteDxe so that the parts of th= e SMM > >> > > > driver that invoke boot services are separated from the core SMM > >pieces. > >> > > > > >> > > > Patch #4 implements FaultTolerantWriteSmm for the standalone MM > >environment. > >> > > > > >> > > > Patches #5 and #6 do the same, respectively, for the variable ru= ntime > >driver. > >> > > > > >> > > > This approach minimizes the delta, and thus the maintenance burd= en, > >between > >> > > > the traditional SMM and standalone MM drivers, while not resorti= ng to > >runtime > >> > > > checks or other conditionals in the code to implement logic that= should > >be > >> > > > decided at build time. > >> > > > > >> > > > Note that this series only covers part of the work contributed b= y > >Jagadeesh. > >> > > > This series focuses on the MdePkg and MdeModulePkg changes that > >affect shared > >> > > > code. > >> > > > > >> > > > Cc: Laszlo Ersek > >> > > > Cc: Leif Lindholm > >> > > > Cc: Michael D Kinney > >> > > > Cc: Liming Gao > >> > > > Cc: Jian J Wang > >> > > > Cc: Hao Wu > >> > > > Cc: Jagadeesh Ujja > >> > > > Cc: Achin Gupta > >> > > > Cc: Thomas Panakamattam Abraham > >> > > > Cc: Sami Mujawar > >> > > > > >> > > > Ard Biesheuvel (5): > >> > > > MdePkg: implement MmServicesTableLib based on traditional SMM > >> > > > MdeModulePkg/FaultTolerantWriteDxe: factor out boot service > >accesses > >> > > > MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM > >version > >> > > > MdeModulePkg/VariableRuntimeDxe: factor out boot service > >accesses > >> > > > MdeModulePkg/VariableRuntimeDxe: implement standalone MM > >version > >> > > > > >> > > > Jagadeesh Ujja (1): > >> > > > MdePkg/Include: add MmServicesTableLib header file > >> > > > > >> > > > MdeModulePkg/MdeModulePkg.dsc | 1 + > >> > > > .../FaultTolerantWrite.h | 22 ++- > >> > > > .../FaultTolerantWriteDxe.c | 31 ++++ > >> > > > .../FaultTolerantWriteSmm.c | 54 +++---- > >> > > > .../FaultTolerantWriteSmm.inf | 5 +- > >> > > > .../FaultTolerantWriteSmmCommon.h | 31 ++++ > >> > > > .../FaultTolerantWriteSmmDxe.c | 1 + > >> > > > .../FaultTolerantWriteStandaloneMm.c | 70 +++++++++ > >> > > > .../FaultTolerantWriteStandaloneMm.inf | 90 +++++++++++= + > >> > > > .../FaultTolerantWriteTraditionalMm.c | 94 +++++++++++= + > >> > > > .../UpdateWorkingBlock.c | 10 +- > >> > > > .../Variable/RuntimeDxe/TcgMorLockSmm.c | 18 +-- > >> > > > .../Universal/Variable/RuntimeDxe/Variable.h | 50 +++++++ > >> > > > .../Variable/RuntimeDxe/VariableSmm.c | 59 +++----- > >> > > > .../Variable/RuntimeDxe/VariableSmm.inf | 5 +- > >> > > > .../RuntimeDxe/VariableStandaloneMm.c | 69 +++++++++ > >> > > > .../RuntimeDxe/VariableStandaloneMm.inf | 135 > >++++++++++++++++++ > >> > > > .../RuntimeDxe/VariableTraditionalMm.c | 114 +++++++++++= ++++ > >> > > > MdePkg/Include/Library/MmServicesTableLib.h | 25 ++++ > >> > > > .../MmServicesTableLib/MmServicesTableLib.c | 63 ++++++++ > >> > > > .../MmServicesTableLib/MmServicesTableLib.inf | 45 ++++++ > >> > > > .../MmServicesTableLib/MmServicesTableLib.uni | 22 +++ > >> > > > MdePkg/MdePkg.dec | 4 + > >> > > > MdePkg/MdePkg.dsc | 1 + > >> > > > 24 files changed, 916 insertions(+), 103 deletions(-) > >> > > > create mode 100644 > >MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal > >oneMm.c > >> > > > create mode 100644 > >MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal > >oneMm.inf > >> > > > create mode 100644 > >MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditio > >nalMm.c > >> > > > create mode 100644 > >MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > >> > > > create mode 100644 > >MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > >> > > > create mode 100644 > >MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > >> > > > create mode 100644 MdePkg/Include/Library/MmServicesTableLib.h > >> > > > create mode 100644 > >MdePkg/Library/MmServicesTableLib/MmServicesTableLib.c > >> > > > create mode 100644 > >MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > >> > > > create mode 100644 > >MdePkg/Library/MmServicesTableLib/MmServicesTableLib.uni > >> > > > > >> > > > -- > >> > > > 2.17.1 > >> > >