public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Mark Gregotski <mark.gregotski@linaro.org>
Subject: Re: [PATCH] [edk2-platforms]:resolving Hikey platform build error
Date: Wed, 15 Nov 2017 11:34:56 +0000	[thread overview]
Message-ID: <CAKv+Gu9mf=j7s5A7XE3=r-KcgHUH3FdCi_wtoygWhB_bA=Ls5w@mail.gmail.com> (raw)
In-Reply-To: <20171115112710.20252-1-kalyankumar.nagabhirava@linaro.org>

On 15 November 2017 at 11:27, kalyan-nagabhirava
<kalyankumar.nagabhirava@linaro.org> wrote:
> "Instance of library class [CapsuleLib] is not found" build error is
>  coming for Hikey platform, to resolve this issueadded CapsuleLib to
>  "LibraryClasses.common" section
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as bf109f8b87077a8f8215c9f0af8c9639d50cc64c

Thanks.

> ---
>  Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 968e8acc0..2e3b1c879 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -61,6 +61,7 @@
>    SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
>
>    FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> +  CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>    UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>    PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>    BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> --
> 2.15.0
>


  reply	other threads:[~2017-11-15 11:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 11:27 [PATCH] [edk2-platforms]:resolving Hikey platform build error kalyan-nagabhirava
2017-11-15 11:34 ` Ard Biesheuvel [this message]
     [not found] <CAPcudRgM123V6DLGQLhziXEWuLfZHRhDUr2CxqwQhw8tBaOXEA@mail.gmail.com>
2017-11-14 11:18 ` [PATCH edk2-platforms]: resolving " Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9mf=j7s5A7XE3=r-KcgHUH3FdCi_wtoygWhB_bA=Ls5w@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox