* [PATCH] [edk2-platforms]:resolving Hikey platform build error
@ 2017-11-15 11:27 kalyan-nagabhirava
2017-11-15 11:34 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: kalyan-nagabhirava @ 2017-11-15 11:27 UTC (permalink / raw)
To: edk2-devel, ard.biesheuvel, leif.lindholm
Cc: mark.gregotski, kalyan-nagabhirava
"Instance of library class [CapsuleLib] is not found" build error is
coming for Hikey platform, to resolve this issueadded CapsuleLib to
"LibraryClasses.common" section
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
---
Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
index 968e8acc0..2e3b1c879 100644
--- a/Platform/Hisilicon/HiKey/HiKey.dsc
+++ b/Platform/Hisilicon/HiKey/HiKey.dsc
@@ -61,6 +61,7 @@
SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
+ CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [edk2-platforms]:resolving Hikey platform build error
2017-11-15 11:27 [PATCH] [edk2-platforms]:resolving Hikey platform build error kalyan-nagabhirava
@ 2017-11-15 11:34 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-15 11:34 UTC (permalink / raw)
To: kalyan-nagabhirava; +Cc: edk2-devel@lists.01.org, Leif Lindholm, Mark Gregotski
On 15 November 2017 at 11:27, kalyan-nagabhirava
<kalyankumar.nagabhirava@linaro.org> wrote:
> "Instance of library class [CapsuleLib] is not found" build error is
> coming for Hikey platform, to resolve this issueadded CapsuleLib to
> "LibraryClasses.common" section
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: kalyan-nagabhirava <kalyankumar.nagabhirava@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as bf109f8b87077a8f8215c9f0af8c9639d50cc64c
Thanks.
> ---
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 968e8acc0..2e3b1c879 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -61,6 +61,7 @@
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
>
> FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
> --
> 2.15.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CAPcudRgM123V6DLGQLhziXEWuLfZHRhDUr2CxqwQhw8tBaOXEA@mail.gmail.com>]
* Re: [PATCH edk2-platforms]: resolving Hikey platform build error
[not found] <CAPcudRgM123V6DLGQLhziXEWuLfZHRhDUr2CxqwQhw8tBaOXEA@mail.gmail.com>
@ 2017-11-14 11:18 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-14 11:18 UTC (permalink / raw)
To: Kalyan Nagabhirava; +Cc: edk2-devel@lists.01.org, Mark Gregotski, Leif Lindholm
On 14 November 2017 at 11:16, Kalyan Nagabhirava
<kalyankumar.nagabhirava@linaro.org> wrote:
>
> "Instance of library class [CapsuleLib] is not found" build error is coming
> for Hikey platform, to resolve this issueadded CapsuleLib to
> "LibraryClasses.common" section
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc
> b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 968e8ac..2e3b1c8 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -61,6 +61,7 @@
>
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
>
> FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>
> PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
>
>
Thanks Kalyan
Could you resend it as a proper patch, please? I.e., with the appropriate
Contributed-under: TianoCore Contribution Agreement 1.1
and Signed-off-by line,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-15 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-15 11:27 [PATCH] [edk2-platforms]:resolving Hikey platform build error kalyan-nagabhirava
2017-11-15 11:34 ` Ard Biesheuvel
[not found] <CAPcudRgM123V6DLGQLhziXEWuLfZHRhDUr2CxqwQhw8tBaOXEA@mail.gmail.com>
2017-11-14 11:18 ` [PATCH edk2-platforms]: resolving " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox