public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Andrei Warkentin <awarkentin@vmware.com>
Cc: Pete Batard <pete@akeo.ie>,
	edk2-devel-groups-io <devel@edk2.groups.io>,
	 Leif Lindholm <leif@nuviainc.com>
Subject: Re: [edk2-devel][RESEND][PATCH 1/2] Platform/RPi4: allow overriding TF-A binaries during build
Date: Mon, 2 Mar 2020 19:13:02 +0100	[thread overview]
Message-ID: <CAKv+Gu9nnb+C5mkdDoUPOKvF1z9YtS=YsGJtChtc+XgQL6Od8g@mail.gmail.com> (raw)
In-Reply-To: <BN6PR05MB34111CD9F2DD46DD65FFBA88B9E70@BN6PR05MB3411.namprd05.prod.outlook.com>

On Mon, 2 Mar 2020 at 18:40, Andrei Warkentin <awarkentin@vmware.com> wrote:
>
> Hi Ard,
>
> > Do we really need this patch? For development, you can put anything
> > you want here. For doing releases, I'd expect edk2-platforms to be in
> > sync with edk2-non-osi, given that there are more blobs there than
> > TF-A, right?
>
> This is a developer productivity improvement that I've found to be useful and it has no impact on others for the default case of building code for release.
>
> Sure, you can copy things around and stage/unstage files, but I like automating my work and I tend to track the upstream TF-A (for regressions, rpi4-uefi.dev work),
> so being able to quickly generate builds both with internal and external TF-A and without extra hoopla has been key. The time I avoid dealing with dirty trees is time I can spend elsewhere else making Pi 4 implementation better.
>
> There aren't really any other blobs that matter for Pi 4...The embedded DTB is going to go away as part of fixing the regression seen with  https://github.com/pftf/RPi4/issues/17 (on the Pi 4 you can't really boot anyway without passing a DTB in config.txt).
>

Fair enough. I still don't quite see the point, but I don't really mind either.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 30324eefb3a4..07cc442f7212

  reply	other threads:[~2020-03-02 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 14:42 [edk2-devel][RESEND][PATCH 0/2] Resend of the 2 previous RPi patches Pete Batard
2020-03-02 14:42 ` [edk2-devel][RESEND][PATCH 1/2] Platform/RPi4: allow overriding TF-A binaries during build Pete Batard
2020-03-02 14:54   ` Ard Biesheuvel
2020-03-02 17:40     ` Andrei Warkentin
2020-03-02 18:13       ` Ard Biesheuvel [this message]
2020-03-02 14:42 ` [edk2-devel][RESEND][PATCH 2/2] Platform/RPi4/Library/PlatformBootManagerLib: remove dead logo code Pete Batard
2020-03-02 14:49   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9nnb+C5mkdDoUPOKvF1z9YtS=YsGJtChtc+XgQL6Od8g@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox