From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web09.18789.1583172795337818443 for ; Mon, 02 Mar 2020 10:13:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ojd1xx7x; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id m3so75728wmi.0 for ; Mon, 02 Mar 2020 10:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fdvKrctWTIKvFoVkpOS96HpEtXQllObji5qCMV68aWk=; b=ojd1xx7xvXM8KWZTOrSQCEdh0HsfR1zQviD1n/SH6PB8PJATRScaKVWdHPYdwAo4sn 1cXYKBvh1kFDA3BmsYHkhQ6RUFOYaDVsRzhu3FJqdcx+EYvnPazNdhOGqWMKxT5R8mMx //jUzpLICRKipnnj7TMfuvnV4ZiNn2p0CsKwmyPh6Gs6hXwRoY0JNevocyqhLJKjIaCl cqMOwX4XmYWzyuaplCFOLoJBZ+SdjVSSseLQGKwvRjWTCezBgdZ1JhnpiLmavgB45+FL aIbIKPJGtPU9JjES363e9nHcE0AX/bJHj8sWOfwuygYgaP/XKtxbV7BjdWo4M67s4YQj PC+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fdvKrctWTIKvFoVkpOS96HpEtXQllObji5qCMV68aWk=; b=nWn9ekislNSefgiTx2mlARDxvUkgR+8FOLEf0y6bUv5FVmr/qJbKujnYHkvuEMas37 XwqcFOM5yiugWSvV56VnObzIPvwctYmpaJpcNGyEQp5iaXJ9txMmB1BHwitx0CtThdpL 0Oj/ywq6Z4BAyOB5/ToaBgYtaThHh4nlP8oJr9asq7p+3mSfj4XSQuyymcYftS8lyzw5 oJxdgRrQB3bhjFhZuWVBIoSKB457bIcOdS0YHpp56zzEZAkHZFy8oT8d3PO49E6H5ws3 NHBDUYhTOTnupPW55RSg6TqRRTba2gsSfzaDPc9qBqBDZi2jW96gIuYwSC5UpeRvpA+x uxMA== X-Gm-Message-State: ANhLgQ2Ob+t3o7yzZAXcyOvKpZ7MH+4YAT3+XMKtlhlzrKBDC7bzVtfD +xfN1c1Mjz16XRsY6XN3zdfMwPZiubbXGMjS4nbrLA== X-Google-Smtp-Source: ADFU+vudjyvFdjgiY46BGbrUIrTg2f9th6E1SaHWyC3wop0Z8S2eDqnnPDNXgHXdw0AMQ1NznMkIrNciQFLN8KTVMfo= X-Received: by 2002:a05:600c:24b:: with SMTP id 11mr274218wmj.1.1583172793816; Mon, 02 Mar 2020 10:13:13 -0800 (PST) MIME-Version: 1.0 References: <20200302144219.10452-1-pete@akeo.ie> <20200302144219.10452-2-pete@akeo.ie> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 2 Mar 2020 19:13:02 +0100 Message-ID: Subject: Re: [edk2-devel][RESEND][PATCH 1/2] Platform/RPi4: allow overriding TF-A binaries during build To: Andrei Warkentin Cc: Pete Batard , edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2 Mar 2020 at 18:40, Andrei Warkentin wrote= : > > Hi Ard, > > > Do we really need this patch? For development, you can put anything > > you want here. For doing releases, I'd expect edk2-platforms to be in > > sync with edk2-non-osi, given that there are more blobs there than > > TF-A, right? > > This is a developer productivity improvement that I've found to be useful= and it has no impact on others for the default case of building code for r= elease. > > Sure, you can copy things around and stage/unstage files, but I like auto= mating my work and I tend to track the upstream TF-A (for regressions, rpi4= -uefi.dev work), > so being able to quickly generate builds both with internal and external = TF-A and without extra hoopla has been key. The time I avoid dealing with d= irty trees is time I can spend elsewhere else making Pi 4 implementation be= tter. > > There aren't really any other blobs that matter for Pi 4...The embedded D= TB is going to go away as part of fixing the regression seen with https://= github.com/pftf/RPi4/issues/17 (on the Pi 4 you can't really boot anyway wi= thout passing a DTB in config.txt). > Fair enough. I still don't quite see the point, but I don't really mind eit= her. Reviewed-by: Ard Biesheuvel Pushed as 30324eefb3a4..07cc442f7212