From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 73440220EE111 for ; Tue, 12 Dec 2017 11:22:53 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id u62so970902ita.2 for ; Tue, 12 Dec 2017 11:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5NurQUEX2jqbOgy9Sae4DzQQHnJBAmGCP0lUKEIAK5k=; b=Ui6ujhmX2zjK66xPlS1DjdZ09gXgcnklhGlFIohm3R2n+VmWdKgHv/zFw8vDw4Dmw+ pBYtMcs7jyHJZUR60P4WgZZ0JkH8mHj0+jrsxZI4Vce5VRw8w7qxQT3F/3XiZTFTVtaZ mpR92t0OwLFLRQPVCT6E+nPp384yWBY+wvMRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5NurQUEX2jqbOgy9Sae4DzQQHnJBAmGCP0lUKEIAK5k=; b=aD3lZ2NfYn9KAbc0wdVVgBdpMMC8DcHGA2ZU/3/n6lCZ8dZjDb6hcm0S8BYhwlNboD KFwOP747pLTfqOUzCPz+HpPQ7FeOBOKp2bF2yc89g61FcbmItZ53qHGrMDpNRFTE3maY STsJ4VXIOLa3RC0BEO55YjI9Wxt/mClQ2+99vdy2jO0/Dg8e31jQ3D2H009CTqKdA6TO S/G+PUaEqKhN5gyAJF1V6bfRehC/I7TeSAIbD45xUTQ4TuHRJgBVnCcQxpl+x93zHkfV /3ApAtD+X/H6LNL03+NthLM6dsOa/b1fBIrbMcw7ZpjTfzH+nq1XzT79WfvIQNNE9Urt qeuQ== X-Gm-Message-State: AKGB3mK5bQ2vz58R8sk7gj0MY5qcXT3h2coeAZVI83VtOZuHuwZ5BBcQ Umle+djyzj9/0LjkJehMzlXijT8hcoKQ1QWlMxkGOQ== X-Google-Smtp-Source: ACJfBos6PaSFcBOEw5/7+rfD6f6Xh53TA+QNRh+03yI80hKvnDHZgJQ3u+ZGvX4eLqj7D/S/CEHTSlqDBXaW3lgM/Vk= X-Received: by 10.36.78.212 with SMTP id r203mr1036184ita.58.1513106851520; Tue, 12 Dec 2017 11:27:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Tue, 12 Dec 2017 11:27:30 -0800 (PST) In-Reply-To: <20171212171244.z44kzls6jrfrrqls@bivouac.eciton.net> References: <20171208182732.8891-1-ard.biesheuvel@linaro.org> <20171211154204.lcdzebwhub6yiwy6@bivouac.eciton.net> <20171212171244.z44kzls6jrfrrqls@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 12 Dec 2017 19:27:30 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPlatformPkg: retire obsolete PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 19:22:53 -0000 Content-Type: text/plain; charset="UTF-8" On 12 December 2017 at 17:12, Leif Lindholm wrote: > On Mon, Dec 11, 2017 at 05:57:09PM +0000, Ard Biesheuvel wrote: >> On 11 December 2017 at 15:42, Leif Lindholm wrote: >> > On Fri, Dec 08, 2017 at 06:27:32PM +0000, Ard Biesheuvel wrote: >> >> Retire a whole bunch of ArmPlatformPkg PCDs that are either related >> >> to the ARM BDS, to secure world execution or to stuff that has been >> >> migrated to edk2-platforms. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel >> > >> > Commenting out-of-order... >> > By the time we get to this, should we not also delete >> > ## PL111 Lcd & HdLcd >> > gArmPlatformTokenSpaceGuid.PcdPL111LcdBase|0x0|UINT32|0x00000026 >> > gArmPlatformTokenSpaceGuid.PcdArmHdLcdBase|0x0|UINT32|0x00000027 >> > ? >> > >> >> Nope, as you just found out yourself. > > Yes, so: > Reviewed-by: Leif Lindholm > Thanks. Pushed as f9669f09fb53081ba3253ba0f9ac61b68229b761 And that wraps up this fall edition of the ArmPlatformPkg spring cleaning! >> >> >> --- >> >> ArmPlatformPkg/ArmPlatformPkg.dec | 41 -------------------- >> >> 1 file changed, 41 deletions(-) >> >> >> >> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec >> >> index b33b6e630d85..7cec775abeee 100644 >> >> --- a/ArmPlatformPkg/ArmPlatformPkg.dec >> >> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec >> >> @@ -45,13 +45,7 @@ [Guids.common] >> >> # >> >> gVariableRuntimeDxeFileGuid = { 0xcbd2e4d5, 0x7068, 0x4ff5, { 0xb4, 0x62, 0x98, 0x22, 0xb4, 0xad, 0x8d, 0x60 } } >> >> >> >> - gArmBootMonFsFileInfoGuid = { 0x41e26b9c, 0xada6, 0x45b3, { 0x80, 0x8e, 0x23, 0x57, 0xa3, 0x5b, 0x60, 0xd6 } } >> >> - >> >> [PcdsFeatureFlag.common] >> >> - # Set this PCD to TRUE to map NORFlash at 0x0. FALSE means the DRAM is mapped at 0x0. >> >> - gArmPlatformTokenSpaceGuid.PcdNorFlashRemapping|FALSE|BOOLEAN|0x00000012 >> >> - >> >> - gArmPlatformTokenSpaceGuid.PcdStandalone|TRUE|BOOLEAN|0x00000001 >> >> gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores|FALSE|BOOLEAN|0x00000004 >> >> >> >> gArmPlatformTokenSpaceGuid.PcdNorFlashCheckBlockLocked|FALSE|BOOLEAN|0x0000003C >> >> @@ -60,18 +54,10 @@ [PcdsFeatureFlag.common] >> >> # we assume the OS will handle the FrameBuffer from the UEFI GOP information. >> >> gArmPlatformTokenSpaceGuid.PcdGopDisableOnExitBootServices|FALSE|BOOLEAN|0x0000003D >> >> >> >> - # Enable Legacy Linux support in the BDS >> >> - gArmPlatformTokenSpaceGuid.PcdBdsLinuxSupport|FALSE|BOOLEAN|0x0000002E >> >> - >> >> [PcdsFixedAtBuild.common] >> >> gArmPlatformTokenSpaceGuid.PcdCoreCount|1|UINT32|0x00000039 >> >> gArmPlatformTokenSpaceGuid.PcdClusterCount|1|UINT32|0x00000038 >> >> >> >> - # Stack for CPU Cores in Secure Mode >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoresSecStackBase|0|UINT64|0x00000005 >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecPrimaryStackSize|0x10000|UINT32|0x00000036 >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecSecondaryStackSize|0x1000|UINT32|0x00000006 >> >> - >> >> # Stack for CPU Cores in Non Secure Mode >> >> gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0|UINT64|0x00000009 >> >> gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x10000|UINT32|0x00000037 >> >> @@ -80,9 +66,6 @@ [PcdsFixedAtBuild.common] >> >> # Size of the region used by UEFI in permanent memory (Reserved 128MB by default) >> >> gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x08000000|UINT32|0x00000015 >> >> >> >> - # Boot Monitor FileSystem >> >> - gArmPlatformTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L""|VOID*|0x0000003A >> >> - >> >> # >> >> # ARM Primecells >> >> # >> >> @@ -114,33 +97,9 @@ [PcdsFixedAtBuild.common] >> >> gArmPlatformTokenSpaceGuid.PcdPL180SysMciRegAddress|0x00000000|UINT32|0x00000028 >> >> gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress|0x00000000|UINT32|0x00000029 >> >> >> >> - # >> >> - # BDS - Boot Manager >> >> - # >> >> - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"ARM Platform"|VOID*|0x00000019 >> >> - gArmPlatformTokenSpaceGuid.PcdDefaultBootDescription|L"Default Boot Device"|VOID*|0x0000000C >> >> - gArmPlatformTokenSpaceGuid.PcdDefaultBootDevicePath|L""|VOID*|0x0000000D >> >> - gArmPlatformTokenSpaceGuid.PcdDefaultBootArgument|L""|VOID*|0x000000F >> >> - >> >> - gArmPlatformTokenSpaceGuid.PcdDefaultConInPaths|L""|VOID*|0x0000001B >> >> - gArmPlatformTokenSpaceGuid.PcdDefaultConOutPaths|L""|VOID*|0x0000001C >> >> - >> >> [PcdsFixedAtBuild.common,PcdsDynamic.common] >> >> ## PL031 RealTimeClock >> >> gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x0|UINT32|0x00000024 >> >> gArmPlatformTokenSpaceGuid.PcdPL031RtcPpmAccuracy|300000000|UINT32|0x00000022 >> >> >> >> gArmPlatformTokenSpaceGuid.PcdWatchdogCount|0x0|UINT32|0x00000033 >> >> - >> >> -[PcdsFixedAtBuild.ARM] >> >> - # Stack for CPU Cores in Secure Monitor Mode >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoresSecMonStackBase|0|UINT64|0x00000007 >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecMonStackSize|0x1000|UINT32|0x00000008 >> >> - >> >> -[PcdsFixedAtBuild.AARCH64] >> >> - # The Secure World is only running in EL3. Only one set of stacks is needed for AArch64. >> >> - # The Secure stacks are described by PcdCPUCoresSecStackBase, PcdCPUCoreSecPrimaryStackSize >> >> - # and PcdCPUCoreSecSecondaryStackSize >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoresSecMonStackBase|0|UINT64|0x00000007 >> >> - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecMonStackSize|0x0|UINT32|0x00000008 >> >> - >> >> -- >> >> 2.11.0 >> >>