From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d35; helo=mail-io1-xd35.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EFCE4211B5A2D for ; Mon, 21 Jan 2019 13:23:11 -0800 (PST) Received: by mail-io1-xd35.google.com with SMTP id s8so5161881iob.13 for ; Mon, 21 Jan 2019 13:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YNJ47MBAg6YDJ1kXtfgIIIp5QHNrFqLIkOrHyuDRFlg=; b=KdlgiZdr40pHKkM9NqYFUU0e2696seB5DX6PT48i0oPZUnfELx36MDEmqEczmJCxCd EH91jNrTRMv3PTmUXqbhWueZoAZtbYldoA9im84tnpuaK4y9KIJpq8tGeY+m+gN67sG+ WQnp57due/JCK3ULjqlYlahSPY++g0ZGoOTcI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YNJ47MBAg6YDJ1kXtfgIIIp5QHNrFqLIkOrHyuDRFlg=; b=n5ST/f097ugizpxBgGyPK6Ku02/Ty+cqhrW5sRrOMdiQwBs0K5/m3jUjWhB/JgHGGO rZXlJLu5shQpNPnGlNRhtpBY/Ec12sU8r604DqNo7pQ500mHiqnTIDGWNXN1o4CgBLrl 7tLBMGaaSyJrR7De4BBzFk1UM9HfEwm4VqVYNh+cSljzeT0BsLcUXpIoYwvhS90Ag/K9 LeohYrw8FnewRh3qL3ru/RTxDy73ylpyzGmRFRYt142L4P9Z8cjsH0XDNTLwf3/REQ/9 pkYpk5S9q52cJWwilSeMfrfavBbqfqQ/BFOdTiHpEND03EjvsgfX9MdhHqVcjdYLVpdT Ammw== X-Gm-Message-State: AJcUukc5A4LDkipFaSlwzA4xFI677p3xgRZSXF8PS0WKj+FxQrmMEyfj /alEm7AMv9kC2aPt0+xuejiYL4e2HspTITueDQqX0Q== X-Google-Smtp-Source: ALg8bN6Zg8vC1c9t6/EDou97KpssPNakWnB0vPImQmijRz7XDIzOvOVorpBWJnwrfSAkGMlrIpRkqeZnGGD2nJqFrBE= X-Received: by 2002:a5e:c206:: with SMTP id v6mr18445847iop.60.1548105790776; Mon, 21 Jan 2019 13:23:10 -0800 (PST) MIME-Version: 1.0 References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-11-git-send-email-star.zeng@intel.com> <7da72765-785c-2499-eefd-d887a946c946@redhat.com> <6263ebd0-4c6a-97bd-7e04-c4f26ec21aa2@linaro.org> <01237fea-c440-a810-eb51-45646f26238e@intel.com> <1a2a4290-c22c-e42d-cb66-a4ec3e3cf90a@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Mon, 21 Jan 2019 22:22:59 +0100 Message-ID: To: Laszlo Ersek Cc: Julien Grall , "Zeng, Star" , "edk2-devel@lists.01.org" Subject: Re: [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 21:23:12 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 21 Jan 2019 at 22:15, Laszlo Ersek wrote: > > Hi Julien, > > On 01/21/19 14:36, Julien Grall wrote: > > Hi, > > > > On 21/01/2019 10:46, Zeng, Star wrote: > >> On 2019/1/18 2:59, Julien Grall wrote: > >> I saw the discussion at > >> https://lists.01.org/pipermail/edk2-devel/2019-January/035405.html. Fortunately, > >> it has been fixed. > >> So I did rebase for the code. > >> Repo: git@github.com:lzeng14/edk2.git > >> Branch: MergedVariableDriver_EmuNvMode_V3_rebased > > > > I was about to ask a branch as there were conflicts in the rebase. > > Thank you for providing the branch! > > > >> > >> If you can help have a quick test, that will be very helpful. :) > > > > With your series applied, EDK2 is crashing while the Linux EFI stub > > is running. See the log below. > > > > My knowledge of EDK2 is quite limited, so I am not entirely where to > > look at. I am happy to help debugging if you provide guidance. > > Let's focus on the following excerpts: > > > Synchronous Exception at 0x000000007BE70698 > > PC 0x00007BE70698 (0x00007BE60000+0x00010698) [ 0] RuntimeDxe.dll > > PC 0x000078AFECB0 (0x000078AE0000+0x0001ECB0) [ 1] VariableRuntimeDxe.dll > > PC 0x000078AF0AC8 (0x000078AE0000+0x00010AC8) [ 1] VariableRuntimeDxe.dll > > PC 0x00007BE7094C (0x00007BE60000+0x0001094C) [ 2] RuntimeDxe.dll > > and > > > [ 0] /home/julien/works/edk2/Build/ArmVirtXen-AARCH64/DEBUG_GCC49/AARCH64/MdeModulePkg/Core/RuntimeDxe/RuntimeDxe/DEBUG/RuntimeDxe.dll > > [ 1] /home/julien/works/edk2/Build/ArmVirtXen-AARCH64/DEBUG_GCC49/AARCH64/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe/DEBUG/VariableRuntimeDxe.dll > > [ 2] /home/julien/works/edk2/Build/ArmVirtXen-AARCH64/DEBUG_GCC49/AARCH64/MdeModulePkg/Core/RuntimeDxe/RuntimeDxe/DEBUG/RuntimeDxe.dll > > Please run "objdump -S" on the DLL files listed in [0] through [2]. > > In the listings, please try to locate the neighborhood of the relative > offsets that are listed in the stack dump (such as 0x10698 and 0x1094C > in "RuntimeDxe.dll", and 0x1ECB0 and 0x10AC8 in "VariableRuntimeDxe.dll"). > > The disassembly should be intermixed with C source code, and four stack > frames with C language snippets should help us establish a rudimentary > call chain. > > (CC'ing Ard as well.) > I already did the same. The crash is in a call to EfiConvertPointer () from VariableClassAddressChangeEvent (), which dereferences mVariableModuleGlobal->FvbInstance, which may be NULL in the EMU use case. It is very surprising that this only happens on ARM, though ...