[RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Gao, Liming]

Hi, all
  tools_def.template includes all tool chains. Some are not used any more. And, there is no verification for them. So, I propose to remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11, MYTOOLS. If you still use some one of them, please let me know.

Thanks
Liming

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Laszlo Ersek]

On 12/06/18 15:42, Gao, Liming wrote:
> Hi, all tools_def.template includes all tool chains. Some are not
> used any more. And, there is no verification for them. So, I propose
> to remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
> UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
> MYTOOLS. If you still use some one of them, please let me know.

I don't know how to reach out to Linux distros (hopefully their
representatives are already subscribed to this list), but we should
really pose this question to them.

Regarding GCC44, that's the compiler in RHEL6, and RHEL6 is not EOL. On
the other hand, I don't see any reason why anyone would prefer RHEL6 to
RHEL7+ (or recent Fedora) for doing upstream edk2 development. (RHEL6
itself does not ship any edk2 firmware platform.)

So, from a Fedora & RHEL perspective, I'm OK with dropping GCC44..GCC47
inclusive (please do keep GCC48). And, outside of the GCC toolchain
family, I'm neutral.

Thanks,
Laszlo

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Ard Biesheuvel]

On Thu, 6 Dec 2018 at 15:42, Gao, Liming <liming.gao@intel.com> wrote:
>
> Hi, all
>   tools_def.template includes all tool chains. Some are not used any more. And, there is no verification for them. So, I propose to remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790, UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11, MYTOOLS. If you still use some one of them, please let me know.
>

Excellent idea!

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Leif Lindholm]

On Thu, Dec 06, 2018 at 02:42:35PM +0000, Gao, Liming wrote:
> Hi, all
>   tools_def.template includes all tool chains. Some are not used any
>   more. And, there is no verification for them. So, I propose to
>   remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
>   UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
>   MYTOOLS. If you still use some one of them, please let me know.

This sounds good to me.

However, may I suggest splitting this up into several patches, such
that if we need to revert one of the deletions, we would not need to
reinstate all of them.

I would propose:
- One patch for VS20nn
- One patch for GCCnn
- One patch for UNIXGCC, ELFGCC, CYGGCC

I can't really judge what a suitable mashup/split between DDK3790,
ICC, ICC11, and MYTOOLS would be.

On a sidenote, I think Rebecca said at least FreeBSD were using
UNIXGCC(?) since the plain GCC toolchain profiles did not support
cross compiling. I am pretty sure that is not accurate these days -
did you look into that after the community call?

Regards.

Leif

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Gao, Liming]

Leif:
  Thanks for your suggestion. I will work out the patch set serials to remove those tool chains. I don't remember the usage model of UNIXGCC. II will wait for Rebecca response. 

Thanks
Liming
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, December 10, 2018 7:57 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel@lists.01.org; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bluestop.org>
> Subject: Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template
> 
> On Thu, Dec 06, 2018 at 02:42:35PM +0000, Gao, Liming wrote:
> > Hi, all
> >   tools_def.template includes all tool chains. Some are not used any
> >   more. And, there is no verification for them. So, I propose to
> >   remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
> >   UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
> >   MYTOOLS. If you still use some one of them, please let me know.
> 
> This sounds good to me.
> 
> However, may I suggest splitting this up into several patches, such
> that if we need to revert one of the deletions, we would not need to
> reinstate all of them.
> 
> I would propose:
> - One patch for VS20nn
> - One patch for GCCnn
> - One patch for UNIXGCC, ELFGCC, CYGGCC
> 
> I can't really judge what a suitable mashup/split between DDK3790,
> ICC, ICC11, and MYTOOLS would be.
> 
> On a sidenote, I think Rebecca said at least FreeBSD were using
> UNIXGCC(?) since the plain GCC toolchain profiles did not support
> cross compiling. I am pretty sure that is not accurate these days -
> did you look into that after the community call?
> 
> Regards.
> 
> Leif

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[David F.]

I uses VS2008


On Mon, Dec 10, 2018 at 4:38 AM Gao, Liming <liming.gao@intel.com> wrote:

> Leif:
>   Thanks for your suggestion. I will work out the patch set serials to
> remove those tool chains. I don't remember the usage model of UNIXGCC. II
> will wait for Rebecca response.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Monday, December 10, 2018 7:57 PM
> > To: Gao, Liming <liming.gao@intel.com>
> > Cc: edk2-devel@lists.01.org; Laszlo Ersek (lersek@redhat.com) <
> lersek@redhat.com>; afish@apple.com; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bluestop.org>
> > Subject: Re: [RFC] Remove unused tool chain configuration in
> BaseTools/Conf/tools_def.template
> >
> > On Thu, Dec 06, 2018 at 02:42:35PM +0000, Gao, Liming wrote:
> > > Hi, all
> > >   tools_def.template includes all tool chains. Some are not used any
> > >   more. And, there is no verification for them. So, I propose to
> > >   remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
> > >   UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
> > >   MYTOOLS. If you still use some one of them, please let me know.
> >
> > This sounds good to me.
> >
> > However, may I suggest splitting this up into several patches, such
> > that if we need to revert one of the deletions, we would not need to
> > reinstate all of them.
> >
> > I would propose:
> > - One patch for VS20nn
> > - One patch for GCCnn
> > - One patch for UNIXGCC, ELFGCC, CYGGCC
> >
> > I can't really judge what a suitable mashup/split between DDK3790,
> > ICC, ICC11, and MYTOOLS would be.
> >
> > On a sidenote, I think Rebecca said at least FreeBSD were using
> > UNIXGCC(?) since the plain GCC toolchain profiles did not support
> > cross compiling. I am pretty sure that is not accurate these days -
> > did you look into that after the community call?
> >
> > Regards.
> >
> > Leif
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Hiber He]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 2658 bytes --]

Hello,


I think it's better to separate different toolchains in different files and use "include" to include them. This can significantly reduce the difficulty of maintenance and anyone who still wants/has to use older toolchains can have a chance to follow the edk2-master. 


Old toolchains can be marked as obsolete and deprecated, and be removed after the change. The person who still want to use it is responsible for  maintaining and fixing bugs he found from then on.


This can aslo make it easier to add personal changes and future toolchains. The current "tools_def.template" is too huge and complicated.


I remember that someone should have suggested it before.


Best Regards,
Hiber
On 12/10/2018 20:38, Gao, Liming wrote:
Leif:
 Thanks for your suggestion. I will work out the patch set serials to remove those tool chains. I don't remember the usage model of UNIXGCC. II will wait for Rebecca response.

Thanks
Liming
> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, December 10, 2018 7:57 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel@lists.01.org; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>; afish@apple.com; Kinney, Michael D
> <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bluestop.org>
> Subject: Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template
>
> On Thu, Dec 06, 2018 at 02:42:35PM +0000, Gao, Liming wrote:
> > Hi, all
> >   tools_def.template includes all tool chains. Some are not used any
> >   more. And, there is no verification for them. So, I propose to
> >   remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
> >   UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
> >   MYTOOLS. If you still use some one of them, please let me know.
>
> This sounds good to me.
>
> However, may I suggest splitting this up into several patches, such
> that if we need to revert one of the deletions, we would not need to
> reinstate all of them.
>
> I would propose:
> - One patch for VS20nn
> - One patch for GCCnn
> - One patch for UNIXGCC, ELFGCC, CYGGCC
>
> I can't really judge what a suitable mashup/split between DDK3790,
> ICC, ICC11, and MYTOOLS would be.
>
> On a sidenote, I think Rebecca said at least FreeBSD were using
> UNIXGCC(?) since the plain GCC toolchain profiles did not support
> cross compiling. I am pretty sure that is not accurate these days -
> did you look into that after the community call?
>
> Regards.
>
> Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
\x16º&

Re: [RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Gao, Liming]

Hiber:
 For unused tool chain, I propose to remove them all in edk2/master. They can still be found in previous edk2 release. 

 After remove obsolete tool chain, we still have more than 10 tool chains. The remaining tool chain be use include syntax for further simplification. So, could you submit BZ for it first? If you would like to contribute patch to support include and simplify tools_def.txt, it will be fine. 

Thanks
Liming
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Hiber He
>Sent: Wednesday, December 12, 2018 9:02 AM
>To: Gao, Liming <liming.gao@intel.com>
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-
>devel@lists.01.org; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>
>Subject: Re: [edk2] [RFC] Remove unused tool chain configuration in
>BaseTools/Conf/tools_def.template
>
>Hello,
>
>
>I think it's better to separate different toolchains in different files and use
>"include" to include them. This can significantly reduce the difficulty of
>maintenance and anyone who still wants/has to use older toolchains can have
>a chance to follow the edk2-master.
>
>
>Old toolchains can be marked as obsolete and deprecated, and be removed
>after the change. The person who still want to use it is responsible for
>maintaining and fixing bugs he found from then on.
>
>
>This can aslo make it easier to add personal changes and future toolchains.
>The current "tools_def.template" is too huge and complicated.
>
>
>I remember that someone should have suggested it before.
>
>
>Best Regards,
>Hiber
>On 12/10/2018 20:38, Gao, Liming wrote:
>Leif:
> Thanks for your suggestion. I will work out the patch set serials to remove
>those tool chains. I don't remember the usage model of UNIXGCC. II will wait
>for Rebecca response.
>
>Thanks
>Liming
>> -----Original Message-----
>> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
>> Sent: Monday, December 10, 2018 7:57 PM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel@lists.01.org; Laszlo Ersek (lersek@redhat.com)
><lersek@redhat.com>; afish@apple.com; Kinney, Michael D
>> <michael.d.kinney@intel.com>; Rebecca Cran <rebecca@bluestop.org>
>> Subject: Re: [RFC] Remove unused tool chain configuration in
>BaseTools/Conf/tools_def.template
>>
>> On Thu, Dec 06, 2018 at 02:42:35PM +0000, Gao, Liming wrote:
>> > Hi, all
>> >   tools_def.template includes all tool chains. Some are not used any
>> >   more. And, there is no verification for them. So, I propose to
>> >   remove them. They are VS2003, VS2005, VS2008, VS2010, DDK3790,
>> >   UNIXGCC, GCC44, GCC45, GCC46, GCC47, ELFGCC, CYGGCC, ICC, ICC11,
>> >   MYTOOLS. If you still use some one of them, please let me know.
>>
>> This sounds good to me.
>>
>> However, may I suggest splitting this up into several patches, such
>> that if we need to revert one of the deletions, we would not need to
>> reinstate all of them.
>>
>> I would propose:
>> - One patch for VS20nn
>> - One patch for GCCnn
>> - One patch for UNIXGCC, ELFGCC, CYGGCC
>>
>> I can't really judge what a suitable mashup/split between DDK3790,
>> ICC, ICC11, and MYTOOLS would be.
>>
>> On a sidenote, I think Rebecca said at least FreeBSD were using
>> UNIXGCC(?) since the plain GCC toolchain profiles did not support
>> cross compiling. I am pretty sure that is not accurate these days -
>> did you look into that after the community call?
>>
>> Regards.
>>
>> Leif
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel

[RFC] Remove unused tool chain configuration in BaseTools/Conf/tools_def.template

[Zhang, Shenglei]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

Hi All,

There is no Intel compiler test. I suggest to remove ICC tool chain from tools_def.template. After this update, INTEL tool family is not used. So, MdePkg library can be updated to remove it. And also MS ASL is not verified now. I suggest to remove tool chain with ASL tool. They are: VS2008xASL, VS2008x86xASL, VS2010xASL, VS2010x86xASL, VS2012xASL, VS2012x86xASL, VS2013xASL, VS2013x86xASL, VS2015xASL, VS2015x86xASL and CYGGCCxASL.
If you still use one of them, please let me know.

Thanks,
Shenglei


[-- Attachment #2: Type: text/html, Size: 2873 bytes --]